[bug #62929] Normalize foo/./bar

Additional Item Attachment, bug #62929 (project make): File name: sv62929_fix.diff Size:3 KB File name: sv62929_test.diff Size:1 KB

[bug #62929] Normalize foo/./bar

Follow-up Comment #1, bug #62929 (project make): Make fails to normalize foo/./bar as foo/bar. The original bug report is here https://lists.gnu.org/archive/html/bug-make/2022-08/msg00064.html ___ Reply to this item at:

[bug #62929] Normalize foo/./bar

: None ___ Follow-up Comments: --- Date: Sun 21 Aug 2022 03:38:36 AM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savannah.gnu

Re: False positive "doesn't match the target pattern" error

On Sat, Aug 20, 2022 at 8:28 PM Masahiro Yamada wrote: > build-dirs := . drivers sound net virt arch/x86/pci arch/x86/power lib > arch/x86/lib > subdir-modorder := $(addsuffix /.modules.order, $(build-dirs)) > $(sort $(subdir-modorder)): %/.modules.order: % Can you remove . from build-dirs and

[bug #63111] Regression. make runs out of file descriptors.

: None ___ Follow-up Comments: --- Date: Mon 26 Sep 2022 09:35:21 PM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #63111] Regression. make runs out of file descriptors.

Follow-up Comment #1, bug #63111 (project make): A user reported an issue where make runs out of file descriptors. The original bug report is here https://lists.gnu.org/archive/html/bug-make/2022-09/msg00122.html This makefile in question has the following problematic make code %.tab.c

Re: Make 4.3.90 breaks makefile of dtc

On Mon, Sep 26, 2022 at 8:59 AM Andreas Schwab wrote: > Try building it with make -O -j4 V=1, and watch /tmp filling with Gm* i was able to reproduce this. See https://savannah.gnu.org/bugs/index.php?63111. You correctly identified the offending rule. Thanks for your report. regards, Dmitry

[bug #63126] Fix typos in paragraph "Loading Dynamic Objects".

Additional Item Attachment, bug #63126 (project make): File name: sv63126.diff Size:3 KB ___ Reply to this item at:

[bug #63126] Fix typos in paragraph "Loading Dynamic Objects".

Triage Status: None ___ Follow-up Comments: --- Date: Wed 28 Sep 2022 09:26:44 PM UTC By: Dmitry Goncharov This patch fixes a couple of typos and omissio

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

Additional Item Attachment, bug #63185 (project make): File name: sv63185.diff Size:0 KB ___ Reply to this item at:

[bug #63236] Fix getloadavg related error message.

Additional Item Attachment, bug #63236 (project make): File name: sv63236.diff Size:0 KB ___ Reply to this item at:

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

Follow-up Comment #4, bug #63185 (project make): This piece of code +#ifdef HAVE_SYS_LOADAVG_H +# include +#endif indeed helps on sun, because sun has sys/loadavg.h. However, aix does not have sys/loadavg.h (i didn't find a declaration of getloadavg in any header on aix) and the

[bug #63236] Fix getloadavg related error message.

Follow-up Comment #1, bug #63236 (project make): On aix (actually possible on any system) getloadavg fails and keeps errno intact. This results in a bogus error message from make. The patch resets errno before calling getloadavg. $ cat makefile MAKEFLAGS:=-Rr all: 1.x 2.x 3.x 4.x %.x:; sleep 10

[bug #63236] Fix getloadavg related error message.

: None ___ Follow-up Comments: --- Date: Wed 19 Oct 2022 01:32:41 AM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #63157] Unlink temporary files.

Follow-up Comment #22, bug #63157 (project make): Frank, can you please tell us how to reproduce? ___ Reply to this item at: ___ Message sent via

Re: features/temp_stdin FAILED (was: GNU make 4.3.91 release candidate available)

On Wed, Oct 19, 2022 at 2:33 AM Frank Heckenbach wrote: > features/temp_stdin . FAILED (6/7 passed) > [...] > % cat tests/work/features/temp_stdin.diff.5 > *** work/features/temp_stdin.base.5 Wed Oct 19 06:05:22 2022 > --- work/features/temp_stdin.log.5

[bug #63248] Ignore sigpipe.

Follow-up Comment #1, bug #63248 (project make): A user reported that make leaves temporary files behind when killed by sigpipe. $ ls tmp/ $ echo 'all:; sleep 2' | ~/src/gmake/make/l64/make -f- -j2 -O |: $ ls tmp GmIDqB2Q GmyW1CcO $ rm tmp/* $ # this make ignores sigpipe $ echo 'all:;

[bug #63248] Ignore sigpipe.

: None ___ Follow-up Comments: --- Date: Thu 20 Oct 2022 09:47:11 PM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savannah.gnu

[bug #63241] implement "exit" in makefile parsing

Follow-up Comment #1, bug #63241 (project make): i'd prefer to keep make language free of imperative constructs. Once you give them "if", they'll want "for" and "break" and "exit", etc. In my experience, it is better to avoid code like ifneq ($(filter %clean clobber,$(MAKECMDGOALS)),).

[bug #63248] Ignore sigpipe.

Additional Item Attachment, bug #63248 (project make): File name: sv63248.diff Size:1 KB ___ Reply to this item at:

[bug #63157] Unlink temporary files.

Follow-up Comment #25, bug #63157 (project make): This may not always reproduce, because there is a race between make writing its output to the pipe and the reader exiting. Sigpipe is sent when the reader exits before make is able to write its output. However, if you change it like this echo

Re: features/temp_stdin FAILED (was: GNU make 4.3.91 release candidate available)

On Wed, Oct 19, 2022 at 4:25 PM Frank Heckenbach wrote: > Indeed, adding a sleep after kill seems to ensure the message is > always written to the log file. Thanks, Frank. The same fix is also needed in output-sync. I opened https://savannah.gnu.org/bugs/index.php?63243 and attached a patch.

[bug #63243] Fix a race between sigterm and make writing its error message.

Additional Item Attachment, bug #63243 (project make): File name: sv63243.diff Size:2 KB ___ Reply to this item at:

[bug #63243] Fix a race between sigterm and make writing its error message.

: None Triage Status: None ___ Follow-up Comments: --- Date: Thu 20 Oct 2022 12:35:26 AM UTC By: Dmitry Goncharov . ___

[bug #63243] Fix a race between sigterm and make writing its error message.

Follow-up Comment #1, bug #63243 (project make): Tests in temp_stdin and output-sync send sigterm to kill make. There is a race here between sigterm and make writing to the log file. This races causes the tests to fail occasionally. The original bug report and a patch provided by Frank Heckenbach

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

Follow-up Comment #7, bug #63185 (project make): i guess, it is possible that sys/loadavg.h exists, but still doesn't declare getloadavg. It is also possible that configure sets HAVE_DECL_GETLOADAVG to 0 and also defines HAVE_SYS_LOADAVG_H and in this case there is a declaraion in sys/loadavg.h

[bug #63260] Avoid infinite recursion.

Follow-up Comment #5, bug #63260 (project make): Thanks, Paul. This indeed fixes the infinite recursion on reiserfs. ___ Reply to this item at: ___

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

Follow-up Comment #5, bug #63185 (project make): i guess this fell through the cracks. Paul, can you please have a look at the attached patch? One part of the patch you already applied, but there is the second part, which is still needed.

[bug #62174] fix test functions/shell on aix.

Follow-up Comment #3, bug #62174 (project make): i guess this fell through the cracks. Paul, can you please have a look at sv62174_fix2.diff? ___ Reply to this item at:

[bug #63287] Only use open with O_TMPFILE when supported.

Additional Item Attachment, bug #63287 (project make): File name: sv63287.diff Size:1 KB ___ Reply to this item at:

[bug #63287] Only use open with O_TMPFILE when supported.

Follow-up Comment #2, bug #63287 (project make): This failure gets especially annoying when make is building multiple targets, because make keeps bumping into it. $ cat makefile all: 1.x 2.x 3.x 4.x 5.x; $(info $@) %.x:; $(info $@) $ $ $ ~/src/gmake/make/m64/make -Orecurse --debug=b GNU

[bug #63287] Only use open with O_TMPFILE when supported.

: None ___ Follow-up Comments: --- Date: Sat 29 Oct 2022 12:40:40 AM UTC By: Dmitry Goncharov . ___ Reply to thi

[bug #63287] Only use open with O_TMPFILE when supported.

Follow-up Comment #1, bug #63287 (project make): This patch adds a configure check to detect whether O_TMPFILE is supported by the filesystem/kernel. The goal is to avoid doomed syscalls and related failure logging. Users tend to freak out on failure logging.

Re: GNU make 4.3.92 on Solaris 11

On Tue, Oct 25, 2022 at 10:26 AM Bruno Haible wrote: > With GNU make 4.3.92, the results are much better: > - On Solaris 11.4 and Solaris 11 OpenIndiana, all tests pass. > - On Solaris 11 OmniOS, there are only 3 test failures. Attached. These are the same failures that you reported on

[bug #63260] Avoid infinite recursion.

Follow-up Comment #1, bug #63260 (project make): The current make enters infinite recursion on a filesystem that does not support O_TMPFILE. $ cat makefile all:; $(info hello, world) $ # current make from master $ ~/src/gmake/make/m64/make -Orecurse Segmentation fault (core dumped)

[bug #63260] Avoid infinite recursion.

Additional Item Attachment, bug #63260 (project make): File name: sv63260.fixSize:2 KB ___ Reply to this item at:

[bug #63260] Avoid infinite recursion.

Follow-up Comment #2, bug #63260 (project make): I am not adding a test. Existing tests in features/output-sync fail. ___ Reply to this item at: ___

[bug #63260] Avoid infinite recursion.

Follow-up Comment #3, bug #63260 (project make): The same effect can be seen on a filesystem which supports O_TMPFILE, if TMPDIR is set to a non existing directory. ___ Reply to this item at:

[bug #63260] Avoid infinite recursion.

: None ___ Follow-up Comments: --- Date: Sun 23 Oct 2022 03:10:12 PM UTC By: Dmitry Goncharov . ___ Reply to this item at:

Re: GNU make 4.3.91 on CentOS 8 Stream

On Tue, Oct 18, 2022 at 7:55 PM Bruno Haible wrote: > On CentOS 8 Stream / x86_64 (a glibc 2.28 system), the compilation works fine, > but the test suite has failures in the 'output-sync' category: > - 3 failures in a build with gcc, > - 4 failures in a build with clang-15.0.2. I saw a similar

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #10, bug #63070 (project make): In glibc-2.17 posix_spawn returns 0 whether POSIX_SPAWN_USEVFORK is set or not. When POSIX_SPAWN_USEVFORK is not set posix_spawn returns 0 and errno is 0. When POSIX_SPAWN_USEVFORK is set posix_spawn returns 0 and errno is ENOEXEC. However, today

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #11, bug #63070 (project make): Patch 3 tested on glibc-2.17, glibc-2.32 and sun os. ___ Reply to this item at: ___ Message sent via

[bug #63070] posix_spawn fails to run a child process.

Additional Item Attachment, bug #63070 (project make): File name: sv63070_fix3.diff Size:1 KB ___ Reply to this item at:

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #13, bug #63070 (project make): There is nothing to be sorry about, Martin. Thank you for your work, keep contributing. ___ Reply to this item at:

[bug #63044] Make fails to update .LOADED when the setup routine returns -1.

Additional Item Attachment, bug #63044 (project make): File name: sv63044_fix.diff Size:0 KB File name: sv63044_test.diff Size:1 KB

[bug #63045] Make crashes when makefile keeps the loaded shared object intact.

Additional Item Attachment, bug #63045 (project make): File name: sv63045_fix.diff Size:11 KB File name: sv63045_test.diff Size:4 KB

[bug #63044] Make fails to update .LOADED when the setup routine returns -1.

: None Triage Status: None ___ Follow-up Comments: --- Date: Sun 11 Sep 2022 01:46:28 AM UTC By: Dmitry Goncharov . ___

[bug #63044] Make fails to update .LOADED when the setup routine returns -1.

Follow-up Comment #1, bug #63044 (project make): Make fails to add a loaded shared object to .LOADED when the shared object setup routine returns -1. $ ls makefile timer2.c $ cat timer2.c int plugin_is_GPL_compatible; int timer2_gmk_setup (void) { return -1; } $ gcc -o timer2.so

[bug #63045] Make crashes when makefile keeps the loaded shared object intact.

: None Triage Status: None ___ Follow-up Comments: --- Date: Sun 11 Sep 2022 03:13:13 AM UTC By: Dmitry Goncharov . ___

[bug #63045] Make crashes when makefile keeps the loaded shared object intact.

Follow-up Comment #1, bug #63045 (project make): Make crashes when makefile keeps the loaded shared object intact. In this makefile make loads shared object hello.so, then unloads it in order to rebuild. The rule provided by the makefile keeps the shared object intact. Make does not re-execute

[bug #63071] Race condition in .WAIT tests.

Follow-up Comment #1, bug #63071 (project make): Test 11 of targets/WAIT fails due to a race. $ cat tests/work/targets/WAIT.diff.11 *** work/targets/WAIT.base.11 Wed Sep 14 18:37:08 2022 --- work/targets/WAIT.log.11Wed Sep 14 18:37:08 2022 *** *** 1,5 - start-pre1

[bug #63071] Race condition in .WAIT tests.

: None ___ Follow-up Comments: --- Date: Sat 17 Sep 2022 01:31:48 AM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savanna

[bug #63070] posix_spawn fails to run a child process.

Additional Item Attachment, bug #63070 (project make): File name: sv63070_fix.diff Size:1 KB ___ Reply to this item at:

[bug #63070] posix_spawn fails to run a child process.

: None ___ Follow-up Comments: --- Date: Sat 17 Sep 2022 01:23:19 AM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #1, bug #63070 (project make): posix_spawn fails to run a child process. Some versions of glibc (i observed this with glibc-2.17) fail to spawn a shell program missing a shbang and return 0 from posix_spawn. $ ls hello.sh makefile $ cat hello.sh printf "hello, world\n" $

[bug #63071] Race condition in .WAIT tests.

Additional Item Attachment, bug #63071 (project make): File name: sv63071_fix.diff Size:1 KB ___ Reply to this item at:

[bug #63070] posix_spawn fails to run a child process.

Additional Item Attachment, bug #63070 (project make): File name: sv63070_fix2.diff Size:1 KB ___ Reply to this item at:

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #5, bug #63070 (project make): posix_spawn calls either vfork of spawn. On glibc-2.17 i observed that when posix_spawn calls vfork the return code is zero, but errno is set to ENOEXEC. When posix_spawn calls spawn, both return code and errno are zero. This man page

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #7, bug #63070 (project make): Let me describe differently. posix_spawn calls either vfork or clone, depending on arguments being passed. See the man page referenced above. I observed that when posix_spawn calls vfork, that's is when POSIX_SPAWN_USEVFORK is set in flags, errno

[bug #63070] posix_spawn fails to run a child process.

Follow-up Comment #8, bug #63070 (project make): However, maybe we should also define _GNU_SOURCE in the configure check before including #include . Something like index ec8b4c13..38418142 100644 --- a/configure.ac +++ b/configure.ac @@ -369,6 +369,7 @@ AS_IF([test "$make_cv_posix_spawn" =

Re: 4.3.90 release candidate segfaults on linux and solaris

On Sun, Sep 25, 2022 at 2:09 AM Martin Dorey wrote: > And vfork is where that happens. If I’ve followed the thicket of #ifdef > correctly and understood the vfork man page, then this is illegal when using > vfork: > > https://github.com/mirror/make/blob/master/src/job.c#L2556 Thanks, Martin.

Re: Make 4.3.90 breaks makefile of dtc

On Thu, Sep 22, 2022 at 4:39 AM Andreas Schwab wrote: ... > Interestingly, this eventually runs out of file > descriptors, because, due to -O, make keeps opening new pipes for > synchronizing the output without closing any. Without -O, this would > probably go on forever. Make used to

Re: Make 4.3.90 breaks makefile of dtc

On Thu, Sep 22, 2022 at 4:39 AM Andreas Schwab wrote: > There is some misbehaviour that creates an infinite loop trying to run > the bison rule. Interestingly, this eventually runs out of file > descriptors The latest make from master (same as 4.3.90) builds dtc-1.6.1 successfully for me with

[bug #63098] make-4.3.90 regression of unexpected dependencies in pattern rules with multiple targets

Follow-up Comment #1, bug #63098 (project make): This is not a regression. This is the intended behavior. Make runs the rule to build foo.c. See fabb03eac412b5ea19f1a97be31dc8c6fa7fc047 ___ Reply to this item at:

[bug #63100] Crash in a loadable plugin

: None ___ Follow-up Comments: --- Date: Sat 24 Sep 2022 08:30:58 PM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #63100] Crash in a loadable plugin

Follow-up Comment #1, bug #63100 (project make): When make unloads and then loads a shared object make supplies an uninitialized floc to the plugin setup routine. $ cat makefile load hello.so all:; : hello.so: force; : force:; .PHONY: force $ cat hello.c #include #include int

[bug #63100] Crash in a loadable plugin

Additional Item Attachment, bug #63100 (project make): File name: sv63100_fix.diff Size:0 KB File name: sv63100_test.diff Size:1 KB

[bug #63157] Unlink temporary files.

Additional Item Attachment, bug #63157 (project make): File name: sv63157_fix.diff Size:4 KB File name: sv63157_test.diff Size:2 KB

[bug #63157] Unlink temporary files.

Follow-up Comment #2, bug #63157 (project make): Tested this patch on linux, sun and aix. All 64 bit. This patch adds jobserver_unlink stub on windows. As far as i can visually validate, this stub should compile fine. However, have not tested this on windows.

Re: .SECONDARY unexpectedly affects rule invocation

On Tue, Oct 4, 2022 at 10:08 PM Martin Dorey wrote: > Isn't this slightly simplified example sufficient to demonstrate the same > behavior... A.4 is a preqreq to T.1 and also a prereq to A.4.ind. A.4.ind is present and that's why make skips building secondary A.4 and keeps A.4.ind intact,

[bug #63157] Unlink temporary files.

Follow-up Comment #3, bug #63157 (project make): Also, tested presence of PPID variable in ksh, bash, ash, zsh, sh. The only shell that i encountered that lacks PPID is tcsh (likely csh as well). The test uses the default shell. This means that test will likely fail on a system where /bin/sh is

[bug #63157] Unlink temporary files.

: None ___ Follow-up Comments: --- Date: Wed 05 Oct 2022 02:24:38 AM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savannah.gnu

[bug #63156] Preserve TMPDIR in test env.

: None ___ Follow-up Comments: --- Date: Wed 05 Oct 2022 01:57:44 AM UTC By: Dmitry Goncharov . ___ Reply to this item at: <https://savanna

[bug #63156] Preserve TMPDIR in test env.

Follow-up Comment #1, bug #63156 (project make): Tests which are supposed to test that make removes temporary files succeed whether make removed the file or not. This happens because, test_driver.pl sets TMPDIR in makeENV after setting env for the test. Thus the test env uses the default TMPDIR

[bug #63157] Unlink temporary files.

Follow-up Comment #1, bug #63157 (project make): Make fails to unlink temporary files upon arrival of a fatal signal. Specifically, the jobserver fifo, output sync lock and the stdin temp file. ___ Reply to this item at:

Re: .SECONDARY unexpectedly affects rule invocation

use make for running pipelines and add .SECONDARY > routinely because I don't want anything to be deleted as temporary file > > > Secondary without prerequisites is a bad idea. Regards, Dmitry > -Mikhail > On 10/5/22 09:58, Dmitry Goncharov wrote: > > On Tue, Oct 4, 20

[bug #63157] Unlink temporary files.

Follow-up Comment #13, bug #63157 (project make): Thank you, Eli. ___ Reply to this item at: ___ Message sent via Savannah https://savannah.gnu.org/

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

: None Triage Status: None ___ Follow-up Comments: --- Date: Sat 08 Oct 2022 08:26:14 PM UTC By: Dmitry Goncharov . ___

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

Follow-up Comment #1, bug #63185 (project make): The latest configure from 4.3.90 fails to detect getloadavg declaration on sun and aix. ../src/job.c: In function ▒load_too_high▒: ../src/job.c:2103:7: warning: implicit declaration of function ▒getloadavg▒ [-Wimplicit-function-declaration]

[bug #63157] Unlink temporary files.

Follow-up Comment #17, bug #63157 (project make): i think, it is fine (maybe even good) if the changes in comment 11 are abandoned. The whole critical section only lasts while make is reading and parsing the temp stdin file. The duration of this critical section is likely to be a fraction of

[bug #63219] Introduce a close function for loadable plugins.

Status: None ___ Follow-up Comments: --- Date: Sun 16 Oct 2022 12:17:42 AM UTC By: Dmitry Goncharov . ___ Reply to thi

[bug #63219] Introduce a close function for loadable plugins.

Additional Item Attachment, bug #63219 (project make): File name: sv63219.diff Size:6 KB File name: sv63219_test.diff Size:4 KB

[bug #63219] Introduce a close function for loadable plugins.

Follow-up Comment #2, bug #63219 (project make): This is the example from the manual extended with a close function #include #include #include #include #include #include int plugin_is_GPL_compatible; struct file { struct file *next; char *name; }; static struct file *files =

[bug #63219] Introduce a close function for loadable plugins.

Follow-up Comment #1, bug #63219 (project make): Make allows a loadable plugin to implement a setup function. This patch adds the ability for a loadable plugin to optionally specify a close function. Make calls this close function before unloading the plugin. This close function can be used for

[bug #63111] Regression. make runs out of file descriptors.

Follow-up Comment #4, bug #63111 (project make): [comment #3 comment #3:] > There are two parts to this: one is not freeing / cleaning temp files on re-exec. Andreas posted a patch which I will check, thanks Andreas! The coreutils failure is the leak of fd. There is no infinite recursion. i can

[bug #63157] Unlink temporary files.

Follow-up Comment #11, bug #63157 (project make): > If temp_stdin is fclosed, then there's no need to call close on its fileno. Right. We have to take care of the critical section between fopen and fclose. The reasoning is the following. 1. The patch works on unices. 2. On windows the patch

[bug #63157] Unlink temporary files.

Follow-up Comment #5, bug #63157 (project make): > This should be tested on MS-Windows. A file can only be deleted on MS-Windows if it isn't open by any program, and the patch (AFAICT) doesn't make sure the files are closed before unlinking them. I'm especially worried about the

[bug #63157] Unlink temporary files.

Follow-up Comment #8, bug #63157 (project make): we *can* call close before unlink ___ Reply to this item at: ___ Message sent via Savannah

[bug #63157] Unlink temporary files.

Follow-up Comment #9, bug #63157 (project make): In the case of temp_stdin eval_makefile fcloses this file. We'll need to store temp_stdin_fileno in a file scope variable (next to stdin_offset) and pass it to close in temp_stdin_unlink. We won't be able to use fclose, which is okay, since make is

[bug #63157] Unlink temporary files.

Follow-up Comment #7, bug #63157 (project make): close is async signal safe and we call close before unlink. Should make also calls close before unlink in all other places where make unlinks this (or any other) file? ___ Reply to this

Re: Some "fun" last weekend

On Thu, Jul 21, 2022 at 10:23 AM Paul Smith wrote: > Instead, any sub-process can look at MAKEFLAGS, see the value of jobserver-auth, find the name of the pipe, open it, and start to use it. If the sub-process doesn't know anything about MAKEFLAGS, it will never know that the jobserver is

Re: Macro arguments

On Tue, Aug 9, 2022 at 11:56 PM Paul Smith wrote: > ...modifying the way all function arguments > are parsed is something that needs to be carefully considered, if > nothing else from a backward-compatibility standpoint. agree. i added an example to the manual of how to use variable to hide

[bug #62881] parentheses confuse make parser

: None ___ Follow-up Comments: --- Date: Tue 09 Aug 2022 07:02:50 PM UTC By: Dmitry Goncharov . ___ Reply to this item at:

[bug #62881] parentheses confuse make parser

Follow-up Comment #1, bug #62881 (project make): A user reported the following here https://lists.gnu.org/archive/html/bug-make/2022-08/msg00017.html in GNU-make macros. Like in: msg = @echo "$(1)" ptest_1: $(call msg, foo (arg1, arg2, arg3)) ... A

[bug #62881] parentheses confuse make parser

Additional Item Attachment, bug #62881 (project make): File name: sv62881_test.diff Size:1 KB File name: sv62881_fix.diff Size:0 KB

Re: Macro arguments

On Tue, Aug 9, 2022 at 10:48 AM Gisle Vanem wrote: Thanks for your report. See here https://savannah.gnu.org/bugs/index.php?62881 regards, Dmitry

[bug #62908] Regression. Double free if jobserver is enabled, but cannot open fifo.

Additional Item Attachment, bug #62908 (project make): File name: sv62908_fix.diff Size:0 KB File name: sv62908_test.diff Size:1 KB

[bug #62908] Regression. Double free if jobserver is enabled, but cannot open fifo.

: None Triage Status: None ___ Follow-up Comments: --- Date: Wed 17 Aug 2022 11:45:30 PM UTC By: Dmitry Goncharov Failure to open a fifo causes make to double free fif

[bug #63609] Fix a buffer overrun in warn_undefined.

Additional Item Attachment, bug #63609 (project make): File name: sv63609_fix.diff Size:0 KB File name: sv63609_test.diff Size:0 KB

[bug #63609] Fix a buffer overrun in warn_undefined.

Follow-up Comment #1, bug #63609 (project make): The following code in warn_undefined causes a buffer overrun if (memcmp (*cp, name, len) == 0 && (*cp)[len] == '\0') when len exceeds strlen (*cp). This happens when make needs to expand a variable whos name is longer than *cp,

<    1   2   3   4   5   6   7   >