Re: GNU make release candidate 3.99.90 available

2013-05-20 Thread Paul Smith
On Fri, 2013-05-17 at 22:35 +0300, Eli Zaretskii wrote: > When a dynamic extension is being remade, it is unloaded by calling > unload_file. The latter looks up its argument in a linked list of > loaded objects. Now, unload_file is called with file->name as its > argument; is it 100% sure that th

Re: GNU make release candidate 3.99.90 available

2013-05-20 Thread Paul Smith
On Mon, 2013-05-20 at 11:09 -0400, Boris Kolpackov wrote: > > This is because in the current algorithm, every single time we do an > > implicit rule search and compute possible target and dependency names > > they are all added to the string cache, even if they are deemed to be > > useless and not

Re: [bug #26596] MAKEFLAGS documentation tweak

2013-05-22 Thread Paul Smith
On Wed, 2013-05-22 at 17:42 +0200, Stefano Lattarini wrote: > Hi Paul. > > On 05/22/2013 05:17 PM, Paul D. Smith wrote: > > Follow-up Comment #1, bug #26596 (project make): > > > > Hm. I'm not sure why the immediate expansion has limited content. Is there > > any purpose to this? Wouldn't it j

Re: Documentation for the eval function

2013-05-22 Thread Paul Smith
On Wed, 2013-05-22 at 20:13 +0200, Sascha Ziemann wrote: > Hi, > > I think the example in the documentation for the eval function is > broken. I copied the example to a file and tried it with "make clean". > The action for the clean target is "rm -f $(ALL_OBJS) $(PROGRAMS)". > The PROGRAMS variabl

Re: Bug-make post from cev...@gmail.com requires approval

2013-05-23 Thread Paul Smith
On Thu, 2013-05-23 at 04:10 -0400, bug-make-ow...@gnu.org wrote: > define PROGRAM_template = This syntax is not available in GNU make 3.81. It was introduced in GNU make 3.82. Thus the "PROGRAM_template" variable is not defined, and expands to the empty string, and thus your eval does nothing.

Re: [bug #26596] MAKEFLAGS documentation tweak

2013-05-23 Thread Paul Smith
On Wed, 2013-05-22 at 22:09 +0200, Stefano Lattarini wrote: > On 05/22/2013 06:56 PM, Paul Smith wrote: > > I've reworked the MFLAGS / MAKEFLAGS generation to be more regular and > > rigorous yesterday, for 4.0, and to preserve _some_ backward-compat; I > > had thought a

Re: Make run in parallel mode with output redirected to a regular file can randomly drop output lines

2013-05-26 Thread Paul Smith
On Sun, 2013-05-26 at 11:14 +0200, Stefano Lattarini wrote: > Actually no; maybe it is *possible* to play some tricks with the > inherited file descriptors in order to mitigate or fix the issue, > but I haven't given it any real thought. Well, we can use fcntl() to set O_APPEND on stdout/stderr.

Re: Make run in parallel mode with output redirected to a regular file can randomly drop output lines

2013-05-26 Thread Paul Smith
On Sun, 2013-05-26 at 22:05 +0200, Stefano Lattarini wrote: > On 05/26/2013 09:57 PM, Paul Smith wrote: > > > > [SNIP] > > > > Might be worthwhile checking the FreeBSD code for their make, to see if > > they do something like this. > > > Nope, Frank was

Re: GNU make release candidate 3.99.90 available

2013-05-26 Thread Paul Smith
On Mon, 2013-05-20 at 19:06 +0300, Eli Zaretskii wrote: > > I still don't want to add back the pointer to the struct. Memory usage > > by GNU make is becoming a sore spot, especially as larger and larger > > build systems start to move to non-recursive make. If necessary we'll > > need to make th

Re: Make run in parallel mode with output redirected to a regular file can randomly drop output lines

2013-05-27 Thread Paul Smith
On Mon, 2013-05-27 at 20:13 +0300, Eli Zaretskii wrote: > > and if so, does it guarantee non-conflicting writes? > > Not sure I understand what you are asking here. Can you elaborate? The original issue reported is that if you do something like this: make -j >make.out and your make environ

Re: A translation error

2013-06-06 Thread Paul Smith
On Thu, 2013-06-06 at 21:54 +0800, pisces wrote: > > I'm a Linuxer in China , those day , I find a translation error about > the "make" program in Chinese. > When I type the "make --help" in my KDE konsole (KDE4.10.3 with Fedora > 18) ,the help information : Since most upstream developers don't

Re: Help:Stop compile due to Segmentation Fault Error

2013-06-21 Thread Paul Smith
On Fri, 2013-06-21 at 23:09 +0900, 최철우 wrote: > Segmentation Fault error occurred while compile below part of > Makefile. > > we used the make 3.81 on ubentu 10.10. I'm pretty confident that this bug has been fixed. Please try a newer version of GNU make. __

Re: TRYING TO INSTALL REAP I GET THE FOLLOWING

2013-07-05 Thread Paul Smith
On Fri, 2013-07-05 at 13:05 +, M.C. Medina Gomez wrote: > /tmp/ccTpN0kH.o: In function `getkinship': > REAP_SOURCE.c:(.text+0x3206): undefined reference to `sqrt' > collect2: ld returned 1 exit status > make: *** [REAP] Error 1 > Could you tell me what is wrong This is not a bug in make; thi

Re: [PATCH] Fix issue with PowerPC, char is unsigned by default

2013-07-14 Thread Paul Smith
On Thu, 2013-07-11 at 15:16 +1000, Anton Blanchard wrote: > Just checking on this patch. Without it make on PowerPC is broken. I decided to go a different way, and rewrote update_status to be an enum rather than a char. This change is pushed to Git. _

Re: [bug #37703] job starts before dependency

2013-07-20 Thread Paul Smith
On Tue, 2013-07-09 at 10:43 -0400, Jay Lawrence wrote: > My bad, I see that patch now, please disregard... In your comment below you mentioned you'd tried the latest source but it still failed. I believe I fixed this bug with a commit in April. Can you reproduce the issue with the latest source

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Paul Smith
On Tue, 2013-07-30 at 18:39 +0300, Eli Zaretskii wrote: > In general, I feel it's wrong to do this: Cygwin is a Posix platform, > so it should be using the Posix code, to be as compatible with other > Posix platforms as possible. EMX is not a Posix platform, so using > its code will likely make th

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-31 Thread Paul Smith
On Wed, 2013-07-31 at 10:37 +0400, Pavel Fedin wrote: > Looks like, if you want DOS paths, and running under Cygwin, an > explicit conversion has to be performed on getcwd() result using > cygwin_conv_path(). However i did not test this further because i > follow official Cygwin way of doing thing

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Paul Smith
On Mon, 2013-08-05 at 10:56 -0400, Christopher Faylor wrote: > > Then maybe really add something like --enable-dos-paths which > defaults to > >no on Cygwin and Yes on MinGW ? > > ac_cv_dos_paths=no configure > > works just fine and does not require a command-line switch. If this is a common/nec

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-16 Thread Paul Smith
On Fri, 2013-08-16 at 20:59 +0400, Pavel Fedin wrote: > Friday, August 16, 2013, 19:19:58 you wrote: > > > Also, when I'm making changes to the exec() code I don't spend a lot of > > time worrying about spawn() so it is possible that it will be broken > > from time to time and, in fact, I think yo

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-16 Thread Paul Smith
On Fri, 2013-08-16 at 13:30 -0400, Christopher Faylor wrote: > On Fri, Aug 16, 2013 at 01:12:28PM -0400, Paul Smith wrote: > >On Fri, 2013-08-16 at 20:59 +0400, Pavel Fedin wrote: > >>Friday, August 16, 2013, 19:19:58 you wrote: > >> > >>>Also, when I'

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-16 Thread Paul Smith
On Fri, 2013-08-16 at 22:52 +0400, Pavel Fedin wrote: > > Exactly, hence the reason for my question. I'm not interested in adding > > this if, when it's enabled, things don't work correctly. > > > On the other hand I'm not sure it's not possible to get things working > > correctly. Or, perhaps i

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-04 Thread Paul Smith
On Wed, 2013-09-04 at 18:15 -0400, David Boyce wrote: > On Wed, Sep 4, 2013 at 4:42 PM, Paul D. Smith > wrote: > Follow-up Comment #1, bug #39943 (project make): > > IMO _any_ editor which automatically replaces TABs with spaces > should never be > consider

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Paul Smith
On Thu, 2013-09-05 at 11:43 +0100, Tim Murphy wrote: > The detection also appears to only work if the statement has a syntax > error in it. Correct. If make can understand what the line is (it's a valid makefile syntax), then why would it assume that the programmer may have meant something differ

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-12 Thread Paul Smith
On Wed, 2013-07-17 at 17:07 +0200, Frank Heckenbach wrote: > May I remind you of my mail of May 26: > http://lists.gnu.org/archive/html/bug-make/2013-05/msg00137.html > > Besides a little cleanup patch, I show in this mail that > "--trace=dir" is not completely sufficient as currently implemented

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-13 Thread Paul Smith
On Thu, 2013-09-12 at 04:19 -0400, Paul Smith wrote: > I think there may still be some change needed for directory tracking > for the -Orecurse mode. If we're collecting output for an entire > recursive make invocation we don't need enter/leave notifications > around eac

Re: Gmake 3.8.1 bug on AIX

2013-09-14 Thread Paul Smith
On Mon, 2013-09-09 at 17:37 -0500, kevin barnes wrote: > We do a build on Solaris and it finds the Makefile and descends down > into the source tree and builds everything. On AIX 6.1, it gets the > following error: > > gmake[1]: *** No targets specified and no makefile found. Stop. > > We u

GNU make 3.99.91 release candidate is available

2013-09-15 Thread Paul Smith
Hi all. The second release candidate, 3.99.91, for the next version of GNU make, is now available on alpha: ftp://alpha.gnu.org/gnu/make/make-3.99.91.tar.bz2 f560e25dc1b389f0467bfcc1070fa372 ftp://alpha.gnu.org/gnu/make/make-3.99.91.tar.gz 531fc31c44b50925f0266dde61f539a2 There are many bug

Re: Suffix rules with dependencies

2013-09-16 Thread Paul Smith
On Mon, 2013-09-16 at 08:48 +0300, Eli Zaretskii wrote: > In this thread: > >http://lists.gnutls.org/pipermail/gnutls-devel/2013-September/006453.html > > and specifically in this message and its followups: > > http://lists.gnutls.org/pipermail/gnutls-devel/2013-September/006460.html > >

Re: GNU make 3.99.91 release candidate is available

2013-09-16 Thread Paul Smith
On Mon, 2013-09-16 at 20:52 +0200, Dagobert Michelsen wrote: > > /opt/SUNWspro/bin/cc -D_REENTRANT -pthreads > -I/opt/csw/include/guile/2.0 -I/opt/csw/include -xO3 -m32 > -xarch=sparc -m32 -xarch=sparc -L/opt/csw/lib -o make ar.o arscan.o > commands.o default.o dir.o expand.o file.o function.o g

Re: GNU make 3.99.91 release candidate is available

2013-09-17 Thread Paul Smith
On Tue, 2013-09-17 at 10:23 +0200, Dagobert Michelsen wrote: > > Unfortunately I don't have a copy of Sun Studio and I don't have any > > SPARC hardware. I'll need someone with access to these to assist. > > That is no problem. There are already a number of GNU projects that use > our buildfarm t

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-18 Thread Paul Smith
Hi Frank, thanks for the thorough testing! This feature will be much better for all your efforts. *sigh* If it weren't for the enter/leave messaging, the output-sync feature would have been quite straightforward! :-/ :-). On Mon, 2013-09-16 at 12:18 +0200, Frank Heckenbach wrote: > 1. > > %

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-19 Thread Paul Smith
On Thu, 2013-09-19 at 14:47 +0200, Frank Heckenbach wrote: > > Hm. This is pretty contrived. I have a hard time imagining a real > > makefile wanting to do this for a good reason. However, it does > seem > > that the solution may be simple enough. > > I also doubt someone would do it intentiona

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-21 Thread Paul Smith
On Sat, 2013-09-21 at 07:28 +, Edward Welbourne wrote: > > I've never understood why someone would use $(shell ...) in a recipe... > > I mean, the recipe will be run in the shell!! > > I remember we once had a library where the command-line to the archiver > was too long (about a quarter megab

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-21 Thread Paul Smith
On Thu, 2013-09-19 at 14:47 +0200, Frank Heckenbach wrote: > Paul Smith wrote: > > > *sigh* If it weren't for the enter/leave messaging, the output-sync > > feature would have been quite straightforward! :-/ :-). > > I'm afraid so. But I think we're alm

Re: make check on darwin

2013-09-21 Thread Paul Smith
On Tue, 2013-09-17 at 23:46 +0200, Denis Excoffier wrote: > I have configured with --disable-load. I had to apply the patch below > (self explanatory i think) for 'make check' to return with no error. > > Moreover: > 1) when configured with --disable-job-server, the tests in > features/parallelism

Re: GNU make 3.99.91 release candidate is available

2013-09-22 Thread Paul Smith
I've done some testing and bug fixing using the Solaris build service, thanks very much Dago! On Mon, 2013-09-16 at 20:52 +0200, Dagobert Michelsen wrote: > I'll get an error compiling it on Solaris 10 Sparc with Sun Studio 12: > > /opt/SUNWspro/bin/cc -D_REENTRANT -pthreads > -I/opt/csw/include/

GNU make 3.99.92 release candidate is available

2013-09-22 Thread Paul Smith
Hi all. The third release candidate, 3.99.92, for the next version of GNU make is now available on alpha: ftp://alpha.gnu.org/gnu/make/make-3.99.92.tar.bz2 7ef9dabbfd8ad202ef05edb5836eb4b9 ftp://alpha.gnu.org/gnu/make/make-3.99.92.tar.gz dc238186a23407a3a0b3fe29db48efaf There are a number o

Re: GNU make 3.99.92 release candidate is available

2013-09-23 Thread Paul Smith
On Mon, 2013-09-23 at 11:02 +0300, Eli Zaretskii wrote: > There's also another problem: you added a test script dash-w, where we > already had a dash-W. On Windows, these two map to the same file, so > git overwrites the same file, and the file is always marked as > "modified". Please rename one

Re: GNU make 3.99.92 release candidate is available

2013-09-23 Thread Paul Smith
On Mon, 2013-09-23 at 19:56 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Cc: bug-make@gnu.org > > Date: Mon, 23 Sep 2013 11:48:40 -0400 > > > > On Mon, 2013-09-23 at 11:02 +0300, Eli Zaretskii wrote: > > > There's also another probl

Re: GNU make 3.99.92 release candidate is available

2013-09-23 Thread Paul Smith
On Mon, 2013-09-23 at 19:14 +0200, Denis Excoffier wrote: > In order to compile (with --disable-load) under cygwin i had to > remove two occurrences of "(scm_t_subr)" from guile.c (unknown > identifier, sorry). With --without-guile this is, expectedly, > not needed. Yes this is because of changes

Re: GNU make 3.99.91 release candidate is available

2013-09-23 Thread Paul Smith
On Mon, 2013-09-23 at 14:03 +0200, Dagobert Michelsen wrote: > I still have two fails with SunStudio without Guile and with GCC and > both with/without Guile: Blerg. Looks like the /bin/sh on the Solaris 10 system can't accept options separated by spaces: psmith@unstable10s [unstable10s]:~ > /

Re: GNU make 3.99.92 release candidate is available

2013-09-24 Thread Paul Smith
On Tue, 2013-09-24 at 18:49 +0200, Denis Excoffier wrote: > All my tests now pass. I suppose we are at it. Here is the emx-patch, > to apply on make-3.99.92 in order to have a working EMX platform (i > suppose). I can say that the spawn-patch applies (still very easily) > on top of this and the res

Re: GNU make 3.99.92 release candidate is available

2013-09-24 Thread Paul Smith
On Tue, 2013-09-24 at 21:25 +0400, Pavel Fedin wrote: > Ok, i will try to check it out. > Actually i'm also not familiar with such deep internals. I have just > reused an existing code, i did not actually change anything. > Additionally > this error simply wasn't the case in earlier make version

Re: The prompt message may be not accurate

2013-09-24 Thread Paul Smith
On Wed, 2013-09-25 at 09:29 +0800, baoshanqiang wrote: > But, in my directory, '/usr/src/linux-3.11.1/drivers/helloworld/' , > there does have Makefile file. Please refer to the following picture. > Would you tell me what the reason is? Windows (or MacOS) use filesystems which are case-insensitiv

Re: GNU make 3.99.92 release candidate is available

2013-09-25 Thread Paul Smith
On Wed, 2013-09-25 at 12:14 +0200, Boris Kolpackov wrote: > I just got a new box setup for development and was shocked to find > out that make 3.99.XX is about 50% slower than on my old box. I'm not sure I fully understood the situation. This comment makes it sound like same version of make (same

Re: GNU make 3.99.92 release candidate is available

2013-09-25 Thread Paul Smith
On Wed, 2013-09-25 at 13:51 +0200, Boris Kolpackov wrote: > Paul D. Smith writes: > > I'm not sure I fully understood the situation. > > > > This comment makes it sound like same version of make (same code) is 50% > > slower on the new system. Is that what you meant? > > Yes, the same make bina

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-09-29 Thread Paul Smith
As always thanks for your thorough testing Frank. On Tue, 2013-09-24 at 20:41 +0200, Frank Heckenbach wrote: > Paul Smith wrote: > > > On Thu, 2013-09-19 at 14:47 +0200, Frank Heckenbach wrote: > > > Paul Smith wrote: > > > > > > > I didn'

Re: make check on darwin

2013-09-30 Thread Paul Smith
On Sun, 2013-09-22 at 22:16 +0200, Denis Excoffier wrote: > On 2013-09-22 06:50, Paul Smith wrote: > > Just curious: did you build with --disable-load because something failed > > otherwise? Or just because you wanted to? > I didn't investigate the errors produced with -

GNU make 3.99.93 release candidate is available

2013-09-30 Thread Paul Smith
Hi all. The fourth release candidate, 3.99.93, for the next version of GNU make is now available on alpha: ftp://alpha.gnu.org/gnu/make/make-3.99.93.tar.bz2 81e1f8693c50bf485382c31f0e827d91 ftp://alpha.gnu.org/gnu/make/make-3.99.93.tar.gz fc854c46fb60d8ffb1066dc46026aa4c There are a number

Re: make check under Cygwin (3.99.93)

2013-10-01 Thread Paul Smith
On Tue, 2013-10-01 at 11:04 +0200, Denis Excoffier wrote: > Hello, > > Thank you for this new RC. > > I have tested make-3.99.93 under cygwin 32 bits with --disable-load > (and without the spawn-patch). > > Several items that i had reported in > http://lists.gnu.org/archive/html/bug-make/2013-09

Re: GNU make 3.99.93 release candidate is available

2013-10-01 Thread Paul Smith
On Tue, 2013-10-01 at 10:21 +0200, Stephan Beal wrote: > On Tue, Oct 1, 2013 at 7:06 AM, Paul Smith wrote: > Note, no changes to translatable strings were introduced in > this > release. > i'm not sure if this counts as a translatable string, but i&#x

Re: "load" on Windows

2013-10-05 Thread Paul Smith
On Sat, 2013-10-05 at 16:34 +0300, Eli Zaretskii wrote: > > EXPORT int mk_test_gmk_setup (const gmk_floc *flocp) > > { > > gmk_add_function ("hello_world", hello_world, 0, 255, 0); > ^^^ > Make functions cannot have the '_' character in their names, so it >

Re: make check under Cygwin

2013-10-05 Thread Paul Smith
On Wed, 2013-09-25 at 11:30 +0200, Denis Excoffier wrote: > Still experimenting 'make check' with Cygwin (without the spawn-patch, > with --disable-load): > > 1) In test_driver.pl, line 486 (look for "Test returned"), a comparison > of $code against the value -1 is performed. However, 3 lines abov

GNU Make 4.0 released

2013-10-08 Thread Paul Smith
GNU Make 4.0 has been released and is available now for download: http://ftp.gnu.org/gnu/make/make-4.0.tar.gz b5e558f981326d9ca1bfdb841640721a http://ftp.gnu.org/gnu/make/make-4.0.tar.bz2 571d470a7647b455e3af3f92d79f1c18 Or one of the mirrors listed in http://www.gnu.org/order/ftp.html Get red

Re: [bug #40225] Deterministic output ordering

2013-10-10 Thread Paul Smith
On Thu, 2013-10-10 at 07:29 +0200, Frank Heckenbach wrote: > Paul D. Smith wrote: > > > A non-parallel build is actually fully deterministic for a given makefile. > > Make (I believe this is specified by POSIX) will always try to build the > > first > > prerequisite first, then the second, etc.

Re: [bug #33034] "Makefile:23: *** mixed implicit and normal rules. Stop." for Linux kernel out of source builds

2013-10-20 Thread Paul Smith
On Sun, 2013-10-20 at 20:15 -0700, David Boyce wrote: > Paul. > > Thank you very much! This means I'll be able to make professional use > the many features and bugfixes which have arrived post-3.81 at some > point. Given the flurry of other fit-and-finish fixes lately, would it > be safe to assume

Re: make-4.0 allows empty ARFLAGS to be passed to ar

2013-10-20 Thread Paul Smith
On Mon, 2013-10-21 at 04:05 +0100, Ken Moffat wrote: > With GNU Make 4.0 on x86_64-unknown-linux-gnu I am unable to build > qemu 1.6.{0,1} because it fails with > AR libfdt/libfdt.a > ar: two different operation options specified > Makefile:234: recipe for target 'libfdt/libfdt.a' failed

Re: make-4.0 allows empty ARFLAGS to be passed to ar

2013-10-21 Thread Paul Smith
On Mon, 2013-10-21 at 17:36 +0100, Ken Moffat wrote: > I haven't even figured out where quiet-command is located. I'm > only an integration monkey, checking that everything in our "distro" > (BLFS) will build with make-4.0. Will take a look. Please see my second email, from earlier today. Base

Re: make-4.0 allows empty ARFLAGS to be passed to ar

2013-10-21 Thread Paul Smith
On Mon, 2013-10-21 at 18:03 +0100, Ken Moffat wrote: > 2. Unfortunately, rules.mak *is* adding -rR to the MAKEFLAGS - > > # Don't use implicit rules or variables > # we have explicit rules for everything > MAKEFLAGS += -rR > I'll attach rules.mak. Is this a qemu bug which just happened to > wor

Re: make-4.0 allows empty ARFLAGS to be passed to ar

2013-10-21 Thread Paul Smith
On Mon, 2013-10-21 at 16:02 +0100, Ken Moffat wrote: > > # command line > ARFLAGS = So this tells us that the empty value is being set from the command line. > I then ran it in the directory where the build fails (dtc/) - > > # makefile (from 'Makefile', line 51) > ARFLAGS = rc This is not i

Re: make-4.0 allows empty ARFLAGS to be passed to ar

2013-10-21 Thread Paul Smith
On Mon, 2013-10-21 at 18:48 +0100, Ken Moffat wrote: > Thanks. Is it OK if I quote this whole reply to the qemu devs ? Of course. This mailing list is publicly archived; quote away. Or point them to the thread: http://lists.gnu.org/archive/html/bug-make/2013-10/msg00151.html

Re: Document typo

2013-10-28 Thread Paul Smith
On Mon, 2013-10-28 at 11:36 -0500, Michael Procca wrote: > The last line of "Section 6.5 Setting Variables" of > http://www.gnu.org/software/make/manual/make.html#Recipes is: > > var := $(shell find . -name "*.c") > > and believe should be: > > var := $(shell find . -name '*.c') The d

Re: .ONESHELL enhancements

2013-11-14 Thread Paul Smith
On Thu, 2013-11-14 at 11:05 -0700, Eric Blake wrote: > Hello GNU make hackers, Hi Eric. > In today's Austin Group meeting (the people working on POSIX), we > discussed an interesting proposal: > > http://austingroupbugs.net/view.php?id=770 I'm subscribed to the mailing list and follow the vario

Re: [bug #40226] Weird failure on Windows with OUTPUT_SYNC_TARGET

2013-11-24 Thread Paul Smith
On Sun, 2013-11-24 at 12:35 +0200, Eddy Petrișor wrote: > Since you just worked on this, and the new type overwrites in case of > repetition, does it make sense to overwrite instead of error? I think > that for profiling this type of behaviour would be better. > Sorry, but I didn't understand that

Re: VMS port

2013-11-25 Thread Paul Smith
On Mon, 2013-11-25 at 13:48 +0400, Pavel Fedin wrote: > I am restarting work on spawn-patch for Cygwin. Actually, i have the very > first version working, but want to try to do some face-lift and get rid of > some #ifdef's. > My first question is: is VMS port maintained, or dead long ago ? The V

Re: mingw-w64 build breaks and warnings

2013-11-27 Thread Paul Smith
On Mon, 2013-11-25 at 19:39 -0800, Stephan T. Lavavej wrote: > #1: >OSN (fatal, NILF, >^ Fixed, thanks. > #2: > w32err.c: In function 'map_windows32_error_to_string': > w32err.c:70:3: warning: passing argument 2 of 'fatal' makes integer from > pointer without a cast [enabl

Re: mingw-w64 build breaks and warnings

2013-11-27 Thread Paul Smith
On Tue, 2013-11-26 at 12:21 +, Ray Donnelly wrote: > Instead of adding the MS-specific "%Ix", could you not add (in the > batch file) the define of __MINGW_USE_ANSI_STDIO=1, otherwise I > suspect you'd be breaking people who prefer the stdio a bit more ansi > (mingw-builds for example). I went

Re: [bug #40639] GNU Make with profiling information

2013-12-15 Thread Paul Smith
On Sun, 2013-12-15 at 13:38 +, Tim Murphy wrote: > I suppose I'm skirting around saying that I think gnu make needs an > output format in the same way that valgrind has "--xml=yes". I'm not > an XML fan really - JSON might be an alternative. > It isn't your problem to provide such a mechanism

Re: [bug #40639] GNU Make with profiling information

2014-01-11 Thread Paul Smith
Sorry, I've been mostly away from my systems recently. On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: > Thanks for clarifying this. Could you please confirm if the general > direction of the the is OK in the latest patch I sent? I will take a look. > What it is in scope and what I wou

Re: [bug #40639] GNU Make with profiling information

2014-01-11 Thread Paul Smith
On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: > Could you please confirm if the general direction of the the is OK in > the latest patch I sent? Conceptually it seems OK. I'm still not jazzed about having any more than one output format, and I'd prefer that format to be in a more-or-les

Re: win32 compilation of make 4.0 source code‏

2014-01-13 Thread Paul Smith
On Mon, 2014-01-13 at 18:21 +0200, Eli Zaretskii wrote: > > From: "Mark Brown" > > Date: Mon, 13 Jan 2014 06:04:24 -0800 > > > > I was able to compile the make 4.0 source code downloaded from the > > gnu make site using Visual C++ 2005 under Windows 7 64 (generated 0 errors, > > 259 warnings) >

Re: win32 compilation of make 4.0 source code‏

2014-01-13 Thread Paul Smith
On Mon, 2014-01-13 at 19:37 +0200, Eli Zaretskii wrote: > > On Windows, GNU make can be compiled in a quite a number of different > > ways. It would be helpful if you gave us an idea of which method you > > used. > > He said that: he used Microsoft Visual C++ version 2005. But I meant, how? Thr

Re: make doesn't complain if target cannot be built

2014-01-13 Thread Paul Smith
On Mon, 2014-01-13 at 22:23 +0100, Christian Eggers wrote: > In Makefile 2 my intention was to state that foo.o depends on some > generated header which must be generated first (might be in another > rule). But I didn't want to change the be behaviour if foo.o cannot be > built because e.g. there's

Re: output from $(error) lost with output sync

2014-01-13 Thread Paul Smith
I fixed this one locally a couple of days ago; sorry for not pushing. I'll do that shortly. I don't think this change is sufficient because if output_sync != &make_sync then make_sync is never dumped with the change below. On Tue, 2014-01-14 at 06:21 +0100, Frank Heckenbach wrote: > Oliver Kiddl

Re: Missing po files in GIT

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 11:00 +0400, Pavel Fedin wrote: > Hello! > > I am trying to rebuild GIT version of Make, however .po files are missing > in the repository. Is this intentional ? I have copied them over from my > 4.0-2 archive. But where are they originally stored ? The PO files are dynami

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 11:58 +0200, Eddy Petrișor wrote: > > I understand the interest in the amount of time a given job takes to > > run, but I guess I don't understand the need for a "start time > offset" > > at all. Isn't it sufficient to record the start time of a job, then > > when it's comple

Re: make doesn't complain if target cannot be built

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 06:56 +0100, Christian Eggers wrote: > Am Montag, 13. Januar 2014, 17:20:43 schrieb Paul Smith: > > On Mon, 2014-01-13 at 22:23 +0100, Christian Eggers wrote: > > > In Makefile 2 my intention was to state that foo.o depends on some > > > gen

Re: win32 compilation of make 4.0 source code‏

2014-01-24 Thread Paul Smith
On Fri, 2014-01-24 at 11:03 -0800, Mark Brown wrote: > I had a make.exe 3.80 and it had problems with "else ifeq" > constructs, so that forced me to seek a more recent version for win32. Yes that version didn't support it. You can look at the latest NEWS file for info on what appeared when: htt

Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-01-27 Thread Paul Smith
On Sun, 2014-01-26 at 16:35 +, Ray Donnelly wrote: > I missed a few assert cases in the previous patch. Please find a fixed > version attached. Thanks Ray; I'm utterly swamped for the last week or so with "real life" but I should have a bit more free time later this week; I'll check out your f

Re: win32 compilation of make 4.0 source code‏

2014-01-27 Thread Paul Smith
On Sun, 2014-01-26 at 16:22 -0800, Mark Brown wrote: > That example method is a device to perform this .FEATURES test > without inserting it into an existing Makefile. > The syntax errors I was seeing were occurring when attempting to insert this > test into an existing Makefile, full of Targets a

Re: win32 compilation of make 4.0 source code‏

2014-01-27 Thread Paul Smith
On Mon, 2014-01-27 at 09:59 -0800, Mark Brown wrote: > First, let me request that you include the question posed to you, > in your Reply responses in this email sequence. This list, like almost all free software (and most technical public) mailing lists, prefers trimmed interleaved formats, and di

Re: $(file) function bug or not?

2014-01-28 Thread Paul Smith
On Tue, 2014-01-28 at 15:50 +0100, Gisle Vanem wrote: > I'm trying to understand if my use of the $(file..) function is correct or > not. Based on tests/scripts/function/file, I cooked up this little file.mak: It's not correct. Or rather, the use of $(file ...) is correct, but not the surroundin

Re: $(file) function bug or not?

2014-01-28 Thread Paul Smith
On Tue, 2014-01-28 at 09:52 -0800, David Boyce wrote: > I think the headline here is that $(file) is analogous to $(shell) in > that it's intended specifically for use _outside_ of recipes. If you > find yourself using either one in a recipe it's probably a sign you're > on the wrong track. I'm no

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Paul Smith
On Thu, 2014-01-30 at 19:29 +0200, Eli Zaretskii wrote: > I will review the patch some more in a day or two. (And I hope Paul > will as well.) Yes, definitely, but it won't be until the weekend I expect. Life is intruding on hacking this month. ___ B

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-01-31 Thread Paul Smith
On Fri, 2014-01-31 at 16:55 +0200, Eli Zaretskii wrote: > > An option as command line argument, or as a special target as the > > original patch did? > > The former, as Paul objected to the latter. I didn't object, per se. I just prefer my tools to DTRT in all cases without me having to use any

Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-02-02 Thread Paul Smith
On Sun, 2014-01-26 at 16:35 +, Ray Donnelly wrote: > I missed a few assert cases in the previous patch. Please find a fixed > version attached. I applied this change. Thanks! ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman

Re: Re: win32 compilation of make 4.0 source code‏

2014-02-02 Thread Paul Smith
On Tue, 2014-01-14 at 18:02 +0200, Eli Zaretskii wrote: > > === > > process_begin: CreateProcess(NULL, uname, ...) failed. > > make: > > process_begin: CreateProcess(NULL, uname -a, ...) failed. > > make: > > process_begin: CreateProcess(NULL, cygpath

Re: [PATCH] Refactor and merge child_execute_job() code

2014-02-02 Thread Paul Smith
On Fri, 2014-01-31 at 10:32 +0400, Pavel Fedin wrote: > Ok, i actually can leave it as a macro. I prefer the macro form as well; please keep it that way. Also, I'm not sure I like the current child_execute_job() where there are two completely different implementations in the same function, handle

Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-02-04 Thread Paul Smith
On Tue, 2014-02-04 at 10:33 +, Ray Donnelly wrote: > I can't see it in the git repository yet. > > .. am I being too impatient? > Sorry, it's committed in my local repo at home but I haven't pushed. I'll do that tonight. ___ Bug-make mailing list

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Paul Smith
On Tue, 2014-02-04 at 18:54 +0200, Eli Zaretskii wrote: > > Another issue is with backslashes in paths. > > > > For example: > > $ cat < foo.mk > > foo: > > grep foo < foo\\bar > > EOF > > > > (Note the < is just there to trigger sh -c) > > > > This executes sh -c "grep foo < foo\\bar",

Re: speeding up GNU make for LibreOffice by factor ~2 (and dependency file parsing by factor ~10)

2014-02-21 Thread Paul Smith
On Thu, 2014-02-20 at 03:53 +0100, Bjoern Michaelsen wrote: > The second time GNU make comes past the includedepcache statement, it > checks for the ${includefile}.cache file, and if it is younger than > ${includefile}, and if so, it reads that file instead of the > ${includefile}. This seems real

Re: load features

2014-02-21 Thread Paul Smith
On Wed, 2014-02-19 at 22:34 -0700, Lester Scofield wrote: > I am thinking about writing a module for SQLite. My first goal is to > create a $(sqlite) function. I'd like it to behave similar to the > sqlite3 shell, with its added .commands and such. I think there are > some things I'd like acces

Re: Bug-make Digest, Vol 135, Issue 17

2014-02-24 Thread Paul Smith
On Mon, 2014-02-24 at 18:50 +0100, Bjoern Michaelsen wrote: > Yes. But of course for any bigger C/C++ project, although a rather > specific usecase, it makes up the majority of the source to parse. > _If_ LibreOffice wouldnt already do some tricks, parsing the 13GB of > generated dependencies would

Re: Bug-make Digest, Vol 135, Issue 17

2014-02-24 Thread Paul Smith
On Mon, 2014-02-24 at 18:51 +, Tim Murphy wrote: > On 24 February 2014 18:33, Paul Smith wrote: > > > I would definitely want this to be totally invisible to the user and not > > require any magic in makefiles (so no special include operator, etc.) > > Basically it

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-03-02 Thread Paul Smith
On Thu, 2014-02-27 at 10:53 +0900, Mike Hommey wrote: > > I have no problems with your original patch. I think I said that > > right there and then. If Paul agrees, I will commit it. > > Paul? I'll reiterate my position that (a) I've seen nothing showing that it's inherently impossible for make

Re: [PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-09 Thread Paul Smith
On Wed, 2014-03-05 at 22:04 +0400, Pavel Fedin wrote: > Hello, Paul! Sorry for so long delay, i'm really quite busy, however i > have found some time to get back to this. Please review the new > version. I like this patch; it looks like a good improvement! It works fine for me on UNIX syst

Re: Test harness on VMS, running 511 tests, 60 tests failing.

2014-03-16 Thread Paul Smith
On Sun, 2014-03-16 at 21:43 -0500, John E. Malmberg wrote: > With that correction, I am back to 60 tests failing in 29 categories > failing if I use the -keep option. You should never use -keep when invoking the full test suite. Using -keep will cause other tests to fail, on all platforms: it's

Re: error reporting

2014-04-08 Thread Paul Smith
On Mon, 2014-04-07 at 21:26 -0700, Philip Guenther wrote: > I am unable to reproduce this: Based on the offer of MSVC project files I would guess Rob is running on Windows. I expect this is a result of the buggy snprintf()/vsnprintf() implementations in the Windows MSVC compiler (well, by "buggy"

Re: error reporting

2014-04-08 Thread Paul Smith
On Tue, 2014-04-08 at 20:15 +, Rob Juergens wrote: > Note that in Unix, vsnprintf() returns the TOTAL number of chars > needed (add 1 for the null). If the output would overflow the buffer, > then you would get a return value larger than the specified buffer > size. > > In Windoze, vsnprintf(

Re: error reporting

2014-04-08 Thread Paul Smith
On Tue, 2014-04-08 at 21:01 +, Rob Juergens wrote: > Attached is a rewrite of the method vfmtconcat() in output.c. It seems > to fix the problem. Thanks, but as Philip mentioned earlier I've completely rewritten the output.c file and callers of it so they use only C89 compliant functions (so n

<    1   2   3   4   5   6   7   8   9   10   >