Hi,
in src/warc.c three methods are provided to generate uuids: libuuid,
uuid functions from libc, and a fallback method. At least OpenBSD,
FreeBSD and NetBSD provide those uuid functions in their libc.
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/uuid.3
This diff fixes the de
On Tuesday 16 December 2014 00:26:35 Jérémie Courrèges-Anglas wrote:
> Hi,
>
> in src/warc.c three methods are provided to generate uuids: libuuid,
> uuid functions from libc, and a fallback method. At least OpenBSD,
> FreeBSD and NetBSD provide those uuid functions in their libc.
>
> http://w
Tim Ruehsen writes:
> On Tuesday 16 December 2014 00:26:35 Jérémie Courrèges-Anglas wrote:
>> Hi,
>>
>> in src/warc.c three methods are provided to generate uuids: libuuid,
>> uuid functions from libc, and a fallback method. At least OpenBSD,
>> FreeBSD and NetBSD provide those uuid functions i
Tim Ruehsen wrote:
It looks like a good opportunity to fix ./configure's libuuid detection.
We just have to agree on an approach.
Suggestion:
if --with-libuuid explicitly specified
search for libuuid (pkg-config or fallback to AC_SEARCH_LIBS)
And for Windows? I guess the 'UuidCreate()' or
On Tuesday 16 December 2014 13:47:36 Jérémie Courrèges-Anglas wrote:
> Tim Ruehsen writes:
> > On Tuesday 16 December 2014 00:26:35 Jérémie Courrèges-Anglas wrote:
> >> Hi,
> >>
> >> in src/warc.c three methods are provided to generate uuids: libuuid,
> >> uuid functions from libc, and a fallback
Tim Ruehsen writes:
[...]
> Thanks, your patch has been pushed to git.
Great!
> On top of it I created the attached patch that implements my suggestion from
> above.
> Please review and test on OpenBSD if possible.
Patch reads fine and behaves as advertized on OpenBSD-current.
--
jca | PGP
On Thursday 18 December 2014 01:45:14 Jérémie Courrèges-Anglas wrote:
> Tim Ruehsen writes:
>
> [...]
>
> > Thanks, your patch has been pushed to git.
>
> Great!
>
> > On top of it I created the attached patch that implements my suggestion
> > from above.
> > Please review and test on OpenBSD
Gisle Vanem wrote:
And for Windows? I guess the 'UuidCreate()' or 'UuidCreateSequential()'
functions from Rpcrt4.dll could be used?
I could write a patch for loading Rpcrt4.dll at run-time if
there's some interest.
Done that now. It was simple enough:
--- Git-latest/src/warc.c2014-12-28
On Monday 05 January 2015 16:40:15 Gisle Vanem wrote:
> Gisle Vanem wrote:
> > And for Windows? I guess the 'UuidCreate()' or 'UuidCreateSequential()'
> > functions from Rpcrt4.dll could be used?
> >
> > I could write a patch for loading Rpcrt4.dll at run-time if
> > there's some interest.
>
> Do
> Date: Mon, 05 Jan 2015 16:40:15 +
> From: Gisle Vanem
>
> Gisle Vanem wrote:
>
> > And for Windows? I guess the 'UuidCreate()' or 'UuidCreateSequential()'
> > functions from Rpcrt4.dll could be used?
> >
> > I could write a patch for loading Rpcrt4.dll at run-time if
> > there's some inter
> From: Tim Ruehsen
> Date: Tue, 06 Jan 2015 14:28:03 +0100
>
> If rpcrt4.lib/.dll is *not* a basic windows library, you should check for the
> library in configure.ac (case "$host_os" in ...).
That's not really friendly to those who download precompiled binaries,
since the situation on the mac
On Tuesday 06 January 2015 14:09:39 Gisle Vanem wrote:
> > I would prefer dynamic linking (-lrpcrt4).
>
> You mean use LoadLibrary ("rpcrt4.dll") at run-time?
> That would be cleaner. So that should be done in mswindows.c
> at init-time (in ws_startup()?).
I didn't mean it, but yes, that would be
> Date: Wed, 11 Feb 2015 00:15:32 +0100
> From: Gisle Vanem
>
> > Do we still want to support the older Windows NT4 and 9X versions? If
> > so, we should try loading Rpcrt4.dll dynamically, with LoadLibrary,
> > and if that fails, fall back on the current code.
>
> Seems this issue is dangling
Eli Zaretskii wrote:
+ if (rpc_uuid_avail == -1)
+{
+ HMODULE hm_rpcrt4 = LoadLibrary ("Rpcrt4.dll");
+
+ if (hm_rpcrt4)
+ {
+ pfn_UuidCreate =
+ (UuidCreate_proc) GetProcAddress (hm_rpcrt4, "UuidCreate");
+ pfn_UuidToString =
+ (UuidToStr
[Please CC me directly, as I'm not subscribed to the list.]
> Date: Sat, 14 Feb 2015 14:33:20 +0100
> From: Gisle Vanem
> CC: bug-wget@gnu.org
>
> Eli Zaretskii wrote:
>
> > + if (rpc_uuid_avail == -1)
> > +{
> > + HMODULE hm_rpcrt4 = LoadLibrary ("Rpcrt4.dll");
> > +
> > + if (h
Eli Zaretskii writes:
> [Please CC me directly, as I'm not subscribed to the list.]
>
>> Date: Sat, 14 Feb 2015 14:33:20 +0100
>> From: Gisle Vanem
>> CC: bug-wget@gnu.org
>>
>> Eli Zaretskii wrote:
>>
>> > + if (rpc_uuid_avail == -1)
>> > +{
>> > + HMODULE hm_rpcrt4 = LoadLibrary ("
16 matches
Mail list logo