[Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-02 Thread YX Hao
Dear Tim, The 2nd patch is attached. Please take a review :) Best Regards, YX Hao wget_v1.9.2_Make url_file_name also convert remote path to local encodedpatch Description: Binary data

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-12 Thread Tim Rühsen
On Donnerstag, 2. November 2017 21:09:46 CET YX Hao wrote: > Dear Tim, > > > > The 2nd patch is attached. Please take a review :) Hmmm, is this a stand-alone patch and working without your patch #1 (Fix printing...) ? Please give at least one example (better more) to show what your patch fixe

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-12 Thread Eli Zaretskii
> From: Tim Rühsen > Date: Sun, 12 Nov 2017 14:50:47 +0100 > Cc: YX Hao > > As I understand, the second patch is still in discussion with Eli. Since I do > not have Windows, I can't help you here. Though what I saw from the > discussion, you address a portability issue that likely should be so

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-13 Thread Yuxi Hao
I agree with Eli! > -Original Message- > From: Eli Zaretskii [mailto:e...@gnu.org] > Sent: 2017年11月13日 2:47 > To: Tim Rühsen > Cc: bug-wget@gnu.org; lifenjoi...@163.com > Subject: Re: [Bug-wget] Patch: Make url_file_name also convert remote path to > local encoded &g

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-13 Thread Yuxi Hao
Hi Tim, > From: Tim Rühsen [mailto:tim.rueh...@gmx.de] > Sent: 2017年11月12日 21:51 > Hmmm, is this a stand-alone patch and working without your patch #1 (Fix > printing...) ? Yes. They are standalone patches. > Please give at least one example (better more) to show what your patch fixes. > Even be

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-13 Thread Yuxi Hao
ect on all platforms. Isn't it? Best Regards, YX Hao > -Original Message- > From: Yuxi Hao [mailto:lifenjoi...@163.com] > Sent: 2017年11月13日 19:42 > To: 'Tim Rühsen' ; 'bug-wget@gnu.org' > > Subject: RE: [Bug-wget] Patch: Make url_file_name al

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-13 Thread Tim Rühsen
On 11/12/2017 07:46 PM, Eli Zaretskii wrote: >> From: Tim Rühsen >> Date: Sun, 12 Nov 2017 14:50:47 +0100 >> Cc: YX Hao >> >> As I understand, the second patch is still in discussion with Eli. Since I >> do >> not have Windows, I can't help you here. Though what I saw from the >> discussion, y

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-13 Thread Eli Zaretskii
> Cc: bug-wget@gnu.org, lifenjoi...@163.com > From: Tim Rühsen > Date: Mon, 13 Nov 2017 16:36:39 +0100 > > > I don't think it's a Gnulib issue. The problem is that on Windows, > > the implicit call at the beginning of Wget > > > > setlocale (LC_ALL, "C"); > > Why is there an explicit call wi

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-14 Thread Yuxi Hao
skii [mailto:e...@gnu.org] > Sent: 2017年11月14日 0:33 > To: Tim Rühsen > Cc: bug-wget@gnu.org; lifenjoi...@163.com > Subject: Re: [Bug-wget] Patch: Make url_file_name also convert remote path to > local encoded > > > Cc: bug-wget@gnu.org, lifenjoi...@163.com > > From:

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-15 Thread Tim Rühsen
On Montag, 13. November 2017 19:41:32 CET Yuxi Hao wrote: > Hi Tim, > > > From: Tim Rühsen [mailto:tim.rueh...@gmx.de] > > Sent: 2017年11月12日 21:51 > > Hmmm, is this a stand-alone patch and working without your patch #1 (Fix > > printing...) ? > > Yes. They are standalone patches. Just pushed you

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-15 Thread Tim Rühsen
On Montag, 13. November 2017 18:32:46 CET Eli Zaretskii wrote: > > Cc: bug-wget@gnu.org, lifenjoi...@163.com > > From: Tim Rühsen > > Date: Mon, 13 Nov 2017 16:36:39 +0100 > > > > > I don't think it's a Gnulib issue. The problem is that on Windows, > > > the implicit call at the beginning of Wge

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-15 Thread Eli Zaretskii
> From: Tim Rühsen > Cc: lifenjoi...@163.com > Date: Wed, 15 Nov 2017 20:28:17 +0100 > > I just wonder if we have the same problem on Linux console as well. > I mean, *not* calling setlocale(LC_ALL, "") (when ENABLE_NLS is undefined) > would leave the program with the C locale, even if the conso