Re: pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-27 Thread Theo de Raadt
Gibson Pilconis wrote: > I'm working on a project that supports OpenBSD and I noticed that > pcidevs_data.h uses > structures defined in pcireg.h but doesn't include the file. As a result, > pcireg.h has > to be included before pcidevs_data.h or else the compiler will throw an > error. > >

Re: pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-26 Thread Gibson Pilconis
What's the distinction between public and private headers within OpenBSD? I'm not trying to be argumentative I'm just genuinely curious since I can't find any info on what that means in the context of the project on Google. On Tuesday, March 26th, 2024 at 1:40 PM, Mark Kettenis wrote: >

Re: pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-26 Thread Mark Kettenis
> Date: Tue, 26 Mar 2024 17:08:24 + > From: Gibson Pilconis > > If it was exclusively accessible within the kernel I'd agree that it > probably isn't neccessary, the trouble is that it is also accessible > by userland programs. pcidump is an example of a userland program > that is part of

Re: pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-26 Thread Gibson Pilconis
If it was exclusively accessible within the kernel I'd agree that it probably isn't neccessary, the trouble is that it is also accessible by userland programs. pcidump is an example of a userland program that is part of the OpenBSD project and includes the header, and that file acts as a

Re: pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-26 Thread Stuart Henderson
On 2024/03/25 05:12, Gibson Pilconis wrote: > Hi. > > I'm working on a project that supports OpenBSD and I noticed that > pcidevs_data.h uses > structures defined in pcireg.h but doesn't include the file. As a result, > pcireg.h has to be > included before pcidevs_data.h or else the compiler

pcidevs_data.h relies on pcireg.h despite not including it.

2024-03-25 Thread Gibson Pilconis
Hi. I'm working on a project that supports OpenBSD and I noticed that pcidevs_data.h uses structures defined in pcireg.h but doesn't include the file. As a result, pcireg.h has to be included before pcidevs_data.h or else the compiler will throw an error.  I'm not sure if this is considered a