hg: jdk7/build/jdk: 2 new changesets

2011-05-05 Thread ahughes
Changeset: 8e9e28663c5d Author:andrew Date: 2011-05-06 01:55 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8e9e28663c5d 7042040: Remove disk space sanity check Summary: Remove outdated disk space checks using df Reviewed-by: ohair, omajid ! make/common/shared/Defs-versio

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-05 Thread David Holmes
Keith McGuigan said the following on 05/05/11 22:59: While the code is fine and I won't complain if you push it as is, Great thanks I'll stop there :-) don't like the idea that we "disable" the altsrc mechanism when building OPENJDK. The idea of alternate sources is that distributions ought

hg: jdk7/build/jdk: 7026163: gzip tar files

2011-05-05 Thread christine . lu
Changeset: 28c1be91a39f Author:cl Date: 2011-05-05 18:05 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/28c1be91a39f 7026163: gzip tar files Reviewed-by: katleman ! make/common/shared/Defs-utils.gmk

Re: Need reviewer: Added test target and makefile cleanups

2011-05-05 Thread Omair Majid
Hi Kelly, Kelly O'Hair writes: > > > Need reviewer: Added test target and makefile cleanups > > 6960335: Add top level 'make test' rule that uses test/Makefile, runs > all test batches > 6960853: Cleanup makefiles, remove unused vars etc. > > http://cr.openjdk.java.net/~ohair/openjdk7/test-

Re: Request for review: do not use --sync with df during sanity check

2011-05-05 Thread Kelly O'Hair
On May 5, 2011, at 1:34 AM, Dr Andrew John Hughes wrote: > > Try http://cr.openjdk.java.net/~andrew/sync/webrev.03/ Looks fine. Push it into jdk7/build/jdk and I'll herd it in. > >> I'm not sure how much longer we can accept non-critical changes for jdk7. >> >> The approval process is getti

Re: Request for review: 7036525 Disable alternative source mechanism for OPENJDK builds

2011-05-05 Thread Keith McGuigan
While the code is fine and I won't complain if you push it as is, I don't like the idea that we "disable" the altsrc mechanism when building OPENJDK. The idea of alternate sources is that distributions ought to be able to define their own distribution-specific code. OPENJDK could well h

Re: Request for review: do not use --sync with df during sanity check

2011-05-05 Thread Dr Andrew John Hughes
On 18:14 Wed 04 May , Kelly O'Hair wrote: > > On May 4, 2011, at 5:42 PM, Dr Andrew John Hughes wrote: > > >> > >> 7042040: Remove disk space sanity check > >> > > > > Ok, if > > > > http://cr.openjdk.java.net/~andrew/sync/webrev.02/ > > > > looks ok, I'll push it to the build tree. > >