I am back and Dan has It correct (JDK-8005044)
-Original Message-
From: Daniel D. Daugherty
Sent: Thursday, December 13, 2012 4:32 PM
To: hotspot-runtime-...@openjdk.java.net; build-dev;
serviceability-...@openjdk.java.net
Subject: Re: code review request for 7153050 remove crufty '_g' s
Trying again... now my e-mail client is complaining...
Adding back in the other OpenJDK aliases...
Ron's e-mail has gone off-line (no e-mail for him since 1440 MT)...
Coleen,
Thanks for the review!
This bug (7153050) is just for the Makefile changes so that the
reviews are more focused. Ron h
Adding back in the other OpenJDK aliases...
Ron's e-mail has gone off-line (no e-mail for him since 1440 MT)...
Coleen,
Thanks for the review!
This bug (7153050) is just for the Makefile changes so that the
reviews are more focused. Ron has separate bugs for the other parts
of the hotspot repo
Thx again
-Original Message-
From: Daniel D. Daugherty
Sent: Thursday, December 13, 2012 1:51 PM
To: build-dev; serviceability-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net; Ron Durbin
Subject: Re: code review request for 7153050 remove crufty '_g' support
Serguei,
Thanks
Just for the record: I have reviewed all of Ron's changes and I approve
them.
Dan
On 12/13/12 11:53 AM, Daniel D. Daugherty wrote:
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure
you include
Serguei,
Thanks for the fast review!
I could swear that Ron had removed lines 41 and 45 in an earlier
version. Sigh... Will be fixed.
Dan
On 12/13/12 1:22 PM, serguei.spit...@oracle.com wrote:
Dan,
It is nice fix and simplified many places.
Just one minor comment:
make/bsd/makefiles/dtrac
Forgot to mention the testing:
These changes were tested with a full JPRT-hotspotwest job.
Verified that the JPRT bundles no longer contain _g files:
$ pwd
/net/prt-archiver.us.oracle.com/data/jprt/archive/2012/12/2012-12-13-030336.ddaugher.7153050_exp/bundles
$ for zfile in *.zip; do
> echo "
Dan,
It is nice fix and simplified many places.
Just one minor comment:
make/bsd/makefiles/dtrace.make
41 #LIBJVM_DB = libjvm_db.dylib
42 LIBJVM_DB = libjvm_db.dylib
45 #LIBJVM_DTRACE = libjvm_dtrace.dylib
46 LIBJVM_DTRACE = libjvm_dtrace.dylib
The lines #41 and #45 can be removed
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure
you include Ron on any e-mail replies since he is not yet on the
OpenJDK aliases.
Dan
Intro:
This set of changes removes the makefile support fo
