Re: OpenJDK rebuilding on windows takes a long time

2013-02-14 Thread Fredrik Öhrström
2013/2/15 Ioi Lam : > Is there an option in the makefiles to compile ONLY the .java file that's > changed (assuming I know the changes won't affect other classes)? Yes, configure with --enable-sjavac. Then it will recompile exactly the java files you have touched. And if the public api of the pa

Re: 8007436: (profiles) Add JSR-310 to Compact Profiles contents

2013-02-14 Thread David Holmes
On 15/02/2013 3:57 AM, Alan Bateman wrote: As David mentioned in another mail, he is hoping to push the profiles work to jdk8/build next week. One update that is needed to the configuration is the changes to take account of ThreeTen (java.time.**). This includes taking into account the ThreeTen

Re: Hotspot - kind of build and how to detect?

2013-02-14 Thread David Holmes
On 15/02/2013 10:55 AM, Mani Sarkar wrote: Hi all again, I did some searching in the OpenJDK folders and found the below notations: *$(CONF_NAME)* in the below line in one of the make files: @$(PRINTF) "Building $(PRODUCT_NAME) for target '$(call GetRealTarget)' in configuration '$(CONF_NAME)'\

Re: Hotspot - kind of build and how to detect?

2013-02-14 Thread David Holmes
On 15/02/2013 5:09 AM, Mani Sarkar wrote: I had asked a query [1] long ago in line with the different builds types when build the OpenJDK project or sub-projects. I have another query related to it - i.e. is there a way to determine what type of build you are currently configured for? Is there an

Re: OpenJDK rebuilding on windows takes a long time

2013-02-14 Thread Ioi Lam
On 02/14/2013 02:24 AM, Alexander Scherbatiy wrote: On 2/13/2013 8:45 PM, Kelly O'Hair wrote: You are pointing at the fastdebug jdk as your boot jdk, why? The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else will work, although it should, when tracking down issues like th

Re: recent problems with JFX ant script

2013-02-14 Thread Kelly O'Hair
There are known conflicts with TMP, TEMP, and TMPDIR with many Windows tools. Having both upper and lowercase names is an additional complication. Worse is that some tools want paths that are pure Windows, like C:\temp, some will accept C:/temp, and some might expect their own path style, like /cy

recent problems with JFX ant script

2013-02-14 Thread Pete Brunet
I ran into two new problems building JFX on Win 7 this week: 1) I had to unset lowercase tmp and temp. Apparently there is a new problem with having duplicates, TMP/tmp and TEMP/temp. This may be related to http://www.cmake.org/Bug/print_bug_page.php?bug_id=13131 The failure appeared as: launc

Re: OpenJDK rebuilding on windows takes a long time

2013-02-14 Thread Kelly O'Hair
On Feb 14, 2013, at 2:24 AM, Alexander Scherbatiy wrote: > On 2/13/2013 8:45 PM, Kelly O'Hair wrote: >> You are pointing at the fastdebug jdk as your boot jdk, why? >> >> The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else >> will work, although it should, >> when trackin

8007436: (profiles) Add JSR-310 to Compact Profiles contents

2013-02-14 Thread Alan Bateman
As David mentioned in another mail, he is hoping to push the profiles work to jdk8/build next week. One update that is needed to the configuration is the changes to take account of ThreeTen (java.time.**). This includes taking into account the ThreeTen updates for M7 that remove the old time

Re: RFR (S): 8007639: Workaround for ccache in vm.make is incorrect

2013-02-14 Thread Mikael Vidstedt
Erik/David - Thanks for the reviews! Cheers, Mikael On 2/12/2013 6:35 PM, David Holmes wrote: Looks okay to me. David On 13/02/2013 12:32 PM, Mikael Vidstedt wrote: Good catch! There is no fundamental reason for switching to CFLAGS, and since the other defines are added to CXXFLAGS so shou

Re: Review Request: 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac

2013-02-14 Thread David DeHaven
> Here are a series of patches that adds the following to all native compile > lines on macosx: > > -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 I know I'm not a reviewer, but I have an opinion anyways :) Using "-mmacosx-version-min=10.7" seems more appropriate for

Re: Review Request: 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac

2013-02-14 Thread Kelly O'Hair
These changes look good to me. -kto On Feb 14, 2013, at 8:24 AM, Erik Joelsson wrote: > Here are a series of patches that adds the following to all native compile > lines on macosx: > > -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 > > This is needed to ensure that

Review Request: 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac

2013-02-14 Thread Erik Joelsson
Here are a series of patches that adds the following to all native compile lines on macosx: -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 This is needed to ensure that no macosx APIs newer than version 10.7 are used, and will cause compile time errors if they are.

Re: OpenJDK rebuilding on windows takes a long time

2013-02-14 Thread Alexander Scherbatiy
On 2/13/2013 8:45 PM, Kelly O'Hair wrote: You are pointing at the fastdebug jdk as your boot jdk, why? The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else will work, although it should, when tracking down issues like this, you need to narrow down all the possible differe

Re: [7u] Request for approval for CR 8007450 - Add build support for different man pages for OpenJDK and OracleJDK

2013-02-14 Thread Seán Coffey
Approved. regards, Sean. On 13/02/2013 22:35, Tim Bell wrote: Requesting approval for these changes in make/common/Release.gmk Adding a total of 8 lines in the open makefile. The OracleJDK pages will be placed in a closed part of the forest. Webrev: http://cr.openjdk.java.net/~erikj/8007