Re: [7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Build part looks ok. /Erik On 2013-10-01 07:39, dmitry markov wrote: Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev for jdk7u: http://cr.

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

I have looked at the build changes in the root and jdk repos and they look OK. /Erik On 2013-09-21 05:36, Daniel D. Daugherty wrote: Greetings, I have the initial support for Full Debug Symbols (FDS) on MacOS X done and ready for review: 7165611 implement Full Debug Symbols on MacOS X ho

RFR (XXS): JDK-8019219 Typo in jdk/makefiles "default" targets

Bug: https://bugs.openjdk.java.net/browse/JDK-8019219 The default target in CompileNativeLibraries.gmk and CompileLaunchers.gmk is spelled "defalt". This does not affect functionality. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8019219-correct-target-typo/webrev.01 /Magnus

Re: RFR (XXS): JDK-8019219 Typo in jdk/makefiles "default" targets

Looks good. /Erik On 2013-10-01 10:54, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8019219 The default target in CompileNativeLibraries.gmk and CompileLaunchers.gmk is spelled "defalt". This does not affect functionality. Webrev: http://cr.openjdk.java.net/~ihs

Re: RFR: JDK-8025686 : (s) Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support

The changes look ok to me Mike. Thanks, -Chris, On 09/30/2013 09:48 PM, Mike Duigou wrote: Hello all; When JDK-8006709 (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cff8d7768d72) was pushed it changed the default source level for the jdk project NetBeans projects to 1.8. This was a reasonabl

Re: Jarreorder and classlists

Hello again, I have now regenerated the classlists @b107 and run new comparisons. To me it looks like the differences are essentially non existant between new and old classlists and in the previous comparison we saw no difference between random order and old classlists. It's very possible th

Re: [7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

I'm not sure whether I'm allowed to review the backport of my own fix, but anyway, it looks good. On 10/1/2013 9:39, dmitry markov wrote: Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http:/

Re: RFR: JDK-8025686 : (s) Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support

Looks ok to me as well Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 1, 2013, at 5:32 AM, Chris Hegarty wrote: > The changes look ok to me Mike. Thanks, > >

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Dan, Sorry, for later answer - was busy trying to run UTE on Mac. I can test non-darwin logic if you give me a link to workspace. -Dmitry On 2013-09-30 17:44, Daniel D. Daugherty wrote: > On 9/30/13 7:13 AM, Staffan Larsen wrote: >> First: thanks for doing this work - it will make debugging on o

Re: RFR (XXS): JDK-8008944 correct typos

On 2013-10-01 14:14, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8008944 Fix some typos in comments and messages, as pointed out by users. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8008944-fix-typos/webrev.01 Erik pointed out to me that I should fix all typos on

Re: Jarreorder and classlists

On 2013-10-01 12:30, Erik Joelsson wrote: Hello again, I have now regenerated the classlists @b107 and run new comparisons. To me it looks like the differences are essentially non existant between new and old classlists and in the previous comparison we saw no difference between random order

RFR (XXS): JDK-8008944 correct typos

Bug: https://bugs.openjdk.java.net/browse/JDK-8008944 Fix some typos in comments and messages, as pointed out by users. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8008944-fix-typos/webrev.01 /Magnus

Heads up: Removal of the old build system in JDK8

The new build system ("build-infra") has been the default way of building the JDK for almost a year. Keeping the old build system in sync with the new requires time and effort, and is getting harder all the time. So the time has come to finally kill of the old build system for those components

Re: Jarreorder and classlists

On 1/10/2013 8:30 PM, Erik Joelsson wrote: Hello again, I have now regenerated the classlists @b107 and run new comparisons. To me it looks like the differences are essentially non existant between new and old classlists and in the previous comparison we saw no difference between random order an

Re: Jarreorder and classlists

On 2013-10-01 15:05, David Holmes wrote: On 1/10/2013 8:30 PM, Erik Joelsson wrote: Hello again, I have now regenerated the classlists @b107 and run new comparisons. To me it looks like the differences are essentially non existant between new and old classlists and in the previous comparison w

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Thanks (again). You previously posted a review for the OpenJDK side on 2013.09.23... :-) Dan On 10/1/13 2:42 AM, Erik Joelsson wrote: I have looked at the build changes in the root and jdk repos and they look OK. /Erik On 2013-09-21 05:36, Daniel D. Daugherty wrote: Greetings, I have the

RFR (XXS): JDK-8016024 Remove solaris path from FillCacheFind

Bug: https://bugs.openjdk.java.net/browse/JDK-8016024 % cat -n jdk/makefiles/Tools.gmk [...] 26 # Cache all finds needed for this file. Only used on windows. 27 $(eval $(call FillCacheFind,$(JDK_TOPDIR)/make/tools \ 28 $(JDK_TOPDIR)/src/solaris/classes \ 29 $(JDK_TOPDIR)/makef

Re: RFR (XXS): JDK-8019219 Typo in jdk/makefiles "default" targets

Magnus: Bug: https://bugs.openjdk.java.net/browse/JDK-8019219 The default target in CompileNativeLibraries.gmk and CompileLaunchers.gmk is spelled "defalt". This does not affect functionality. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8019219-correct-target-typo/webrev.01 Looks good t

Re: RFR (XXS): JDK-8008944 correct typos

Magnus: Bug: https://bugs.openjdk.java.net/browse/JDK-8008944 Fix some typos in comments and messages, as pointed out by users. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8008944-fix-typos/webrev.01 Looks good to me. /Tim

Re: RFR (XXS): JDK-8016024 Remove solaris path from FillCacheFind

Magnus: Bug: https://bugs.openjdk.java.net/browse/JDK-8016024 % cat -n jdk/makefiles/Tools.gmk [...] 26 # Cache all finds needed for this file. Only used on windows. 27 $(eval $(call FillCacheFind,$(JDK_TOPDIR)/make/tools \ 28 $(JDK_TOPDIR)/src/solaris/classes \ 29 $(JDK_TOP

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Open changes look good to me as well. Tim On 10/ 1/13 06:48 AM, Daniel D. Daugherty wrote: Thanks (again). You previously posted a review for the OpenJDK side on 2013.09.23... :-) Dan On 10/1/13 2:42 AM, Erik Joelsson wrote: I have looked at the build changes in the root and jdk repos and th

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Tim, Thanks for the review. Dan On 10/1/13 9:30 AM, Tim Bell wrote: Open changes look good to me as well. Tim On 10/ 1/13 06:48 AM, Daniel D. Daugherty wrote: Thanks (again). You previously posted a review for the OpenJDK side on 2013.09.23... :-) Dan On 10/1/13 2:42 AM, Erik Joelsson w

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

On 9/30/13 12:00 PM, Staffan Larsen wrote: On 30 sep 2013, at 15:44, Daniel D. Daugherty wrote: I'm presuming that you're trying with a forest that includes closed repos. If so, then you'll need the jdk/make/closed change in order for the build to work. Yes, I was running with closed repos.

8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification

I need a reviewer for a trivial change to add an additional package to the API docs. The background to this one is that JAXP has historically included the API package org.w3c.dom.events but not org.w3c.dom.views. As org.w3c.dom.events.UIEvent defines a method that returns a type in org.w3c.

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

On 1 okt 2013, at 18:01, "Daniel D. Daugherty" wrote: > On 9/30/13 12:00 PM, Staffan Larsen wrote: >> On 30 sep 2013, at 15:44, Daniel D. Daugherty >> wrote: >> >>> >>> I'm presuming that you're trying with a forest that includes >>> closed repos. If so, then you'll need the jdk/make/closed

Re: Jarreorder and classlists

On 10/01/2013 08:06 AM, Erik Joelsson wrote: On 2013-10-01 15:05, David Holmes wrote: On 1/10/2013 8:30 PM, Erik Joelsson wrote: Hello again, I have now regenerated the classlists @b107 and run new comparisons. To me it looks like the differences are essentially non existant between new and o

Re: 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification

The change looks fine to me. I assume you are going to be pushing this through TL? Mike On Oct 1 2013, at 09:25 , Alan Bateman wrote: > > I need a reviewer for a trivial change to add an additional package to the > API docs. > > The background to this one is that JAXP has historically includ

Re: 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification

Hi Alan: I need a reviewer for a trivial change to add an additional package to the API docs. The background to this one is that JAXP has historically included the API package org.w3c.dom.events but not org.w3c.dom.views. As org.w3c.dom.events.UIEvent defines a method that returns a type in

Re: [7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

The fix looks fine to me. -- best regards, Anthony On 10/01/2013 09:39 AM, dmitry markov wrote: Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 web

hg: jdk8/build: 2 new changesets

Changeset: 0cc21882d2f6 Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/0cc21882d2f6 Added tag jdk8-b109 for changeset 91f47e8da5c6 ! .hgtags Changeset: 72c2495c86c9 Author:katleman Date: 2013-10-01 12:43 -0700 URL: http://hg.op

hg: jdk8/build/corba: Added tag jdk8-b109 for changeset 428428cf5e06

Changeset: 3d2b7ce93c5c Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/3d2b7ce93c5c Added tag jdk8-b109 for changeset 428428cf5e06 ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b109 for changeset c81dd5393a5e

Changeset: fff4842215d1 Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fff4842215d1 Added tag jdk8-b109 for changeset c81dd5393a5e ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b109 for changeset df5d4d016425

Changeset: cc682329886b Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/cc682329886b Added tag jdk8-b109 for changeset df5d4d016425 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b109 for changeset 02bfab2aa938

Changeset: 4c84c5b447b0 Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/4c84c5b447b0 Added tag jdk8-b109 for changeset 02bfab2aa938 ! .hgtags

hg: jdk8/build/langtools: 35 new changesets

Changeset: 6f11dc295641 Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6f11dc295641 Added tag jdk8-b109 for changeset 985abf1cd327 ! .hgtags Changeset: fdfbc5f0c4ed Author:jjg Date: 2013-09-17 14:17 -0700 URL: http://

hg: jdk8/build/nashorn: 21 new changesets

Changeset: d1e2050e575e Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d1e2050e575e Added tag jdk8-b109 for changeset 6ec2f9e5ed5b ! .hgtags Changeset: 1971c2d770ae Author:sundar Date: 2013-09-18 13:06 +0530 URL: http:/

RFR (XS) JDK-8025569: -XX:+CheckUnhandledOops crashes on Windows

Please review the following fix: Webrev: http://cr.openjdk.java.net/~coleenp/bug_jdk8025569/ Bug: -XX:+CheckUnhandledOops crashes on Windows https://bugs.openjdk.java.net/browse/JDK-8025569 Summary of fix: Until JDK-8024364, (Win/x64:

Code review for bug fix 8025741

Hi, There is a bug in jdk/make/docs/Makefile for JDK8. The bug is listed at https://bugs.openjdk.java.net/browse/JDK-8025741. The Makefile for JDK 8 does not include the DEV_DOCS_URL that should point to the developer documentation URL for JDK 8. This creates an empty href in HTML tag result

Re: Heads up: Removal of the old build system in JDK8

Hi Magnus: Deploy repo in jdk8 is kept in sync with jdk7u, and we have files to make sure deploy can be built with both new and old build system. Please make sure me and Dave are cc'ed on any changes in deploy repo. Thanks. -thomas On 10/1/2013 6:30 AM, Magnus Ihse Bursie wrote: The new b

JDK 8 RFR: JDK-8024603 Turn on javac lint checking for auxiliaryclass, empty, and try in jdk build

Hello, As a follow-up to JDK-8024643 "Turn on javac lint checking in building the jdk repo", the time approaches to enable a few more lint warnings in the build of the jdk repo: JDK-8024603 Turn on javac lint checking for auxiliaryclass and empty in jdk build http://cr.openjdk.java

hg: jdk8/build/hotspot: 37 new changesets

Changeset: 8a6a85321d3a Author:amurillo Date: 2013-09-20 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8a6a85321d3a 8025127: new hotspot build - hs25-b52 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 63147986a428 Author:dcubed Date: 2013-09-1

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Hi Dan, Overall thumbs up. A couple of minor issues that need fixing. A few meta-comments (I hate seeing all this stuff duplicated again and again. David - - common/autoconf/hotspot-spec.gmk.in Seems a good simplification. - common/autoconf/jdk-options.m4 No comment. --- - comm

Re: 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification

On 01/10/2013 09:58, Mike Duigou wrote: The change looks fine to me. I assume you are going to be pushing this through TL? Mike Thanks Mike (and Tim). I'm going to push this through jdk8/tl. -Alan.