Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
Updated webrev for JDK (hotspot change is the same): http://cr.openjdk.java.net/~ddehaven/8025673/jdk.1/ Changes since last version: - Moved to jdk8/build/jdk to save someone a merge headache, moved changes to CompileNativeLibs.gmk to libs/Awt2dLibraries.gmk - Removed HToolkit option and toolkit

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread David Holmes
On 22/10/2013 9:31 AM, Weijun Wang wrote: On 10/21/13 9:18 PM, Magnus Ihse Bursie wrote: 21 okt 2013 kl. 14:28 skrev Weijun Wang : This is a full build, but I run configure on one machine and make from another. That is not a supported use case. Configure checks the local machine and prepares

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread Weijun Wang
On 10/21/13 9:18 PM, Magnus Ihse Bursie wrote: 21 okt 2013 kl. 14:28 skrev Weijun Wang : This is a full build, but I run configure on one machine and make from another. That is not a supported use case. Configure checks the local machine and prepares the build. Yes I know. On the other

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
I want to do one more iteration of this. Based on feedback it seems I can remove a bit more code from java_props_macosx.[ch] and make things a bit cleaner. -DrD- > Thanks guys. > > Anthony, can you sponsor this for me? > > -DrD- > >> This fix looks fine to me as well. >> >> -- >> best rega

Re: RFR: JDK-8026966: Most native libs broken on mac in jdk8/build

2013-10-21 Thread David DeHaven
> "JDK-8025715: Split CompileNativeLibraries.gmk", caused (almost) all > libraries on macosx to be linked incorrectly. I propose we fix this by > removing an ugly hack for libJObjC.dylib, which was only put there to make > the new and old build be as similar as possible. > > The result of this

Re: CYGWIN make is now at 4.01.

2013-10-21 Thread Bradford Wetmore
Thanks Tim, This bug was fixed today by to allow for 4.x. Does this mean that 4.x is supported, or just that sanity won't kill the build and you're on the bleeding edge that hopefully "should" work? http://hg.openjdk.java.net/jdk8/build/rev/1a853fac18ff Brad On 10/20/2013 10:58 AM, Tim B

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
Thanks guys. Anthony, can you sponsor this for me? -DrD- > This fix looks fine to me as well. > > -- > best regards, > Anthony > > On 10/20/2013 11:56 PM, David DeHaven wrote: >> >> CCing: build-dev, macosx-port-dev, hotspot-dev >> >> Request for review of JDK-8025673: >> https://bugs.openj

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread Daniel D. Daugherty
Running configure on a machine with gobjcopy and then running the build on a machine without gobjcopy would explain the failure mode that you're seeing. You need to file a bug with the build-infra folks. The old build system wouldn't have had this problem because there was no configure step. I'm n

RFR: JDK-8026966: Most native libs broken on mac in jdk8/build

2013-10-21 Thread Erik Joelsson
"JDK-8025715: Split CompileNativeLibraries.gmk", caused (almost) all libraries on macosx to be linked incorrectly. I propose we fix this by removing an ugly hack for libJObjC.dylib, which was only put there to make the new and old build be as similar as possible. The result of this fix is that

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Erik, with the small changes proposed in "8026964: Building with an IBM J9 boot jdk requires special settings for BOOT_RTJAR" https://bugs.openjdk.java.net/browse/JDK-8026964 I could finally successfully build with J9 as bootstrap jdk. I saw that you already submitted this change so I'm prob

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Neil, Steve, is there an easy way to detect and specify a correct setting for $(BOOT_RTJAR) if we are using an IBM J9 as bootstrap jdk in the new build system? With OpenJDK/Oracle based boot jdks $(BOOT_RTJAR) is simply set to "$BOOT_JDK/jre/lib/rt.jar" but this doesn't work with IBM J9 because

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Anthony Petrov
This fix looks fine to me as well. -- best regards, Anthony On 10/20/2013 11:56 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Anthony Petrov
Hi David, The fix looks fine to me. -- best regards, Anthony On 10/20/2013 11:53 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8016096/ Si

Re: RFR: JDK-8001922, JDK-8001927, JDK-8001921 Improve freetype detection

2013-10-21 Thread Magnus Ihse Bursie
Comments inline. 18 okt 2013 kl. 15:22 skrev Erik Joelsson : > > On 2013-10-18 14:59, Magnus Ihse Bursie wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8001922 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8001927 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8001921 >> >> These

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread Magnus Ihse Bursie
21 okt 2013 kl. 14:28 skrev Weijun Wang : > This is a full build, but I run configure on one machine and make from > another. That is not a supported use case. Configure checks the local machine and prepares the build. /Magnus > Doing both on the same machine without gobjcopy runs fine. > >

hg: jdk8/build/jaxws: 8026874: During JAXWS build the newly built JAXP classes should be in the bootclasspath (not only in the classpath)

2013-10-21 Thread erik . joelsson
Changeset: 17f1b13cd401 Author:simonis Date: 2013-10-21 15:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/17f1b13cd401 8026874: During JAXWS build the newly built JAXP classes should be in the bootclasspath (not only in the classpath) Reviewed-by: erikj ! makefiles/

hg: jdk8/build/jdk: 2 new changesets

2013-10-21 Thread erik . joelsson
Changeset: 7ec4ddc36ad6 Author:erikj Date: 2013-10-17 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7ec4ddc36ad6 8019540: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated. Reviewed-by: dholmes, sla ! makefiles/CopyIntoClasses.gmk Chang

hg: jdk8/build: 3 new changesets

2013-10-21 Thread erik . joelsson
Changeset: 17d195bd56fc Author:erikj Date: 2013-10-18 11:34 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/17d195bd56fc 8025869: make docs doesn't regenerate docs correctly after changing API doc comments in jaxp sources Reviewed-by: ihse, tbell ! common/makefiles/JavaCompil

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread Weijun Wang
This is a full build, but I run configure on one machine and make from another. Doing both on the same machine without gobjcopy runs fine. Thanks Max On 10/21/13 7:38 PM, David Holmes wrote: If gobjcopy is installed somewhere then ALT_OBJCOPY can be set to point to it. Was this part of a full

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Magnus Ihse Bursie
I agree with Erik once more. /Magnus 21 okt 2013 kl. 10:31 skrev Erik Joelsson : > Hello David, > > From a build point of view, the changes look fine to me. > > /Erik > > On 2013-10-21 01:56, David DeHaven wrote: >> CCing: build-dev, macosx-port-dev, hotspot-dev >> >> Request for review of J

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Magnus Ihse Bursie
I agree with Erik. /Magnus 21 okt 2013 kl. 10:31 skrev Erik Joelsson : > Hello David, > > From a build point of view, the changes look fine to me. > > /Erik > > On 2013-10-21 01:53, David DeHaven wrote: >> CCing: build-dev, macosx-port-dev >> >> Request for review of JDK-8016096: >> https://

Re: Solaris fastdebug build: gobjcopy?

2013-10-21 Thread David Holmes
Hi Max, On 21/10/2013 7:00 PM, Weijun Wang wrote: Hi All I'm trying --enable-debug on a Solaris and see this failure ## Starting hotspot INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO: ALT_OBJCOPY=/usr/sfw/bin/gobjcopy INFO: no objcopy cmd found so cannot create .debuginfo files. INFO: ENABLE_FULL_DEB

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Artem Ananiev
Hi, David, client (AWT, Java2D) part of the fix looks fine. Thanks, Artem On 10/21/2013 3:53 AM, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Artem Ananiev
Hi, David, the changes look fine to me. See more comments below. On 10/21/2013 3:56 AM, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.net/~ddehav

Solaris fastdebug build: gobjcopy?

2013-10-21 Thread Weijun Wang
Hi All I'm trying --enable-debug on a Solaris and see this failure ## Starting hotspot INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO: ALT_OBJCOPY=/usr/sfw/bin/gobjcopy INFO: no objcopy cmd found so cannot create .debuginfo files. INFO: ENABLE_FULL_DEBUG_SYMBOLS=0 INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO:

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Erik Joelsson
Hello David, From a build point of view, the changes look fine to me. /Erik On 2013-10-21 01:53, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Erik Joelsson
Hello David, From a build point of view, the changes look fine to me. /Erik On 2013-10-21 01:56, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.ne

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
On Mon, Oct 21, 2013 at 9:02 AM, David Holmes wrote: > On 19/10/2013 1:15 AM, Volker Simonis wrote: >> >> Hi Erik, >> >> I had to fix another issue in the JAXWS build >> (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've >> finally managed to get to the Corba build with a J9 boo

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:50 AM, Erik Joelsson wrote: Hello Volker, Building without a -bootclasspath results in the following warning which is likely why it was added in the first place: warning: [options] bootstrap class path not set in conjunction with -source 1.7 Note that we are using the bootstrap

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:15 AM, Volker Simonis wrote: Hi Erik, I had to fix another issue in the JAXWS build (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've finally managed to get to the Corba build with a J9 bootstrap JDK. With the following small change in BuildCorba.gmk: -