Re: RFR: JDK-8007897 Problems cleaning up a file named jdk/gensrc/java/nio/_the.. on Windows

2014-02-20 Thread David Holmes
On 20/02/2014 11:22 PM, Magnus Ihse Bursie wrote: During build, we create a touch file which is literally named '_the..'. While cygwin handles this without issues, Windows believes this to be a file with the extension "." and can't touch it, that is, not delete or move it. This patch renames thi

RFR: Allow using a system-installed lcms2

2014-02-20 Thread Omair Majid
Hi, The following is a preliminary webrev that allows OpenJDK to build and run against a system-installed copy of lcms2 rather than the copy bundled with OpenJDK: root: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00-jdk/

Re: Thread dump during build with ctrl-\

2014-02-20 Thread Magnus Ihse Bursie
On 2014-02-20 19:57, Mike Duigou wrote: I've tried John's suggestion and it helps but is not enough. I believe I would have to trap the outer make invocation as well. Unfortunately wrapping make in a script just to be able to to use ctrl-\ is probably not worth it. If what you need to wrap m

Re: Thread dump during build with ctrl-\

2014-02-20 Thread Mike Duigou
I've tried John's suggestion and it helps but is not enough. I believe I would have to trap the outer make invocation as well. Unfortunately wrapping make in a script just to be able to to use ctrl-\ is probably not worth it. I'm instead using jstack though it can be harder to get timing right.

Re: RFR: JDK-8007897 Problems cleaning up a file named jdk/gensrc/java/nio/_the.. on Windows

2014-02-20 Thread Tim Bell
Hi Magnus: During build, we create a touch file which is literally named '_the..'. While cygwin handles this without issues, Windows believes this to be a file with the extension "." and can't touch it, that is, not delete or move it. This patch renames this file (and others created at the s

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Anthony Petrov
Hi Omair, Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) If you change client code, then the fix should go to the client repo to avoid merge conflicts and allow for more manual testing prior to integrating the changes into the master repo. -- best regards, Anthony On 2/19/201

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-20 05:35]: > From my point of view, you can go either way. The changes are mostly > in the build code, except for an include statement. But if the AWT > folks feel more confident that way, sure, you can go via client. Pushed: http://hg.openjdk.java.net/jdk9/client/re

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Andrew Hughes
- Original Message - > Hi Omair, > > > Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) > > If you change client code, then the fix should go to the client repo to > avoid merge conflicts and allow for more manual testing prior to > integrating the changes into the master repo.

Re: RFR: JDK-8034788 Rewrite toolchain.m4 to support multiple toolchains per platform

2014-02-20 Thread Magnus Ihse Bursie
On 2014-02-13 22:27, Magnus Ihse Bursie wrote: It turned out that it was not a good idea to line break AC_MSG_* functions. :-( I didn't verify that properly before; my bad. Here's a new-new review which restores the old long (but properly-looking) AC_MSG lines. (If you're curious, the line

RFR: JDK-8007897 Problems cleaning up a file named jdk/gensrc/java/nio/_the.. on Windows

2014-02-20 Thread Magnus Ihse Bursie
During build, we create a touch file which is literally named '_the..'. While cygwin handles this without issues, Windows believes this to be a file with the extension "." and can't touch it, that is, not delete or move it. This patch renames this file (and others created at the same time) to

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Magnus Ihse Bursie
On 2014-02-20 09:47, Anthony Petrov wrote: Hi Omair, Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) If you change client code, then the fix should go to the client repo to avoid merge conflicts and allow for more manual testing prior to integrating the changes into the master r