Hello,
I was waiting for Magnus to look at this since he is more involved in
this code at the moment. I think it looks good ok, but would prefer if
he got the chance to look at it too.
/Erik
On 2014-03-06 01:11, Henry Jen wrote:
Ping! Is three any concern on this patch? I got JPRT reports no
Thanks for the comments.
Here is a new webrev: http://cr.openjdk.java.net/~erikj/8036611/webrev.02/
On 2014-03-05 12:16, Magnus Ihse Bursie wrote:
Hi Erik,
Good work!
Some comment:
* In JavaCompilation.gmk:
add_files_to_copy_and_clean should be named only "..to_clean", otherwise it
sounds as
Comments inline.
/Magnus
> On 6 mar 2014, at 10:50, Erik Joelsson wrote:
>
> Thanks for the comments.
>
> Here is a new webrev: http://cr.openjdk.java.net/~erikj/8036611/webrev.02/
Looks good to me now!
>
>> On 2014-03-05 12:16, Magnus Ihse Bursie wrote:
>> Hi Erik,
>>
>> Good work!
>>
>>
Looks good to me. Just one question, since clang otherwise duplicates the gcc
flags: is it correct to drop -fPIC in clang?
/Magnus
> On 6 mar 2014, at 09:36, Erik Joelsson wrote:
>
> Hello,
>
> I was waiting for Magnus to look at this since he is more involved in this
> code at the moment. I
I cannot find doc regarding to -fPIC in clang, thus I leave it empty
after googled a little bit.
There is a code generation option for lli, -relocation-model=pic, which
seems to be default for clang[1].
[1] http://clang.llvm.org/doxygen/CodeGenOptions_8h_source.html
Cheers,
Henry
On 03/06/2
