Re: JDK-8037953 configure usability: Should provide better details on imported hotspot

2014-05-08 Thread Erik Joelsson
Hello Dave, Adding this information certainly makes sense. While probably not a very common usecase, it is currently possible to point --with-import-hotspot to the dist directory of a Hotspot build. The problem then is that there will be no java launcher present to query for version

Re: JDK-8037953 configure usability: Should provide better details on imported hotspot

2014-05-08 Thread David Holmes
On 8/05/2014 5:56 PM, Erik Joelsson wrote: Hello Dave, Adding this information certainly makes sense. While probably not a very common usecase, it is currently possible to point --with-import-hotspot to the dist directory of a Hotspot build. The problem then is that there will be no java

Re: JDK-8037953 configure usability: Should provide better details on imported hotspot

2014-05-08 Thread Dave Pointon
Hi Erik , Thanx for that, bizarrely, I never even considered that JIRA might choose to apply a little re-formatting but it undoubtedly has. Anyway, I'm a not little uncertain of your assertion 'The problem then is that there will be no java launcher present to query for version information' -

Re: JDK-8037953 configure usability: Should provide better details on imported hotspot

2014-05-08 Thread Erik Joelsson
Hello, On 2014-05-08 13:55, Dave Pointon wrote: Hi Erik , Thanx for that, bizarrely, I never even considered that JIRA might choose to apply a little re-formatting but it undoubtedly has. Anyway, I'm a not little uncertain of your assertion 'The problem then is that there will be no java

Re: JDK-8037953 configure usability: Should provide better details on imported hotspot

2014-05-08 Thread Dave Pointon
Ah OK, thanx for the tip, Erik, never thought of that [building hotspot] either - my, oh my, what a weeks it's been ... and it's not over yet by a long chalk. I only asked because of the observation that David made and you re-iterated - I just wondered if there might be a properties file, or

Re: JDK9 build failure on Windows : javac OutOfMemoryError

2014-05-08 Thread Phil Race
Do we yet have a definitive answer to whether this is a javac bug or something that needs to be fixed in the build ? -phil. On 3/13/14 2:36 PM, Bradford Wetmore wrote: Phil, That looks exactly like my problem. http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012089.html Subject:

Re: RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

2014-05-08 Thread Mike Duigou
Ping. Still needing reviewers on this issue. I plan to push this change through the hotspot-rt repo. Mike On May 3 2014, at 20:24 , Mike Duigou mike.dui...@oracle.com wrote: Hello; Finally getting back to this issue I have done some cleanup and adjusted the hotspot gcc.make files to use

Re: RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

2014-05-08 Thread Vladimir Kozlov
Hotspot changes look good. Vladimir On 5/3/14 8:24 PM, Mike Duigou wrote: Hello; Finally getting back to this issue I have done some cleanup and adjusted the hotspot gcc.make files to use VARIANT rather than DEBUG_LEVEL. This version also add support for the -fsanitize=undefined undefined

RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-08 Thread Mike Duigou
Hello all; This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh concurrency). That changeset introduced use of fifos for monitoring sub-shell completion and included an alternative implementation for configurations which did not properly support fifos. This changeset detects

Re: RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

2014-05-08 Thread David Holmes
Hi Mike, This looks okay to me, but of course the proof is in the building and testing. David On 4/05/2014 1:24 PM, Mike Duigou wrote: Hello; Finally getting back to this issue I have done some cleanup and adjusted the hotspot gcc.make files to use VARIANT rather than DEBUG_LEVEL. This

Re: RFR: 8042810: (s) hgforest: some shells run read in sub-shell and can't use fifo

2014-05-08 Thread Chris Hegarty
Looks fine to me Mike. Trivially while you are there (not related to your changes), or i can do it separately, --sequentially now runs with up to two parallel commands. -Chris On 9 May 2014, at 03:19, Mike Duigou mike.dui...@oracle.com wrote: Hello all; This issue is a follow-on bug