Looks good to me Mike. Nice work!
/Erik
On 2014-05-13 01:53, Mike Duigou wrote:
Hello all;
I have updated the webrev after additional testing and cleanup. I found a
couple of additional minor problems and added a feature that had been
requested. Some of the default behaviour can now be contr
Thanks all - will make that change and push.
regards,
Sean.
On 13/05/2014 08:55, Erik Joelsson wrote:
Hello Seán,
I agree with Tomas, please fix the comment too. Also don't forget to
also push the closed generated-configure using the same bugid.
/Erik
On 2014-05-13 09:01, Tomas Hurka wrote
Hello Seán,
I agree with Tomas, please fix the comment too. Also don't forget to
also push the closed generated-configure using the same bugid.
/Erik
On 2014-05-13 09:01, Tomas Hurka wrote:
Hi Sean,
I guess that the “jdk7” text in following comment:
# When compiling code to be executed by t
On 12/05/2014 8:19 PM, pointo1d wrote:
On 12/05/14 10:50, David Holmes wrote:
Also this appears to need the x to be quoted "x"
+ if test "x$with_import_hotspot" != x; then
at least that is the normal pattern (it may not be strictly necessary).
Hmm, I was following, or attempting to follow
Hello,
No, not really. If you do "make jdk" (or just "make" which is the same),
demos aren't built. If you do "make images" or "make demos", the demos
are built. What is your usecase? If you don't need images, then you are
already skipping demos. If you need images, then demos will be built th
Hi Sean,
I guess that the “jdk7” text in following comment:
# When compiling code to be executed by the Boot JDK, force jdk7 compatibility.
should be changed to jdk8. It is on the line before “BOOT_JDK_SOURCETARGET”
change.
On 13 May 2014, at 00:22, Seán Coffey wrote:
> While adding some lam
