Naoto,
This looks better. Thanks for the update.
The getSupportedLocaleString method in both EnLocaleDataMetaInfo and
NonEnLocaleDataMetaInfo has the javadoc that missing the description.
sun.util.locale.provider is a package in java.base and
NonEnLocaleDataMetaInfo has to be in a different
On 28/08/2014 20:36, Phil Race wrote:
* All of the awt-related directories (libawt_* and common) include an
unnecessary extra layer, the "sun" directory. It is not needed anymore,
Let's *not* do that. It also affects the destination package.
Remember sun.* is the protected top-level package ..
On 8/28/2014 12:36 PM, Phil Race wrote:
* All of the awt-related directories (libawt_* and common) include an
unnecessary extra layer, the "sun" directory. It is not needed anymore,
Let's *not* do that. It also affects the destination package.
Remember sun.* is the protected top-level package .
* All of the awt-related directories (libawt_* and common) include an
unnecessary extra layer, the "sun" directory. It is not needed anymore,
Let's *not* do that. It also affects the destination package.
Remember sun.* is the protected top-level package .. and
people won't always be running in j
Thanks!
--
best regards,
Anthony
On 8/28/2014 1:00 PM, Magnus Ihse Bursie wrote:
On 2014-08-27 12:57, Anthony Petrov wrote:
Hi Magnus,
Those look like reasonable suggestions. Could you please file separate
bugs for each of these issues? Also, please note that most of them
belong to 2D, not AW
Thank you, Mandy, Masayoshi, and Alan for your comments. I revised the
changes based on your suggestions as follows:
http://cr.openjdk.java.net/~naoto/8038436/webrev.4/
Here are the changes since webrev.3
- CLDRLocaleProviderAdapter.java: modified to throw
UnsupportedOperationException with t
Looks good to me.
I agree with Erik that a comment describing the fix for the find/delete issue
would be good. Are other uses of FIND_DELETE problematic on AIX as well?
I wholeheartedly support all continued cleaning up of native files, and have
suggested this fix already. Erik has probably pu
Looks great!
Thank you for polishing this fix!
/Magnus
28 aug 2014 kl. 19:21 skrev Mandy Chung :
> On 8/27/14 11:38 PM, Erik Joelsson wrote:
>> Hello Mandy,
>>
>> That certainly looks better. A couple of more thoughts, and sorry for not
>> pointing this out earlier, but the new structure is s
On 8/27/14 11:38 PM, Erik Joelsson wrote:
Hello Mandy,
That certainly looks better. A couple of more thoughts, and sorry for
not pointing this out earlier, but the new structure is still new to
me too.
* The rmic targets also generate classes, so for modules.xml to be
correct, I suspect you
On 8/28/14 1:32 AM, Magnus Ihse Bursie wrote:
On 2014-08-27 18:00, Mandy Chung wrote:
Erik, Magnus,
This is much easier than I have thought. I really like this new build.
Glad to hear! :)
I have separated out Gendata-jdk.dev.gmk and removed the modules-xml
target completely.
Webrev at:
http
Hi Erik,
thanks for reviewing my change!
Please find my comments inline:
On Thu, Aug 28, 2014 at 5:56 PM, Erik Joelsson wrote:
> Hello Volker,
>
> Thanks for cleaning up!
>
>
> On 2014-08-28 17:22, Volker Simonis wrote:
>>
>> Hi,
>>
>> could somebody please review the following small changes to
Hello Volker,
Thanks for cleaning up!
On 2014-08-28 17:22, Volker Simonis wrote:
Hi,
could somebody please review the following small changes to fix the
AIX build after the Modular Source Code change 8054834. I've also done
a little cleanup which is detailed below:
http://cr.openjdk.java.net/
On 28 Aug 2014, at 16:22, Volker Simonis wrote:
>
> PS: I would also like to do some further cleanup in
> NetworkingLibraries.gmk in a follow-up change. I think now that we
> have all the corresponding directories in place we could rename
> {solaris,linux,bsd}_close.c to just close.c and move t
On 28/08/2014 16:22, Volker Simonis wrote:
:
PS: I would also like to do some further cleanup in
NetworkingLibraries.gmk in a follow-up change. I think now that we
have all the corresponding directories in place we could rename
{solaris,linux,bsd}_close.c to just close.c and move them to
$(JDK_T
Hi,
could somebody please review the following small changes to fix the
AIX build after the Modular Source Code change 8054834. I've also done
a little cleanup which is detailed below:
http://cr.openjdk.java.net/~simonis/webrevs/8056246/
https://bugs.openjdk.java.net/browse/JDK-8056246
make/lib/
On 2014-08-27 12:57, Anthony Petrov wrote:
Hi Magnus,
Those look like reasonable suggestions. Could you please file separate
bugs for each of these issues? Also, please note that most of them
belong to 2D, not AWT (e.g. the font-, color-, d3d-, and
opengl-related files) even though they're co
On 2014-08-27 18:00, Mandy Chung wrote:
Erik, Magnus,
This is much easier than I have thought. I really like this new build.
Glad to hear! :)
I have separated out Gendata-jdk.dev.gmk and removed the modules-xml
target completely.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/805
17 matches
Mail list logo
