Re: Review request JDK-8058367: Add verify-modules target to the default and images target

2014-09-12 Thread Phil Race
Looks good to me. -phil. On 9/12/2014 1:48 PM, Mandy Chung wrote: With the Modular Source Code [1] in JDK 9, the verify-modules target was added in the build to catch any regression to the module boundaries. It's important to catch this regression early during jdk development. This patch propos

Review request JDK-8058367: Add verify-modules target to the default and images target

2014-09-12 Thread Mandy Chung
With the Modular Source Code [1] in JDK 9, the verify-modules target was added in the build to catch any regression to the module boundaries. It's important to catch this regression early during jdk development. This patch proposes to add verify-modules to the default target and also images target

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-12 Thread Mandy Chung
On 9/12/14 7:03 AM, Erik Joelsson wrote: Hello, The checked in modules.list file defines the dependencies between modules for the build. The dependency information in this file is already captured in the modules.xml. Rather than keeping two copies of this information, with this change, module

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-12 Thread Tim Bell
Hi Erik: The checked in modules.list file defines the dependencies between modules for the build. The dependency information in this file is already captured in the modules.xml. Rather than keeping two copies of this information, with this change, modules.list is generated during the build.

Re: RFR (XS): 8058317: Top-level Makefiles uses deprecated target jvmg in HotSpot Makefiles

2014-09-12 Thread Tim Bell
Looks good to me as well. Tim On 09/12/14 08:17, Erik Joelsson wrote: Hello Erik, Looks good to me. Don't forget to also push the generated-configure.sh files. /Erik On 2014-09-12 17:05, Erik Helin wrote: Hi all, the top-level Makefiles are using the target jvm in the HotSpot Makefiles

Re: RFR (XS): 8058317: Top-level Makefiles uses deprecated target jvmg in HotSpot Makefiles

2014-09-12 Thread Erik Joelsson
Hello Erik, Looks good to me. Don't forget to also push the generated-configure.sh files. /Erik On 2014-09-12 17:05, Erik Helin wrote: Hi all, the top-level Makefiles are using the target jvm in the HotSpot Makefiles when configured with --debug-level=slowdebug. The jvmg target has been d

RFR (XS): 8058317: Top-level Makefiles uses deprecated target jvmg in HotSpot Makefiles

2014-09-12 Thread Erik Helin
Hi all, the top-level Makefiles are using the target jvm in the HotSpot Makefiles when configured with --debug-level=slowdebug. The jvmg target has been deprecated in the HotSpot Makefiles, the debug target should be used instead. This small patch changes jdk-options.m4 to use the debug targ

RFR: JDK-8058118: Generate modules.list during the build

2014-09-12 Thread Erik Joelsson
Hello, The checked in modules.list file defines the dependencies between modules for the build. The dependency information in this file is already captured in the modules.xml. Rather than keeping two copies of this information, with this change, modules.list is generated during the build. C