Re: i18n dev [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-20 Thread Alan Bateman
On 17/10/2014 23:31, Naoto Sato wrote: Hello, Please review the proposed changes to the following bug: https://bugs.openjdk.java.net/browse/JDK-8061382 The webrev is available at: http://cr.openjdk.java.net/~naoto/8061382/webrev.00/ This is mainly build changes to separate CLDR locale data

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-20 Thread Erik Joelsson
Hello Naoto, With this split, I would rather see GensrcCLDR.gmk be renamed Gensrc-jdk.localedata.cldr.gmk and have the all targets etc added to it. Then Gensrc-jdk.localedata.gmk should no longer include it. Ideally GensrcLocaleData.gmk would be inlined into Gensrc-jdk.localedata.gmk. Note

Re: RFR 8046002: Move Ucrypto to the open jdk repo

2014-10-20 Thread Erik Joelsson
Thanks, looks good. /Erik On 2014-10-18 01:48, Valerie Peng wrote: Ok, I have updated the Copy-java.base.gmk with your suggestion, i.e. folded the ifndef part into the previous ifeq. Webrev updated: http://cr.openjdk.java.net/~valeriep/8046002/webrev.02/ Thanks! Valerie On 10/16/2014 1:00

Re: OJDK on RHEL 6.5

2014-10-20 Thread Erik Joelsson
That looks strange. Could you look through configure.log and find the failing command line and output? Sometimes it's something else that actually fails the test. /Erik On 2014-10-19 21:44, Dave Pointon wrote: Hi all , Could you tell me if there's been a successful OJDK build on RHEL 6.5 -

Re: OJDK on RHEL 6.5

2014-10-20 Thread Stanislav Baiduzhyi
Hi, You could try downloading src.rpm file and checking the list of BuildRequires there, maybe it's some other package that is missing (even though configure shows exactly XTest.h): http://ftp.redhat.com/redhat/linux/enterprise/6Server/en/os/SRPMS/java-1.8.0-openjdk-1.8.0.25-1.b17.el6.src.rpm

RFR: JDK-8060766: build of jdk9-b33 seems broken due to how security zip files are interfaced

2014-10-20 Thread Erik Joelsson
Hello, Please review this small patch, fixing java compilation when crypto sources have been excluded and prebuilt. Bug: https://bugs.openjdk.java.net/browse/JDK-8060766 Patch inline: diff -r e4ba01b726e2 make/CompileJavaModules.gmk --- a/make/CompileJavaModules.gmk +++

Re: OJDK on RHEL 6.5

2014-10-20 Thread Dave Pointon
TFT Stanislav , You are the winner of the now why didn't I think of that award - config.log log shows ... In file included from conftest.c:28: /usr/include/X11/extensions/XTest.h:32:35: error: X11/extensions/XInput.h: No such file or directory which, when followed up by a whatprovides command

Re: OJDK on RHEL 6.5

2014-10-20 Thread Mario Torre
Not sure if you tried that as well, but there's an handy helper on RHEL: yum-builddep java-1.7.0-openjdk I thought I mentioned here for future references. The README-build.html mentions that as well, btw. As Stanislav also pointed installing the source RPM will bring all the buildtime deps.

Re: OJDK on RHEL 6.5

2014-10-20 Thread Dave Pointon
TFT MArio , Maybe it was just me, but I (obviously wrongly) expected it to be as smooth easy as it was for my original l/t build - which was ubuntu 12.04. -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly

Re: OJDK on RHEL 6.5

2014-10-20 Thread Mario Torre
2014-10-20 17:07 GMT+02:00 Dave Pointon point...@gmail.com: TFT MArio , Sure, np. Maybe it was just me, but I (obviously wrongly) expected it to be as smooth easy as it was for my original l/t build - which was ubuntu 12.04. The build system is the same for all distributions really

Re: RFR: JDK-8060766: build of jdk9-b33 seems broken due to how security zip files are interfaced

2014-10-20 Thread Tim Bell
Erik: Please review this small patch, fixing java compilation when crypto sources have been excluded and prebuilt. Bug: https://bugs.openjdk.java.net/browse/JDK-8060766 Patch inline: diff -r e4ba01b726e2 make/CompileJavaModules.gmk --- a/make/CompileJavaModules.gmk +++

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-20 Thread Naoto Sato
Thank you, Erik. Will incorporate your suggestions in the next webrev. As to inlining GensrcLocaleData.gmk, it is used not only in jdk.localedata, but also in java.base where English locale data is included. So it cannot be inlined into Gensrc-jdk.localedata.gmk. Naoto On 10/20/14, 12:54 AM,

Re: i18n dev [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-20 Thread Naoto Sato
On 10/20/14, 12:49 AM, Alan Bateman wrote: Will it eventually be possible to create a runtime that has the CLDR locale data but does not have the legacy JRE locale data? I'm assuming the CLDR does not have any dependences on the classes in the JRE locale data. Yes, that should be possible in

Re: RFR 8046002: Move Ucrypto to the open jdk repo

2014-10-20 Thread Phil Race
hudson builds are now failing as below. Did this change below break dev ? Compiling ec2_aff.c (for libsunec.so) /localtools/solaris-amd64/SUNWspro/SS12u3-Solaris10u6/SS12u3-slim/bin/cc -DTRACING -DMACRO_MEMSYS_OPS -DBREAKPTS -DcpuIntel -Di586 -Damd64 -D_LITTLE_ENDIAN= -DSOLARIS -DARCH='amd64'

Re: RFR 8046002: Move Ucrypto to the open jdk repo

2014-10-20 Thread David Holmes
On 21/10/2014 2:39 PM, Phil Race wrote: hudson builds are now failing as below. Did this change below break dev ? FYI this was already filed by RE: https://bugs.openjdk.java.net/browse/JDK-8061574 david Compiling ec2_aff.c (for libsunec.so)