Re: Excessive rebuilds of modules

2015-05-21 Thread Erik Joelsson
On 2015-05-20 22:39, Alan Bateman wrote: On 20/05/2015 21:12, Roger Riggs wrote: Ioi, You can rebuild just the contents of a single module: % make java.base java.base-libs java.base-launchers Yes, and this works great when you are using an exploded build. It's possible that Ioi is

JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Jan Lahoda
Hi, This is a patch adding a new option, -platform, to javac. Patch for the top-level repository is here: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.00/top-level/ Patch for the langtools repository is here: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.00/langtools/ These changes

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Erik Joelsson
Hello Jan, On the build changes there are some things I would like to change. * The creation of the ct.sym file should be done in a separate file, with a separate top level target. The images target should just be about linking and pulling things together, not actual building/compiling of

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Jan Lahoda
Hi Maurizio, Thanks for the comments. On 21.5.2015 12:31, Maurizio Cimadamore wrote: Hi Jan, great work - couple of comments below: * it seems like some of the routines in Arguments can be simplified using lambdas - especially lookupPlatformProvider and checkOptionAllowed Yes, I'll take a

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Erik Joelsson
On 2015-05-21 13:21, Magnus Ihse Bursie wrote: Hi Erik and Jan, Erik's modifications look much better to me. I'm just not entirerly satisfied with how this new symbolgenerator tool fits int our model. It's really a buildtool, similar to the other buildtools we have. First of all, the

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Jan Lahoda
Hi Magnus, On 21.5.2015 13:21, Magnus Ihse Bursie wrote: Hi Erik and Jan, Erik's modifications look much better to me. I'm just not entirerly satisfied with how this new symbolgenerator tool fits int our model. It's really a buildtool, similar to the other buildtools we have. First of all,

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Jan Lahoda
On 21.5.2015 14:14, Maurizio Cimadamore wrote: On 21/05/15 12:48, Jan Lahoda wrote: As an example, consider we would be currently storing data for 6, 7 and 8. We could have full 8 APIs stored, and then 8-7 diff and 7-6 diff. So the baseline for 7 would be 8 and the baseline for 6 would be 7.

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Maurizio Cimadamore
On 21/05/15 12:48, Jan Lahoda wrote: As an example, consider we would be currently storing data for 6, 7 and 8. We could have full 8 APIs stored, and then 8-7 diff and 7-6 diff. So the baseline for 7 would be 8 and the baseline for 6 would be 7. When the data for 9 would be added(*), we

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread mark . reinhold
2015/5/21 12:01 -0700, jan.lah...@oracle.com: This is a patch adding a new option, -platform, to javac. Patch for the top-level repository is here: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.00/top-level/ Patch for the langtools repository is here:

RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-21 Thread Roger Riggs
Please review these native code and build changes to clear compilation warnings. Most are due to mixing unsigned types with signed types or providing the correct type to an invoked function. Webrev: http://bussund0416.us.oracle.com/~rriggs/webrev/webrev-fix-all-warnings-8074818/ Issues:

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Maurizio Cimadamore
Hi Jan, great work - couple of comments below: * it seems like some of the routines in Arguments can be simplified using lambdas - especially lookupPlatformProvider and checkOptionAllowed * Why JDKPlatformProvider is not called JDKPlatformProvider*Factory* ? *

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Jan Lahoda
Hello Eric, Thanks a lot for your feedback and changes! I'll fold them into the patch. Thanks, Jan On 21.5.2015 11:42, Erik Joelsson wrote: Hello Jan, On the build changes there are some things I would like to change. * The creation of the ct.sym file should be done in a separate file,

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-21 Thread Magnus Ihse Bursie
Hi Erik and Jan, Erik's modifications look much better to me. I'm just not entirerly satisfied with how this new symbolgenerator tool fits int our model. It's really a buildtool, similar to the other buildtools we have. First of all, the location is not really ideal. Compare with how the

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-21 Thread Ivan Gerasimov
Hi Roger On 22.05.2015 0:09, Roger Riggs wrote: Please review these native code and build changes to clear compilation warnings. Most are due to mixing unsigned types with signed types or providing the correct type to an invoked function. The code changes look good! Webrev:

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-21 Thread Roger Riggs
Oops, got the wrong host: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fix-all-warnings-8074818/ Issues: 8074818: Resolve disabled warnings for libjava 8080007: Stop ignoring warnings for libjava Thanks, Roger On 5/21/15 8:34 PM, Ivan Gerasimov wrote: Hi Roger On 22.05.2015

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-21 Thread Mandy Chung
I’m including build-dev and we need to ask for Erik and Magnus advice what’s the best way to work around this. Erik, Magnus, Security providers now become service providers. They are provided from 11 different modules, 3 of them are os-specific. The current image builder doesn’t merge

Re: Excessive rebuilds of modules

2015-05-21 Thread Ioi Lam
On 5/21/15 12:05 AM, Erik Joelsson wrote: On 2015-05-20 22:39, Alan Bateman wrote: On 20/05/2015 21:12, Roger Riggs wrote: Ioi, You can rebuild just the contents of a single module: % make java.base java.base-libs java.base-launchers Yes, and this works great when you are using an