Re: dist-clean won't delete log files

2015-06-03 Thread Magnus Ihse Bursie
On 2015-06-03 19:14, Dan Smith wrote: My understanding is that given a properly configured 'dist-clean' will behave as noted: rm -r build sh configure make dist-clean find build -mindepth 1 # no output However, instead I get 3 files: build/macosx-x86_64-normal-server-release

Re: Request for guidance on fixing JDK-8075571: Support tier1 and tier2 make targets

2015-06-03 Thread Jonathan Gibbons
Joe, These lines in langtools/test/TEST.groups look like they belong, with appropriate tweaking, in langtools/test/Makefile 37 # Support for invoking tiered testing via the Makefile 38 #langtools_tier1 = :tier1 39 #langtools_tier2 = :tier2 40 #langtools_tier3 = :tier3 Or more

Re: Solaris jdk9 build problem

2015-06-03 Thread David Holmes
On 2/06/2015 11:50 PM, Magnus Ihse Bursie wrote: On 2015-06-02 15:21, Semyon Sadetsky wrote: Hello, Hate to disturb you again but I got yet another show stopper for my Solaris build: Generating solaris_amd64_docs/jvmti.html Creating libverify.so from 2 file(s) Creating libjava.so from 60

Re: official compiler for Solaris jdk9 build?

2015-06-03 Thread Semyon Sadetsky
On 6/3/2015 11:28 AM, Magnus Ihse Bursie wrote: On 2015-06-02 17:27, Semyon Sadetsky wrote: Hi, I'm trying to build jdk9 under the current Solaris 11.2 version. Which version of the Solaris Studio should be installed for that? The readme-builds states: ... At a minimum, the Studio 12 Update

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-06-03 Thread Magnus Ihse Bursie
On 2015-06-02 18:50, Jan Lahoda wrote: Hello Eric, Thanks for the change, this seems definitely better to me. I've folded your change that into my patch. An updated version (just langtools this time): http://cr.openjdk.java.net/~jlahoda/8072480/webrev.04/langtools/ Thanks! From a build

Re: official compiler for Solaris jdk9 build?

2015-06-03 Thread Magnus Ihse Bursie
On 2015-06-02 17:27, Semyon Sadetsky wrote: Hi, I'm trying to build jdk9 under the current Solaris 11.2 version. Which version of the Solaris Studio should be installed for that? The readme-builds states: ... At a minimum, the Studio 12 Update 1 Compilers (containing version 5.10 of the C

Re: RFR: JDK-8081692 Configure should verify that -fstack-protector is valid

2015-06-03 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 06/03/15 06:12, Erik Joelsson wrote: Looks good to me. /Erik On 2015-06-03 14:33, Magnus Ihse Bursie wrote: Not all versions of gcc support -fstack-protector. We should check that it is accepted as an argument before adding it to the flags. Bug:

RFR: JDK-8081692 Configure should verify that -fstack-protector is valid

2015-06-03 Thread Magnus Ihse Bursie
Not all versions of gcc support -fstack-protector. We should check that it is accepted as an argument before adding it to the flags. Bug: https://bugs.openjdk.java.net/browse/JDK-8081692 WebRev inline: diff --git a/common/autoconf/flags.m4 b/common/autoconf/flags.m4 ---

Re: RFR: JDK-8081692 Configure should verify that -fstack-protector is valid

2015-06-03 Thread Erik Joelsson
Looks good to me. /Erik On 2015-06-03 14:33, Magnus Ihse Bursie wrote: Not all versions of gcc support -fstack-protector. We should check that it is accepted as an argument before adding it to the flags. Bug: https://bugs.openjdk.java.net/browse/JDK-8081692 WebRev inline: diff --git

dist-clean won't delete log files

2015-06-03 Thread Dan Smith
My understanding is that given a properly configured 'dist-clean' will behave as noted: rm -r build sh configure make dist-clean find build -mindepth 1 # no output However, instead I get 3 files: build/macosx-x86_64-normal-server-release build/macosx-x86_64-normal-server-release/build.log

Re: need to build a DLL for an openjdk test

2015-06-03 Thread David Holmes
On 4/06/2015 12:33 PM, Pete Brunet wrote: On 6/3/15 8:43 PM, Pete Brunet wrote: Cross posting to build-dev for possible insight regarding Jon's last paragraph below. On 6/3/15 8:13 PM, Jonathan Gibbons wrote: On 06/03/2015 04:27 PM, Pete Brunet wrote: Hi, As part of my test I need to build

Re: RFR: JDK-8081692 Configure should verify that -fstack-protector is valid

2015-06-03 Thread David Holmes
Magnus, You missed the hotspot side of this: ./solaris/makefiles/gcc.make: DEBUG_CFLAGS += -fstack-protector-all --param ssp-buffer-size=1 ./bsd/makefiles/gcc.make:DEBUG_CFLAGS += -fstack-protector-all --param ssp-buffer-size=1 ./linux/makefiles/gcc.make:DEBUG_CFLAGS +=

Re: need to build a DLL for an openjdk test

2015-06-03 Thread Pete Brunet
On 6/3/15 8:43 PM, Pete Brunet wrote: Cross posting to build-dev for possible insight regarding Jon's last paragraph below. On 6/3/15 8:13 PM, Jonathan Gibbons wrote: On 06/03/2015 04:27 PM, Pete Brunet wrote: Hi, As part of my test I need to build a simple DLL and then load it from my

Re: need to build a DLL for an openjdk test

2015-06-03 Thread David Holmes
Peter, On 4/06/2015 11:43 AM, Pete Brunet wrote: Cross posting to build-dev for possible insight regarding Jon's last paragraph below. See jdk/make/test/JtregNative.gmk and other references to test-image. David On 6/3/15 8:13 PM, Jonathan Gibbons wrote: On 06/03/2015 04:27 PM, Pete

need to build a DLL for an openjdk test

2015-06-03 Thread Pete Brunet
Cross posting to build-dev for possible insight regarding Jon's last paragraph below. On 6/3/15 8:13 PM, Jonathan Gibbons wrote: On 06/03/2015 04:27 PM, Pete Brunet wrote: Hi, As part of my test I need to build a simple DLL and then load it from my test class. Can jtreg build the DLL or will

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-03 Thread Valerie (Yu-Ching) Peng
Correct, if the makefile related changes are removed then no need for build team to review 7191662 webrev anymore. There are other discussions ongoing and we should be able to reach a decision in a day or two. Will update the list again. Thanks, Valerie On 06/01/15 16:39, Magnus Ihse Bursie