Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level:

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik > wrote: > > Updated webrevs: > > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk > This looks fine to me. Is there any test referencing

Re: Building open jdk 8 from source fails

Sorry not enough information. Which forest did you try to build? What platform? What was the error? What boot JDK did you use? ... Regards, David On 26/11/2015 12:21 PM, Sunbo (Bb) wrote: I have the same build error as lee json. I add "import static

Building open jdk 8 from source fails

I have the same build error as lee json. I add "import static com.sun.tools.javac.parser.Tokens.Token;" code to fix this error. Who can tell me why? package com.sun.tools.javac.parser; import com.sun.tools.javac.code.Source; import com.sun.tools.javac.parser.Tokens.Comment.CommentStyle; import

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right. there might be an expectation on interop

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level:

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

On 2015-11-21 14:12, Yasumasa Suenaga wrote: My point with current proposal is that either it doesn't touch the zipping because we already have an option for that; or it should deprecate the existing option (now Erik has pointed out that capability). I'm using BASIC_DEPRECATED_ARG_ENABLE for

Re: RFR: JDK-8144039: Enable javac server by default

Hi Erik, Magnus, Has this been extensively tested with all our build environments? It's been a while so could you give an overview of exactly how the sjavac thing works. Changes that affect every single person building the JDK should not be rushed through! Thanks, David On 26/11/2015

Re: RFR: JDK-8144039: Enable javac server by default

On 2015-11-25 15:45, Erik Joelsson wrote: Doh, here you go: diff -r 358fb90ae6e6 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -411,9 +411,9 @@ AC_MSG_RESULT([$ENABLE_SJAVAC]) AC_SUBST(ENABLE_SJAVAC) -

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

Hi Magnus, --with-java-debug-symbols=none,all (or "none,internal" for consistency). Can I change this option to --enable-java-debug-symbols ? This value set to none or all. So I think that we should use AC_ARG_ENABLE for it. Thanks, Yasumasa On 2015/11/25 23:35, Magnus Ihse Bursie

Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

The fix looks fine to me. For testing, can you create a test that uses a custom java.security file with "#ifndef solaris-sparc" in it, and check whether the property is used or not depending on what system is being tested? --Sean On 11/24/2015 06:10 AM, Magnus Ihse Bursie wrote: On

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 10:28, Jaroslav Bachorik wrote: On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue :

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk This

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 10:02, Alan Bateman wrote: On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk:

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right.

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25/11/2015 08:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level:

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

> On 24 nov. 2015, at 17:03, Jaroslav Bachorik > wrote: > > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 > Webrevs: > * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top > * jdk:

Re: RFR: JDK-8144039: Enable javac server by default

Doh, here you go: diff -r 358fb90ae6e6 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -411,9 +411,9 @@ AC_MSG_RESULT([$ENABLE_SJAVAC]) AC_SUBST(ENABLE_SJAVAC) - AC_ARG_ENABLE([javac-server],

RFR: JDK-8144039: Enable javac server by default

Hello, The --enable-javac-server feature seems to be working well and is providing considerable speedup when building the JDK. We should make the option enabled by default. As an example, on my local machine, a run of "make exploded-image" without javac server took 00:04:09 and with javac

Re: RFR: JDK-8144039: Enable javac server by default

On 2015-11-25 15:11, Erik Joelsson wrote: Hello, The --enable-javac-server feature seems to be working well and is providing considerable speedup when building the JDK. We should make the option enabled by default. As an example, on my local machine, a run of "make exploded-image" without