[RFR] (XS) 8144677: jprt.properties should allow creating a user specified testset with custom build flavors and build targets

2015-12-04 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8144677 http://cr.openjdk.java.net/~cjplummer/8144677/webrev.01/webrev/ Tested with JPRT with: • "-testset hotspot" • "-testset svc" • "-testset chris" from the example custom testset provided in the CR. • no t

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Erik Joelsson
On 2015-12-04 14:42, Erik Joelsson wrote: On 2015-12-04 12:50, Magnus Ihse Bursie wrote: 144 * // For certain dependencies where a legacy distribution mechanism is 145 * // already i place, the "javare" server layout is also supported "in place". Also, missing period. 150

Re: Running native code test

2015-12-04 Thread Carsten Varming
Dear Steffan, On Fri, Dec 4, 2015 at 2:20 AM, Staffan Larsen wrote: > Why is it a problem having executables and libraries in the same > directory? It was a design choice we made to make things simpler. It is a consistency problem. There would be no problem if this was the common case, but it

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Erik Joelsson
On 2015-12-04 12:50, Magnus Ihse Bursie wrote: Comments inline. I see. I'm fine with this. Just one note, if you had jab_url=$jab_server/$data_string, maybe this should be more obvious. And it's a nice bit of DRY. Sure, seems reasonable. 144 * // For certain dependencies where a l

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Erik Joelsson
On 2015-12-04 12:33, Magnus Ihse Bursie wrote: Just a quick reply, I haven't looked at the new webrev yet. 4 dec. 2015 kl. 10:57 skrev Erik Joelsson : I'm a bit curious why this fix was needed. I thought one of the idea with BASIC_FIXUP_PATH was to guarantee that we pointed to an existing d

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Magnus Ihse Bursie
Comments inline. > 4 dec. 2015 kl. 10:58 skrev Erik Joelsson : > > Forgot the link > http://cr.openjdk.java.net/~erikj/8136782/webrev.top.02/ > >> On 2015-12-04 10:57, Erik Joelsson wrote: >> New webrev: >> On 2015-12-03 22:01, Magnus Ihse Bursie wrote: On 2015-12-03 16:27, Erik Joel

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Magnus Ihse Bursie
Just a quick reply, I haven't looked at the new webrev yet. 4 dec. 2015 kl. 10:57 skrev Erik Joelsson : >> I'm a bit curious why this fix was needed. I thought one of the idea with >> BASIC_FIXUP_PATH was to guarantee that we pointed to an existing directory? > The documentation only says path,

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Erik Joelsson
Forgot the link http://cr.openjdk.java.net/~erikj/8136782/webrev.top.02/ On 2015-12-04 10:57, Erik Joelsson wrote: New webrev: On 2015-12-03 22:01, Magnus Ihse Bursie wrote: On 2015-12-03 16:27, Erik Joelsson wrote: Hello, This patch adds support for a new Oracle internal tool that will hel

Re: RFR: JDK-8136782: Introduce a build/configure wrapper

2015-12-04 Thread Erik Joelsson
New webrev: On 2015-12-03 22:01, Magnus Ihse Bursie wrote: On 2015-12-03 16:27, Erik Joelsson wrote: Hello, This patch adds support for a new Oracle internal tool that will help us manage build configurations. I doubt it could be of any use to outside users, except perhaps to give a bit of i

Re: RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling

2015-12-04 Thread David Holmes
On 4/12/2015 4:29 AM, Alexander Smundak wrote: On Wed, Dec 2, 2015 at 10:30 PM, David Holmes wrote: agent code: I'm still unclear why you can't, or shouldn't, pass through -Dppc64 and -Dppc64le, such that you don't need to check for either being defined ?? You mean, add -Dppc64 to the compila