Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Mandy Chung
> On Sep 30, 2016, at 7:06 AM, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ > This change looks good. It’s a good speedup. Thanks for cleaning up the duplicated TOOL_GENGRAPHS and TOOL_MODULESUMMARY definition. Mandy

RFR: JDK-8166965: Some small java build tools are still running with big JVM configuration

2016-09-30 Thread Erik Joelsson
A while back, we introduced the JAVA_SMALL configuration in the build, which improved build performance and reduced resource usage for several small java instances. However, it was never fully applied to all command lines where it would fit. I have looked through the entire build and measured

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 15:06, Erik Joelsson wrote: Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ Looks okay.

Re: RFR: 8166790: Add stress test GCBasher

2016-09-30 Thread Dmitry Fazunenko
Hi Erik, The change looks good, thank you for doing that fix. -- Dima On 28.09.2016 18:01, Erik Helin wrote: Hi all, this patch adds a new GC stress test called GCBasher. GCBasher builds up large (well, for some definiton of large) object graphs by figuring out the relations between classes i

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ /Erik On 2016-09-30 10:03, Erik Joelsson wrote: During the build proces

Re: RFR: 8166790: Add stress test GCBasher

2016-09-30 Thread Leonid Mesnik
Hi I think that it would be better to split this test into 4 tests. Currently this test is going to be skipped if any specific GCare set. Or it could even fail if any G1 specific options is set without setting G1 explicitly. So there is no way to run this with additional G1/CMS/ParGC specifi

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
On 2016-09-30 12:06, Alan Bateman wrote: On 30/09/2016 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is a

RFR: JDK-8150736: Excessive disk space used by build system

2016-09-30 Thread Erik Joelsson
Here is a rather large patch which should make life better for most people building and developing OpenJDK. The main goal of this patch is to reduce unnecessary space used by the build. A side goal also become to figure out a better general strategy for handling native debug info during the bui

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Chris Hegarty
On 30/09/16 10:47, Alan Bateman wrote: On 30/09/2016 10:43, Chris Hegarty wrote: ... Additionally, do you want to run with --add-modules java.se.ee to include the 6 "EE" modules? Not needed as the tool adds the class file attribute to every module-info.class in jdk/modules/*. Ah ok, go it. T

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick b

Re: RFR for JDK-8165482 java in ldoms, with cpu-arch=generic has problems

2016-09-30 Thread Martin Walsh
On 23/09/2016 14:34, Martin Walsh wrote: On 20/09/2016 08:42, Erik Joelsson wrote: Hello, On 2016-09-20 03:28, David Holmes wrote: Hi Martin, Build changes must be reviewed by the build team - now cc'd Thanks for forwarding David, I can't keep up with all the lists to find these unless pos

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 10:43, Chris Hegarty wrote: Ooh, this is quite clever, levering the already computed packages list from the running VM to add the packages attribute to the module info. One minor concern ( which I think should be ok ) is the updating of the module-info.class files of the running

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Chris Hegarty
On 30/09/16 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick build-

RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick build-test cycle since the exploded image is