Hi Christian,
I think you need to pass an absolute directory, in which all the custom
files, regardless of repo, are located. That is essentially how we use
it - jdk/make/closed has files included from other repos. Of course that
only works if names are unique.
David
On 4/03/2017 9:11 AM, R
Hi Christian,
I'm cc'ing build-dev (and bcc'ing jdk8u-dev) as that may be a more appropriate
venue for this discussion.
-Rob
On 03/03/17 10:19, Christian Thalinger wrote:
> At Twitter we are using the custom extension mechanism to separate our
> additional code from upstream in order to min
Creating some other makefiles was not planned as a part of this JEP, Phil.
If the demos are used for testing, do you want me do turn them into manual
tests?
Shura
> On Mar 3, 2017, at 2:45 PM, Phil Race wrote:
>
> And to be clear, the provision for still building these client demos needs to
And to be clear, the provision for still building these client demos
needs to be made BEFORE this is pushed.
Or at least as *part* of this push.
Else we will be unable to perform our normal integration testing at this
critical juncture of JDK 9 ..
-phil.
On 03/03/2017 09:39 AM, Phil Race wrot
What is the plan for ensuring there is still a way to build the client
demos - which are not being removed
but just moved. Doesn't this makefile need to be somewhere still ?
-phil.
On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
Hi,
Could y
Looks good to me now.
/Erik
On 2017-03-03 10:39, Magnus Ihse Bursie wrote:
I have an updated webrev.
Here is a differential webrev showing the changes compared to the
previous webrev:
http://cr.openjdk.java.net/~ihse/JDK-8176084-introduce-run-test/webrev.02
And here is a full webrev showin
I have an updated webrev.
Here is a differential webrev showing the changes compared to the
previous webrev:
http://cr.openjdk.java.net/~ihse/JDK-8176084-introduce-run-test/webrev.02
And here is a full webrev showing all changes:
http://cr.openjdk.java.net/~ihse/JDK-8176084-introduce-run-test/
On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
Hi,
Could you be so kind to review suggested changes for the makefiles to stop
producing sales and demos bundle. Pls note that this request only changes the
makefiles, it does not remove demos and samples source code, which will be done
sepa
