Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

Looks good. /Erik On 2017-12-18 23:41, mark.reinh...@oracle.com wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ You can set COMPANY_NAME in make/autoconf/version-numbers, but you can't set it when configuring a build, so it's im

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

On Mon, Dec 18, 2017 at 3:50 PM, wrote: > 2017/12/18 15:36:03 -0800, Martin Buchholz : > > Mark, thanks for implementing my little feature request. Looks good to > me. > > I didn't know you'd requested this -- is there an existing issue? > https://bugs.openjdk.java.net/browse/JDK-8189761

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017/12/18 15:36:03 -0800, Martin Buchholz : > Mark, thanks for implementing my little feature request. Looks good to me. I didn't know you'd requested this -- is there an existing issue? - Mark

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 18 Dec 2017, at 17:52, David Holmes wrote: > > On 19/12/2017 11:42 AM, Paul Sandoz wrote: >> Looks good to me. >> I am including HS dev for the class file version changes: >> http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ >> http://cr.openjdk.java.net/~psando

Re: RFR: 8192837 Need new test for release file info

Hi Randy, jdk/sanity/Test8192837.java We don't name tests with bug numbers any more - the file/class should be renamed to something appropriate to its actual function. 64 // grab the line 65 if (readIn.startsWith("SOURCE=")) 66 fishFor

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

On 19/12/2017 11:42 AM, Paul Sandoz wrote: Looks good to me. I am including HS dev for the class file version changes: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version-build-changes/webrev/ We ca

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Thanks Paul. I'm doing final checks and preparations of fixes to JDK-8173382: Add -source 11 and -target 11 to javac JDK-8193291: Add SourceVersion.RELEASE_11 and expect to push shortly. Cheers, -Joe On 12/18/2017 5:42 PM, Paul Sandoz wrote: Looks good to me. I am including HS dev

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Looks good to me. I am including HS dev for the class file version changes: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-class

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hello, A follow-up on defining a final field RELEASE_CURRENT as an alias for the latest SourceVersion constant to allow easier updating of annotations using SourceVersion constants. Somewht surprisingly, this is not legal Java code; an annotation must use an enum constant directly and not a

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

Mark: Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ Looks good. Tim

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

Mark, thanks for implementing my little feature request. Looks good to me. Aside: we only support running configure under bash, but as a result the configure script is now a strange mixture of bashisms and 1980-isms. On Mon, Dec 18, 2017 at 2:41 PM, wrote: > Bug: https://bugs.openjdk.java.net/

10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ You can set COMPANY_NAME in make/autoconf/version-numbers, but you can't set it when configuring a build, so it's impossible to change the value of IMPLEMENTOR in the $JAVA_HOME/release file w

Re: RFR: 8192837 Need new test for release file info

Redirecting to correct list. The test seems to do what it set out to do. /Erik On 2017-12-18 17:55, Randy Crihfield wrote: I have created an OpenJDK negative test that confirms the closed source files are not included in the SOURCE. Version of the actual test for review: http://cr.openjdk.

RFR: 8193686: Allow --with-jtreg to accept a zip compressed jtreg image

Hi all, here is small patch that allows the configure option --with-jtreg to accept a zip compressed jtreg image (the option currently accepts a jtreg image directory). The jtreg image will be unpacked into $CONFIGURE_SUPPORT/jtreg. Patch: http://cr.openjdk.java.net/~ehelin/8193686/00/ Issu