On 2018-05-08 00:35, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/index.html
45710 lines changed: 45710 ins; 0 del; 0 mod;
Hi all,
could you please review the patch which open sources GC tests from vm testbase?
it introduces the following test groups:
- vmTestb
Hi Eric,
thanks for that excellent suggestion. I already thought there should be some
means to do that but was not aware of how that could be accomplished. I updated
the webrev in place.
Thanks
Christoph
> -Original Message-
> From: Erik Joelsson [mailto:erik.joels...@oracle.com]
> Sen
Hi Rob,
I can file a bug and follow the approval process and get it pushed.
First, I'd like to know whether:
A. An action needs to be taken at all? I assume yes, but just making
sure.
B. Contributors outside Oracle can push generated-configure.sh changes?
I seem to remember that
Hi all,
I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following:
```
[ysuenaga@fc28 jdk]$ make images
Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug'
gmake[3]: *** [GenerateLinkOptData.gmk:64:
/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64
Erik:
With the new VS2017 toolchain Microsoft has changed how the C++
libraries work. In addition to the old msvcr* and msvcp* dll files, we
now have a big lot of UCRT dlls as well. These files are also
redistributable but are found in the Windows Kit rather than the Visual
Studio installation.
No, you're correct. The closed changes do need to be handled by someone
in Oracle so it makes sense to get an Oracle committer to push.
So:
A. Yes.
B. You're absolutely right. I'll take care of the push once you've got
the change codereviewed / approved for push.
Thanks,
-Rob
On 08/05/18 1
Hi,
On Tue, 2018-05-08 at 15:20 +0100, Rob McKenna wrote:
> No, you're correct. The closed changes do need to be handled by someone
> in Oracle so it makes sense to get an Oracle committer to push.
>
> So:
>
> A. Yes.
> B. You're absolutely right. I'll take care of the push once you've got
> the
See below-
On 05/08/18 07:39, Severin Gehwolf wrote:
Hi,
On Tue, 2018-05-08 at 15:20 +0100, Rob McKenna wrote:
No, you're correct. The closed changes do need to be handled by someone
in Oracle so it makes sense to get an Oracle committer to push.
So:
A. Yes.
B. You're absolutely right. I'll
Please note that Severin mistakenly pushed just the .m4 change here:
http://hg.openjdk.java.net/jdk-updates/jdk10u/rev/2f8a4aafe85f
We now need another bugid for pushing just a new generated-configure.sh.
This needs to be pushed to both open and closed. To generate it, just do
"bash closed/mak
Build change looks good.
/Erik
On 2018-05-08 02:54, Langer, Christoph wrote:
Hi Eric,
thanks for that excellent suggestion. I already thought there should be some
means to do that but was not aware of how that could be accomplished. I updated
the webrev in place.
Thanks
Christoph
-Or
Hello,
Your assessment is looks correct so far. At this point, one would have
to start debugging the image to figure out what's wrong with it. Are you
able to run the exploded image in
./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java?
Has anyone at Redhat built successfully on Fedor
On Tue, 2018-05-08 at 08:21 -0700, Erik Joelsson wrote:
> Please note that Severin mistakenly pushed just the .m4 change here:
>
> http://hg.openjdk.java.net/jdk-updates/jdk10u/rev/2f8a4aafe85f
>
> We now need another bugid for pushing just a new generated-configure.sh.
> This needs to be pushed
On Tue, 2018-05-08 at 22:42 +0900, Yasumasa Suenaga wrote:
> Hi all,
>
> I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as
> following:
>
> ```
> [ysuenaga@fc28 jdk]$ make images
> Building target 'images' in configuration
> 'linux-x86_64-normal-server-fastdebug'
> gmake[3]:
On Tue, 2018-05-08 at 08:27 -0700, Erik Joelsson wrote:
> Hello,
>
> Your assessment is looks correct so far. At this point, one would have
> to start debugging the image to figure out what's wrong with it. Are you
> able to run the exploded image in
> ./build/linux-x86_64-normal-server-fastdeb
> On May 7, 2018, at 11:20 AM, B. Blaser wrote:
>
> On 7 May 2018 at 14:19, B. Blaser wrote:
>> On 6 May 2018 at 18:35, B. Blaser wrote:
>>> On 5 May 2018 at 22:26, Kim Barrett wrote:
> On May 5, 2018, at 8:03 AM, B. Blaser wrote:
>
> On 4 May 2018 at 17:42, Alan Bateman wrote:
Erik, Magnus, thank you for reviewing build change.
can someone from GC people Review the rest?
-- Igor
> On May 8, 2018, at 2:06 AM, Magnus Ihse Bursie
> wrote:
>
> On 2018-05-08 00:35, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/index.html
>>> 45710 lines
Hi
Please review this change open sourcing vm testbase stress tests. These tests
have been developed a long time ago for internal test harness and don't looks
very nice now.
They are open sourced with minimal changes only. The long term plan is to
review and improve them moving out of vmTestbas
Build changes look good.
/Erik
On 2018-05-08 14:23, Leonid Mesnik wrote:
Hi
Please review this change open sourcing vm testbase stress tests. These tests
have been developed a long time ago for internal test harness and don't looks
very nice now.
They are open sourced with minimal changes o
Hi,
2018-05-09 0:27 GMT+09:00 Erik Joelsson :
> Hello,
>
> Your assessment is looks correct so far. At this point, one would have to
> start debugging the image to figure out what's wrong with it. Are you able
> to run the exploded image in
> ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/ja
Can you build with LOG=trace to try and see the actual command that is
failing?
David
On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote:
Hi,
2018-05-09 0:27 GMT+09:00 Erik Joelsson :
Hello,
Your assessment is looks correct so far. At this point, one would have to
start debugging the image to fi
Hi David,
2018-05-09 10:48 GMT+09:00 David Holmes :
> Can you build with LOG=trace to try and see the actual command that is
> failing?
I tried it and got following logs. They look good to me.
* Creating interim-image
+
/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk
On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote:
Hi David,
2018-05-09 10:48 GMT+09:00 David Holmes :
Can you build with LOG=trace to try and see the actual command that is
failing?
I tried it and got following logs. They look good to me.
Not enough there for me to comment :)
* Creating inte
Hi David,
I uploaded build.log:
http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log
Is it enough?
Thanks,
Yasumasa
2018-05-09 11:17 GMT+09:00 David Holmes :
> On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote:
>>
>> Hi David,
>>
>> 2018-05-09 10:48 GMT+09:00 David Holmes :
>>>
>>> Can
Hi all,
could we add .git to .hgignore?
Bug: https://bugs.openjdk.java.net/browse/JDK-8202822
Diff:
--- a/.hgignore Wed May 09 06:51:41 2018 +0200
+++ b/.hgignore Wed May 09 06:55:10 2018 +0200
@@ -13,3 +13,4 @@
NashornProfile.txt
.*/JTreport/.*
.*/JTwork/.*
+.*/.git/.*
Thanks!
Thomas
Hi,
sorry for quick dropping in. Just wanted to remark that it may be
useful to run with --with-build-jdk= with being a good working
jdk you trust. It must be close to the source you build - I usually
use a clean current release build.
This excludes build errors which may be caused by the JDK y
On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote:
Hi David,
I uploaded build.log:
http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log
Is it enough?
It's all there is. :) But no errors. It all is fine right up to the part
that it isn't.
Can you run:
/home/ysuenaga/OpenJDK/jdk/build/
26 matches
Mail list logo
