Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Mandy Chung
Hi Severin, Another alternative would be to support per-jlink-plugin resource bundle to avoid merging .properties files at build time.  The plugin-specific messages should only be used by the plugin itself and it would be cleaner for each plugin to manage its resource bundle. Mandy On 1/25/19 7

RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-25 Thread Alexandre (Shura) Iline
Hi, Please take a look on a change to allow JCov test execution through jib. Please notice that this fix also changes behavior of RunTest.gmk when conflicting combination of options is used. JCOV_IMAGE_DIR is now expected to be set when TEST_OPTS_JCOV is true. Shura Bug: https://bugs.openjdk

Re: Failure at rung of get_source on windows with cygwin

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 22:12, Simonovsky, Pavel wrote: Hi. I am attempting to build Open jdk 8u from sources. At Linux (RH6 it worked smoothly. At windows I am trying to build using Cygwin version 2.8... I am failing at windows build on step of running get_source.sh: nashorn: abort: str

Configure "developer mode" [was: Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain]

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 18:15, Martin Buchholz wrote: In our own wrappers around configure, we've introduced the concept of a "developer mode". But this thread suggests there are 3 populations of users invoking configure: 1. release engineers 2. hotspot developers 3. java library developers Category 1 d

Failure at rung of get_source on windows with cygwin

2019-01-25 Thread Simonovsky, Pavel
Hi. I am attempting to build Open jdk 8u from sources. At Linux (RH6 it worked smoothly. At windows I am trying to build using Cygwin version 2.8... I am failing at windows build on step of running get_source.sh: nashorn: abort: stream ended unexpectedly (got 1297 bytes, expected

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Martin Buchholz
On Fri, Jan 25, 2019 at 10:07 AM Andrew Haley wrote: > > On 1/25/19 5:01 PM, Martin Buchholz wrote: > > I re-ran my linker performance experiment using configure > > --with-native-debug-symbols="internal" > > lld is a big winner here: > > It looks to me like lld and multi-threaded gold would be a

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Andrew Haley
On 1/25/19 5:01 PM, Martin Buchholz wrote: > I re-ran my linker performance experiment using configure > --with-native-debug-symbols="internal" > lld is a big winner here: It looks to me like lld and multi-threaded gold would be a near tie. I think that lld uses multi-threading; I wonder why gold

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Philip Race
Category 3 has to deal with plenty of native code too ... -phil On 1/25/19, 9:15 AM, Martin Buchholz wrote: In our own wrappers around configure, we've introduced the concept of a "developer mode". But this thread suggests there are 3 populations of users invoking configure: 1. release engine

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Erik Joelsson
Hello Severin, To get the conditional running of either MergeProperties or copy, I would do something like this: $$($1_TARGET): $$($1_DEPS) $$(call MakeTargetDir) ifneq ($$($1_NUM_INPUT_FILES),1) $$(call LogInfo, Merging $$(words $$($1_INPUT_FILES)) properties files into a sin

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Martin Buchholz
In our own wrappers around configure, we've introduced the concept of a "developer mode". But this thread suggests there are 3 populations of users invoking configure: 1. release engineers 2. hotspot developers 3. java library developers Category 1 doesn't care about edit-compile-debug cycle - t

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Andrew Haley
On 1/25/19 4:45 PM, Magnus Ihse Bursie wrote: > On 2019-01-25 16:42, Andrew Haley wrote: >> On 1/24/19 2:04 PM, Magnus Ihse Bursie wrote: >>> But I'm leaning more towards just enabling gold on x86_64 -- for other >>> platforms, we might as well keep the good ol' bfd linker. Does that >>> sound like

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Martin Buchholz
I re-ran my linker performance experiment using configure --with-native-debug-symbols="internal" lld is a big winner here: --- ld=bfd --- /usr/bin/g++ -fuse-ld=$ld -Wl,--hash-style=both -Wl,-z,defs -Wl,-z,noexecstac 7.30s user 1.26s system 99% cpu 8.559 total /usr/bin/g++ -fuse-ld=$ld -Wl,--hash

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 16:27, Severin Gehwolf wrote: Hi, I'm working on an enhancement for jlink. In particular a platform specific plugin. I.e. It would only get built on unix/linux platforms. My trouble is getting some resouce properties set up properly. In my example there is two versions of plugin

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 16:42, Andrew Haley wrote: On 1/24/19 2:04 PM, Magnus Ihse Bursie wrote: But I'm leaning more towards just enabling gold on x86_64 -- for other platforms, we might as well keep the good ol' bfd linker. Does that sound like a good solution to you? I'd love it to be an option for AA

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Andrew Haley
On 1/24/19 2:04 PM, Magnus Ihse Bursie wrote: > But I'm leaning more towards just enabling gold on x86_64 -- for other > platforms, we might as well keep the good ol' bfd linker. Does that > sound like a good solution to you? I'd love it to be an option for AArch64. -- Andrew Haley Java Platfo

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Andrew Haley
On 1/25/19 2:39 PM, Andrew Haley wrote: > Massive win for gold here, on my (very old) AArch64 system: And on another, faster AArch64 system: BFD linker: real0m14.532s user0m13.070s sys 0m1.419s gold, single-threaded: real0m6.313s user0m6.123s sys 0m0.190s gold, multi-t

Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Severin Gehwolf
Hi, I'm working on an enhancement for jlink. In particular a platform specific plugin. I.e. It would only get built on unix/linux platforms. My trouble is getting some resouce properties set up properly. In my example there is two versions of plugins.properties: one in shared/classes one in unix/c

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
Hi John, On Fri, Jan 25, 2019 at 11:10 PM Ao Qi wrote: > > On Fri, Jan 25, 2019 at 10:51 PM John Paul Adrian Glaubitz > wrote: > > > > On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, > > below is some sctripts I used > > > to cross compile a mips zero jdk, which can tri

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
On Fri, Jan 25, 2019 at 10:51 PM John Paul Adrian Glaubitz wrote: > > On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, > below is some sctripts I used > > to cross compile a mips zero jdk, which can trigger the bug. > > Native builds on Debian unstable on mips* work? > Wo

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
Hi, On Fri, Jan 25, 2019 at 10:31 PM John Paul Adrian Glaubitz wrote: > > Hi! > > On 1/24/19 3:28 AM, Leslie Zhai wrote: > > Please give me some advice about how to fix the root cause, thanks a lot! > > Just as a heads-up: In Debian we have two patches required for OpenJDK on the > mips > target

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread John Paul Adrian Glaubitz
On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, below is some sctripts I used > to cross compile a mips zero jdk, which can trigger the bug. Native builds on Debian unstable on mips* work? > do one patch [1] then make images What about the alignment patch? Is that still

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
Hi, FYI, if one wants to debug this issue, below is some sctripts I used to cross compile a mips zero jdk, which can trigger the bug. build machine: x86, debian testing (in a VirtualBox; an ubuntu may fail to configure) known worked targets: ppc64le/server and s390x/server (aarch64/server may fa

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-25 Thread Andrew Haley
Massive win for gold here, on my (very old) AArch64 system: BFD linker: $ time /home/aph/gcc-x/aarch64-trunk-install/bin/g++ -Wl,-z,defs -fuse-ld=bfd -Wl,-z,noexecstack ... real0m26.090s user0m24.570s sys 0m1.480s gold, single-threaded: $ time /home/aph/gcc-x/aarch64-trunk-insta

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread John Paul Adrian Glaubitz
Hi! On 1/24/19 3:28 AM, Leslie Zhai wrote: > Please give me some advice about how to fix the root cause, thanks a lot! Just as a heads-up: In Debian we have two patches required for OpenJDK on the mips targets: > https://git.launchpad.net/~openjdk/ubuntu/+source/openjdk/+git/openjdk/tree/debian

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 02:47, Leslie Zhai wrote: Hi Magnus, Failed to make images: $ make images CONF=mips Building target 'images' in configuration 'linux-mips64el-normal-server-fastdebug' GenerateLinkOptData.gmk:61: recipe for target '/home/loongson/zhaixiang/jdk12-mips/build/linux-mips64el-normal-s

RE: RFR (S) [11u backport]: 8207849: Allow the addition of more number to the Java version string

2019-01-25 Thread Langer, Christoph
Thanks, Magnus for the review. I shall try wiggle 😊 > -Original Message- > From: Magnus Ihse Bursie > Sent: Freitag, 25. Januar 2019 11:21 > To: Langer, Christoph ; 'build- > d...@openjdk.java.net' > Cc: Zeller, Arno > Subject: Re: RFR (S) [11u backport]: 8207849: Allow the addition of

Re: RFR (S) [11u backport]: 8207849: Allow the addition of more number to the Java version string

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 10:31, Langer, Christoph wrote: Hi, may I please get reviews for the backport of this issue to jdk11u. Bug: https://bugs.openjdk.java.net/browse/JDK-8207849 Original Commit: http://hg.openjdk.java.net/jdk/jdk/rev/1edc62f9ba3a Original review thread: https://mail.openjdk.java.n

RFR (S) [11u backport]: 8207849: Allow the addition of more number to the Java version string

2019-01-25 Thread Langer, Christoph
Hi, may I please get reviews for the backport of this issue to jdk11u. Bug: https://bugs.openjdk.java.net/browse/JDK-8207849 Original Commit: http://hg.openjdk.java.net/jdk/jdk/rev/1edc62f9ba3a Original review thread: https://mail.openjdk.java.net/pipermail/build-dev/2018-July/022719.html Webrev