Hi Yasumasa,
On 20/03/2019 3:01 pm, Yasumasa Suenaga wrote:
Thanks David!
I uploaded new webrev.
This change affects Windows only, and I confirmed it works fine for
Linux x64 and MinGW64.
http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.01/
I this is for MINGW only then shouldn't
Thanks David!
I uploaded new webrev.
This change affects Windows only, and I confirmed it works fine for
Linux x64 and MinGW64.
http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.01/
Thanks,
Yasumasa
2019年3月20日(水) 11:25 David Holmes :
>
> On 20/03/2019 11:54 am, Yasumasa Suenaga
Hi all,
Unless a runtime failure is triggered, I think the simplest way to fix
this issue is to change the build system since deprecated-declarations
warnings are not errors at all.
deprecated-declarations warnings seem to be treated as errors only for
hotspot build.
But why not for jdk
On 2019/3/19 下午11:09, Martin Buchholz wrote:
Probably it's because glibc deprecated readdir, and we don't have
--disable-warnings-as-errors by default?
Yes.
(I think warnings should not be errors except as opt-in by openjdk
developers/maintainers)
I agree, especially for
On 20/03/2019 11:54 am, Yasumasa Suenaga wrote:
Hi David,
2019年3月20日(水) 10:38 David Holmes :
Hi Yasumasa,
I'm not familar with building hsdis, but if the only currnet problem is
on Windows, why is the fix not restricted to only building on Windows?
For Solaris and Linux, -lz is not added
Hi Yasumasa,
I'm not familar with building hsdis, but if the only currnet problem is
on Windows, why is the fix not restricted to only building on Windows?
Otherwise we need people who build hsdis on other platforms to comment
on the appropriateness of the fix.
Thanks,
David
On 20/03/2019
Hi Erik, David,
I checked this change on Linux x64 and MinGW for Windows.
According to hsdis README, we need to use MinGW cross compiler to
build hsdis [1]. So I think Cygwin is not required.
I do not have macOS and AIX. So I cannot check this change on them.
BTW is hsdis included Java SE spec?
Hi Erik,
Thanks for your kind response!
在 2019年03月20日 00:51, Erik Joelsson 写道:
Hello Leslie,
The failure you see is happening when the newly built exploded image
is used for the first time. I'm not familiar with ASAN, but it seems
that the JDK you create does not quite work. There are some
CC'ing hotspot-dev. I agree this needs to be checked on every platform
affected. I can't comment on the fix itself.
David
On 20/03/2019 2:36 am, Erik Joelsson wrote:
I think this needs to be reviewed by at least someone in hotspot who
regularly builds hsdis. I can't really comment on the
Sorry, forgot about this. Since I modified that patch, I need another
reviewer before I can push it.
So, anyone interested in reviewing this?
Webrev: http://cr.openjdk.java.net/~erikj/8220445/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8220445
/Erik
On 2019-03-19 13:49, Ali
Hi Erik,
Is there any action that you want me to take on this?
Thanks,
Ali
On Mon, Mar 11, 2019 at 7:37 PM Ali Ince wrote:
> Hi Erik,
>
> Thanks for sponsoring this improvement. I think it will improve build
> environments for different versions of OpenJDK.
>
> Yes, I have signed OCA.
>
>
On 19/03/2019 15:09, Martin Buchholz wrote:
> Probably it's because glibc deprecated readdir, and we don't have
> --disable-warnings-as-errors by default?
>
> (I think warnings should not be errors except as opt-in by openjdk
> developers/maintainers)
>
> On Tue, Mar 19, 2019 at 7:47 AM Andrew
Hello Leslie,
The failure you see is happening when the newly built exploded image is
used for the first time. I'm not familiar with ASAN, but it seems that
the JDK you create does not quite work. There are some ways around this.
If you are unfamiliar with the exploded image, it's something
I think this needs to be reviewed by at least someone in hotspot who
regularly builds hsdis. I can't really comment on the validity of the
patch as I'm unfamiliar with both hsdis as well as this makefile. Have
you at least verified the build on all the platforms which you affect
with this
Hi,
I want to run dynamic analysis test with the help of Address Sanitizer.
And I read the blog 'Running Java with AddressSanitizer'[1] wrote by
Artem who also added support for ASan[2]. Thanks for his great job!
But I failed to make images for X86:
Compiling 4 files for
jdk8u-dev will build with this conf
bash configure --with-extra-cflags=-Wno-error
at least on Ubuntu 18.04.
> On Mar 19, 2019, at 8:09 AM, Martin Buchholz wrote:
>
> Probably it's because glibc deprecated readdir, and we don't have
> --disable-warnings-as-errors by default?
>
> (I think
Probably it's because glibc deprecated readdir, and we don't have
--disable-warnings-as-errors by default?
(I think warnings should not be errors except as opt-in by openjdk
developers/maintainers)
On Tue, Mar 19, 2019 at 7:47 AM Andrew Haley wrote:
> On 3/19/19 12:25 PM, Jie Fu wrote:
> > To
On 3/19/19 12:25 PM, Jie Fu wrote:
> To fix build failures caused by deprecated-declarations warnings, can we
> make this change to jdk8u?
This is very GCC-version dependent. We really should probe at configure time for
these options.
--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd.
Hi all,
To fix build failures caused by deprecated-declarations warnings, can we
make this change to jdk8u?
--
diff -r 6e2900603bc6 make/linux/makefiles/gcc.make
--- a/make/linux/makefiles/gcc.make Mon Mar 18 08:33:53 2019 +0100
+++
19 matches
Mail list logo
