Re: RFR: 8223804: [macos] remove obsoleted reference to security framework in launcher code

2019-05-16 Thread Erik Joelsson
Looks good. /Erik On 2019-05-16 12:30, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223804 Webrev: http://cr.openjdk.java.net/~prr/8223804/ This is a small cleanup fix. When doing a previous launcher fix : https://bugs.openjdk.java.net/browse/JDK-8222819 I failed to check i

Re: RFR: 8223804: [macos] remove obsoleted reference to security framework in launcher code

2019-05-16 Thread Roger Riggs
Hi Phil, Looks fine. Roger On 05/16/2019 03:30 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223804 Webrev: http://cr.openjdk.java.net/~prr/8223804/ This is a small cleanup fix. When doing a previous launcher fix : https://bugs.openjdk.java.net/browse/JDK-8222819 I fai

RFR: 8223804: [macos] remove obsoleted reference to security framework in launcher code

2019-05-16 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8223804 Webrev: http://cr.openjdk.java.net/~prr/8223804/ This is a small cleanup fix. When doing a previous launcher fix : https://bugs.openjdk.java.net/browse/JDK-8222819 I failed to check if the removal there meant there were now unused imports in

Re: problem building opnJdk 11 at Linux

2019-05-16 Thread Moshe Zuisman
Thanks! Will try it. чт, 16 мая 2019 г. в 19:58, Aleksey Shipilev : > On 5/16/19 6:53 PM, Moshe Zuisman wrote: > > > */data1/controlm/jdk11-1ddf9a99e4ad/test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java:123: > > error: no suitable method found

Re: problem building opnJdk 11 at Linux

2019-05-16 Thread Aleksey Shipilev
On 5/16/19 6:53 PM, Moshe Zuisman wrote: > */data1/controlm/jdk11-1ddf9a99e4ad/test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java:123: > error: no suitable method found for save(Map)* This is jtreg incompatibility [1]. It should be already fixed

problem building opnJdk 11 at Linux

2019-05-16 Thread Moshe Zuisman
I have a problem building opnJdk 11 at Linux. When I run : make test I get: *Building target 'test' in configuration 'linux-x86_64-normal-server-release'* *Warning: No mercurial configuration present and no .src-rev* *Compiling 27 files for BUILD_FAILURE_HANDLER* */data1/controlm/jdk11-1

RE: zlib configuration : system vs. bundled

2019-05-16 Thread Baesken, Matthias
Hello Alan, I found http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032106.html and http://mail.openjdk.java.net/pipermail/build-dev/2016-February/thread.html#16602 but without much details on real or potential performance improvements . Both discussion threads are pre

Re: zlib configuration : system vs. bundled

2019-05-16 Thread Alan Bateman
On 16/05/2019 12:34, Baesken, Matthias wrote: Hello, the updated webrev is here : http://cr.openjdk.java.net/~mbaesken/webrevs/8223944.1/ This looks good to me. -Alan

Re: zlib configuration : system vs. bundled

2019-05-16 Thread Erik Joelsson
Looks ok. /Erik On 2019-05-16 04:34, Baesken, Matthias wrote: Hello, the updated webrev is here : http://cr.openjdk.java.net/~mbaesken/webrevs/8223944.1/ Best regards, Matthias On 2019-05-15 01:16, Baesken, Matthias wrote: Hi Alan, thanks for pointing me at the old discussion .

RE: zlib configuration : system vs. bundled

2019-05-16 Thread Baesken, Matthias
Hello, the updated webrev is here : http://cr.openjdk.java.net/~mbaesken/webrevs/8223944.1/ Best regards, Matthias > > > On 2019-05-15 01:16, Baesken, Matthias wrote: > > Hi Alan, thanks for pointing me at the old discussion . > > > > http://mail.openjdk.java.net/pipermail/build-dev/