Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Andrew John Hughes
On 26/06/2019 14:02, Severin Gehwolf wrote: > On Wed, 2019-06-26 at 13:04 +0100, Andrew John Hughes wrote: >> >> On 25/06/2019 10:04, Severin Gehwolf wrote: >>> Hi, >>> >>> Could somebody please review this 8u backport? The build system in 8 is >>> different, especially hotspot makefiles. Note,

Re: CFV: New Build Group Member: Matthias Baesken

2019-06-26 Thread Tim Bell
Vote: yes Tim On 06/26/19 01:29, Volker Simonis wrote: I hereby nominate Matthias Baesken (mbaesken) to Membership in the Build Group.

RE: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Langer, Christoph
> Here you go: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > 8210761/jdk8/02/webrev/ > > I cannot really test on bsd, solaris or aix, though :( Appreciate any > testers for those platforms. I pulled the patch into our test environment. It will be run for AIX and solaris there. Will let y

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Severin Gehwolf
On Wed, 2019-06-26 at 13:04 +0100, Andrew John Hughes wrote: > > On 25/06/2019 10:04, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this 8u backport? The build system in 8 is > > different, especially hotspot makefiles. Note, libjsig.so is part of > > the hotspot build. The

Re: CFV: New Build Group Member: Matthias Baesken

2019-06-26 Thread Erik Joelsson
Vote: yes /Erik On 2019-06-26 01:29, Volker Simonis wrote: I hereby nominate Matthias Baesken (mbaesken) to Membership in the Build Group. Matthias is a long standing member of the JVM team at SAP. He's main areas of expertise are the build system, compilers/porting and security updates. He's

RE: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Langer, Christoph
> The 11u fix applies to all 'unix' platforms, as far as I can see. Should > the 8u equivalent not also be applied to the solaris, bsd and aix > subdirectories as well for consistency? +1 We can test this for AIX. Cheers Christoph

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Thomas Stüfe
On Wed, Jun 26, 2019 at 2:27 PM Severin Gehwolf wrote: > On Wed, 2019-06-26 at 14:21 +0200, Thomas Stüfe wrote: > > > > One curious question though about the original bug, was this really a > > measurable performance issue? I would have thought that libjsig is > > not invoked often enough for thi

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Severin Gehwolf
On Wed, 2019-06-26 at 14:21 +0200, Thomas Stüfe wrote: > > One curious question though about the original bug, was this really a > measurable performance issue? I would have thought that libjsig is > not invoked often enough for this to make a difference.. It's a matter of missed optimizations. W

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Thomas Stüfe
I'd be okay with doing this on AIX if Christoph is. One curious question though about the original bug, was this really a measurable performance issue? I would have thought that libjsig is not invoked often enough for this to make a difference.. Cheers, Thomas On Wed, Jun 26, 2019 at 2:05 PM A

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Andrew John Hughes
On 25/06/2019 10:04, Severin Gehwolf wrote: > Hi, > > Could somebody please review this 8u backport? The build system in 8 is > different, especially hotspot makefiles. Note, libjsig.so is part of > the hotspot build. The patch is different in 8 (over 11) due to this > reason. This is a Linux-o

Re: [8u] RFR: 8210761: libjsig is being compiled without optimization

2019-06-26 Thread Severin Gehwolf
Hi Christoph, On Tue, 2019-06-25 at 18:14 +, Langer, Christoph wrote: > Hi Severin, > > I think this is good. Thanks for the review! Cheers, Severin > Best regards > Christoph > > > -Original Message- > > From: jdk8u-dev On Behalf Of > > Severin Gehwolf > > Sent: Dienstag, 25. Ju

CFV: New Build Group Member: Matthias Baesken

2019-06-26 Thread Volker Simonis
I hereby nominate Matthias Baesken (mbaesken) to Membership in the Build Group. Matthias is a long standing member of the JVM team at SAP. He's main areas of expertise are the build system, compilers/porting and security updates. He's a JDK Reviewer who has contributed more than 90 changes within

Re: CFV: New Build Group Member: Matthias Baesken

2019-06-26 Thread Volker Simonis
Vote: yes On Wed, Jun 26, 2019 at 10:29 AM Volker Simonis wrote: > > I hereby nominate Matthias Baesken (mbaesken) to Membership in the Build > Group. > > Matthias is a long standing member of the JVM team at SAP. He's main > areas of expertise are the build system, compilers/porting and > secur