Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, Please review a new webrev that adds the change to remove the interim build parts. (Passes Tier 1-3 of CI testing) http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-1/ Thanks, Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Alan, Removal of rmic itself is assigned to Stuart with a fixVersion of 15: 8225319 Remove rmic from the set of supported tools I'll see how to test the build-cycle. Thanks, Roger On 3/16/20 1:39 PM, Alan Bateman wrote: On 16/03/2020

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 16/03/2020 16:02, Roger Riggs wrote: Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, I was thinking that was a separate step, but can pull it in. (And there's something in spec.gmk.in.) Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In make/Main.gmk, all the targets concerning rmic needs to be removed as well as any dependencies declared that involves them. Searching for "rmic" should find all

RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been edited to remove or suppress compilation

Re: 8241034: Fix a configuring error with "-Xmx2048M: command not found"(Internet mail)

Thanks Erik for your review. Pushed. Best regards, Jie On 2020/3/16, 8:46 PM, "Erik Joelsson" wrote: Looks good. /Erik On 2020-03-13 17:13, jiefu(傅杰) wrote: > Hi all, > > JBS:https://bugs.openjdk.java.net/browse/JDK-8241034 > Webrev:

Re: How to pass link option at Windows build?

On 2020-03-15 18:52, Robert Lu wrote: Hi, I am trying to build JDK at Windows 10, with cl 19.24.28316 for x64. I want to build a JDK without ASLR，which needs to set link option /FIXED. so I tried these options: bash ./configure --with-debug-level=fastdebug --with-extra-cflags="/DYNAMICBASE:NO

Re: RFR: JDK-8240224 Allow building hotspot without the serial gc

Ok, let's take a step back in this, and split up this into separate issues. Issue 1: Compilation of hotspot fails if serialgc is disabled Issue 2: How can the build system cope with building when the product does not have serial gc? If we can just agree how to fix 1 I can make sure the

Re: How to pass link option at Windows build?

A workaround would be to edit in these flags instead. You could either edit make/autoconf/flags*.m4 or, after running configure, edit the generated build/window*/spec.gmk. /Erik On 2020-03-16 05:48, Erik Joelsson wrote: Hello Robert, You are using the intended options. I just don't think

Re: How to pass link option at Windows build?

Hello Robert, You are using the intended options. I just don't think anyone has tried adding options on Windows before, so you have uncovered a bug in the build system. /Erik On 2020-03-15 10:52, Robert Lu wrote: Hi, I am trying to build JDK at Windows 10, with cl 19.24.28316 for x64. I

Re: 8241034: Fix a configuring error with "-Xmx2048M: command not found"(Internet mail)

Yes. /Erik On 2020-03-13 23:09, jiefu(傅杰) wrote: Thanks Mikael for your review. Is it OK to be pushed? Best regards, Jie On 2020/3/14, 12:45 PM, "Mikael Vidstedt" wrote: Looks good. I also noticed this and filed JDK-8241035[1], but closed my issue as a duplicate of yours.

Re: RFR: 8241034: Fix a configuring error with "-Xmx2048M: command not found"

Looks good. /Erik On 2020-03-13 17:13, jiefu(傅杰) wrote: Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8241034 Webrev: http://cr.openjdk.java.net/~jiefu/8241034/webrev.00/ A shell command error was observed during the jdk configuration. ```