Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-04 Thread Erik Joelsson
On 2020-05-04 02:51, Magnus Ihse Bursie wrote: On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target

Re: RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-04 Thread Liu, Xin
Hi, Magnus and Erik, Thank you to look into it. Here is a new revision. https://cr.openjdk.java.net/~xliu/8244248/02/webrev/ When I enclosed the whole statement with [], autoconf/m4 told me that it's syntax error for [$] 0. So, I added an extra whitespace to avoid m4 substitution. [

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread John Paul Adrian Glaubitz
Hello Erik! On 5/4/20 5:54 PM, Erik Joelsson wrote: > The build changes look ok and will remove all support for building on or > recognizing either Solaris or Sparc. > > Kim's note is valid and I would recommend removing that variable completely. > > I do think it would be possible to leave

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread Erik Joelsson
The build changes look ok and will remove all support for building on or recognizing either Solaris or Sparc. Kim's note is valid and I would recommend removing that variable completely. I do think it would be possible to leave enough in there to enable zero builds on Linux Sparc, but I

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread Erik Joelsson
On 2020-05-04 01:38, Kim Barrett wrote: On May 4, 2020, at 1:12 AM, Mikael Vidstedt wrote: Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev:

Re: Configure fails to create fixpath.exe when running in WSL

2020-05-04 Thread Magnus Ihse Bursie
On 2020-05-02 23:19, Ludovic HOCHET wrote: Running configure in an Ubuntu on WSL1 on Windows 2004 (10.0.19041.208), it fails to create fixpath.exe in its expected location. After some search it seems that wslpath -m /mnt/e/jdk/build/windows-x86_64-server-release/configure-support/bin/fixpath.exe

Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-04 Thread Magnus Ihse Bursie
On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation. The

Re: RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-04 Thread Magnus Ihse Bursie
On 2020-05-02 01:57, Liu, Xin wrote: HI, Eric, Thanks for the feedback. I use [] to wrap the regex for readability. Here is a new webrev: https://cr.openjdk.java.net/~xliu/8244248/01/webrev/make/autoconf/boot-jdk.m4.udiff.html This looks better, but I'd prefer it if you add a comment about

Re: RFR: JDK-8244210: The javac server is never used

2020-05-04 Thread Magnus Ihse Bursie
On 2020-04-30 21:10, Erik Joelsson wrote: Hello, A minor mistake in JDK-8244036 is causing the javac server to never be used, which is rather severly increasing build times. Before that change, the global variable ENABLE_SJAVAC was used to determine if the server should be activated. After

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread Kim Barrett
> On May 4, 2020, at 1:12 AM, Mikael Vidstedt > wrote: > > > Please review this change which implements part of JEP 381: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/build/open/webrev/ > JEP:

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread John Paul Adrian Glaubitz
On 5/4/20 9:39 AM, John Paul Adrian Glaubitz wrote: > I haven't looked at the changes yet, but please make sure you don't kill the > possibility to build Zero on SPARC on Linux because that should still work > without many extra ado. This change should be dropped from make/autoconf/platform.m4:

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-04 Thread John Paul Adrian Glaubitz
Hi Mikael! On 5/4/20 7:12 AM, Mikael Vidstedt wrote: > > Please review this change which implements part of JEP 381: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/build/open/webrev/ > JEP: