Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-05 Thread Magnus Ihse Bursie
On 2020-05-04 23:38, Erik Joelsson wrote: On 2020-05-04 02:51, Magnus Ihse Bursie wrote: On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle

Re: RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-05 Thread Magnus Ihse Bursie
On 2020-05-04 20:57, Liu, Xin wrote: Hi, Magnus and Erik, Thank you to look into it. Here is a new revision. https://cr.openjdk.java.net/~xliu/8244248/02/webrev/ Looks good to me! /Magnus When I enclosed the whole statement with [], autoconf/m4 told me that it's syntax error for [$] 0. So,

RFR: 8243656: Shell built-in test in configure depends on help

2020-05-05 Thread Severin Gehwolf
Hi, Could I please get a review of this trivial change? Apparently using the help builtin for determining whether or not a builtin is available is not a good idea. A more portable way to do this is to use "command -v" or "type". Thanks to Michael Zucchi for contributing this fix. Bug: https://bug

Re: RFR: 8243656: Shell built-in test in configure depends on help

2020-05-05 Thread Erik Joelsson
Looks good to me. /Erik On 2020-05-05 08:15, Severin Gehwolf wrote: Hi, Could I please get a review of this trivial change? Apparently using the help builtin for determining whether or not a builtin is available is not a good idea. A more portable way to do this is to use "command -v" or "type

Re: RFR: 8243656: Shell built-in test in configure depends on help

2020-05-05 Thread Severin Gehwolf
On Tue, 2020-05-05 at 08:24 -0700, Erik Joelsson wrote: > Looks good to me. Thanks for the review, Erik! Cheers, Severin > /Erik > > On 2020-05-05 08:15, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this trivial change? Apparently using > > the help builtin for determi

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-05 Thread Mikael Vidstedt
> On May 4, 2020, at 12:44 AM, John Paul Adrian Glaubitz > wrote: > > On 5/4/20 9:39 AM, John Paul Adrian Glaubitz wrote: >> I haven't looked at the changes yet, but please make sure you don't kill the >> possibility to build Zero on SPARC on Linux because that should still work >> without ma