Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-13 Thread Yasumasa Suenaga
Hi David, Matthias, Martin, I uploaded new webrev. Could you review again? http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.02/ It generates runtime stub for hypervisor detection, and it can distinguish between Hyper-V host (root partition) and guest. And also it works on 32bit platf

JDK 16 RFR of JDK-8251549: Update docs on building for Git

2020-08-13 Thread Joe Darcy
Hello, Ahead of the JDK switching to Git, please review the updates to the build docs:     JDK-8251549: Update docs on building for Git     http://cr.openjdk.java.net/~darcy/8251549.0/ This would be pushed shortly *after* the transition to Git. Once the changes to md are agree to, I'll regen

RFR: JDK-8251541 "no symbols" printed when building hotspot

2020-08-13 Thread Magnus Ihse Bursie
Recently a lot of "no symbols" is shown when building hotspot, at least on macOS. This comes from the new/delete operator check which uses nm. I have checked the source of these problems. Several files are now empty due to refactoring and the use of (incidentally) file-wide #ifdefs. So we jus

Re: RFR: JDK-8251533 MacOS build of libjimage explicitly adds C++ standard library

2020-08-13 Thread Erik Joelsson
Looks good. In the ADLC case, it seemed to be needed when linking with gcc instead of clang. /Erik On 2020-08-13 05:00, Magnus Ihse Bursie wrote: From the bug report: In CoreLibraries.gmk we have $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ ... ???LIBS_unix := -ljvm -ldl $(LIBCXX), \

Re: RFR: JDK-8251516 VSCode IDE configuration specifies c++03

2020-08-13 Thread Erik Joelsson
Looks good. /Erik On 2020-08-13 03:38, Magnus Ihse Bursie wrote: From the bug report: make/ide/vscode/hotspot/indexers/cpptools-settings.txt:  "C_Cpp.default.cppStandard": "c++03", make/ide/vscode/hotspot/indexers/rtags-settings.txt:  "C_Cpp.default.cppStandard": "c++03", make/ide/vscode/hot

RFR: JDK-8251533 MacOS build of libjimage explicitly adds C++ standard library

2020-08-13 Thread Magnus Ihse Bursie
From the bug report: In CoreLibraries.gmk we have $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ ... ???LIBS_unix := -ljvm -ldl $(LIBCXX), \ ???LIBS_macosx := -lc++, \ I think the LIBS_macosx line should not be needed. Other similar places don't seem to do that. If it were necessary to expl

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-13 Thread David Holmes
On 13/08/2020 5:39 pm, Yasumasa Suenaga wrote: Hi Matthias, David, On 2020/08/13 15:52, Baesken, Matthias wrote: Should we make the change to determine just before it is needed (e.g. VM.info or hs_err log) at first? It is out of scope of this change, so I want to work as another issue if i

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 13, 2020, at 6:54 AM, Magnus Ihse Bursie > wrote: > > On 2020-08-13 09:15, Kim Barrett wrote: >> I'm similarly surprised by this pre-existing bit in CoreLibraries.gmk: >> >> $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ >> ... >> LIBS_unix := -ljvm -ldl $(LIBCXX), \ >> LIBS

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Magnus Ihse Bursie
On 2020-08-13 09:15, Kim Barrett wrote: On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: Hello Please review this change for JDK-8250876 This changeset adds support for macos/aarch64 into build system. It will allow to crosscompile for macos/aarch64 using intel mac as well. This changeset

RFR: JDK-8251516 VSCode IDE configuration specifies c++03

2020-08-13 Thread Magnus Ihse Bursie
From the bug report: make/ide/vscode/hotspot/indexers/cpptools-settings.txt:  "C_Cpp.default.cppStandard": "c++03", make/ide/vscode/hotspot/indexers/rtags-settings.txt:  "C_Cpp.default.cppStandard": "c++03", make/ide/vscode/hotspot/indexers/ccls-settings.txt:  "C_Cpp.default.cppStandard": "c++

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-13 Thread Yasumasa Suenaga
Hi Matthias, David, On 2020/08/13 15:52, Baesken, Matthias wrote: Should we make the change to determine just before it is needed (e.g. VM.info or hs_err log) at first? It is out of scope of this change, so I want to work as another issue if it is needed. Hi , I think we better do not ca

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 13, 2020, at 3:15 AM, Kim Barrett wrote: > >> On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: >> >> Hello >> >> Please review this change for JDK-8250876 >> >> This changeset adds support for macos/aarch64 into build system. >> It will allow to crosscompile for macos/aarch64 using

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-13 Thread Kim Barrett
> On Aug 1, 2020, at 3:24 AM, Vladimir Kempik wrote: > > Hello > > Please review this change for JDK-8250876 > > This changeset adds support for macos/aarch64 into build system. > It will allow to crosscompile for macos/aarch64 using intel mac as well. > > This changeset does NOT address some