Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Jie Fu
On Thu, 1 Oct 2020 01:01:23 GMT, Paul Sandoz wrote: >> Hi @PaulSandoz , >> >> I think it would be better to integrate it [1] in this MR. >> >> I have tested this MR on our AVX512 machines and it still crashes. >> Also, for the sake of maintenance, it seems NOT a good idea to push a >>

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Paul Sandoz
On Thu, 1 Oct 2020 00:25:46 GMT, Jie Fu wrote: >> @DamonFool we can follow up later for that fix (and others in >> `vectorIntrinsics`), after this PR integrates. I don't >> want to perturb the code that has already been reviewed, which requires yet >> more additional review. > > Hi @PaulSandoz

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Jie Fu
On Wed, 30 Sep 2020 18:19:53 GMT, Paul Sandoz wrote: >> Hi @PaulSandoz , >> >> This integration seems to miss >> https://github.com/openjdk/panama-vector/pull/1, which had fixed crashes on >> AVX512 >> machines. >> Thanks. > > @DamonFool we can follow up later for that fix (and others in >

Integrated: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

2020-09-30 Thread Philippe Marschall
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall wrote: > Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since`

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

2020-09-30 Thread Vladimir Kozlov
On Mon, 28 Sep 2020 19:08:04 GMT, Philippe Marschall wrote: >> @marschall I will sponsor it after you integrate the latest update. > > @vnkozlov done, I hope I now made it correctly with a merge commit for the > latest merge conflict hs-tier1, hs-tier3-graal testing passed -

RE: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-30 Thread Hohensee, Paul
I filed https://bugs.openjdk.java.net/browse/JDK-8253868: CodeSection::initialize_shared_locs buffer argument types and sizes are opaque Paul On 9/29/20, 9:35 AM, "Kim Barrett" wrote: > On Sep 29, 2020, at 10:18 AM, Hohensee, Paul wrote: > Code that calls initialize_shared_locs is

RFR: 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably

2020-09-30 Thread Robin Westberg
The pre-submit test definitions utilizing GitHub Actions can sometimes report success even when there are failing tests. The failure detection depended on make returning a non-zero exit code on failures, which doesn't seem to work. To properly determine test outcome we should check the

Integrated: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-30 Thread Paul Hohensee
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote: > Please review this small patch to enable the OSX build using Xcode 12.0. > > Thanks, > Paul This pull request has now been integrated. Changeset: f80a6066 Author:Paul Hohensee URL:

RE: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209) [v2]

2020-09-30 Thread Hohensee, Paul
Thanks, Lutz! On 9/29/20, 10:56 PM, "build-dev on behalf of Lutz Schmidt" wrote: On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote: >> Please review this small patch to enable the OSX build using Xcode 12.0. >> >> Thanks, >> Paul > > Paul Hohensee has updated