On Fri, 18 Sep 2020 10:56:56 GMT, Aleksei Voitylov
wrote:
>> thank you Alan, Erik, and David! When the JEP becomes Targeted, I'll use
>> this PR to integrate the changes.
>
> I added the contributors that could be found in the portola project commits.
> If anyone knows some other contributors
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to
On Mon, 5 Oct 2020 18:13:49 GMT, Aleksei Voitylov wrote:
> Please review the build guide update for Alpine Linux.
>
> building.html was generated by "make update-build-docs". However, this
> command produced a slightly different
> building.html, with some other sections modified as well. This
Please review the build guide update for Alpine Linux.
building.html was generated by "make update-build-docs". However, this command
produced a slightly different
building.html, with some other sections modified as well. This is probably due
to another version of the tooling
installed. I have
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to
On Fri, 2 Oct 2020 15:49:27 GMT, Adam Farley wrote:
>> @adamfarley Please see
>> https://github.com/openjdk/jdk/pull/250#issuecomment-694845694 for getting
>> this integrated. For
>> non-committers it's `/integrate` and then `/sponsor` by somebody with commit
>> rights.
>
> Apologies for the
On Mon, 5 Oct 2020 12:58:52 GMT, Erik Joelsson wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> - simplified Copy.gmk to CAT source files directly
>> - renamed net.properties source files to all be
On Sun, 4 Oct 2020 13:14:49 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon
On Fri, 18 Sep 2020 12:07:45 GMT, Adam Farley wrote:
> A change made to ModuleWrapper.gmk as part of JDK-8244044 means that an
> included makefile is found in the current
> directory, so Make doesn't check the include dirs for overriding gmk files.
> Recommend a minor, partial reversion of this
