On Thu, 8 Oct 2020 13:59:20 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> *
On Thu, 8 Oct 2020 13:59:20 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> *
On Thu, 8 Oct 2020 18:15:10 GMT, Ludovic Henry wrote:
> @navyxliu
>
> > @luhenry I tried to build it with LLVM10.0.1
> > on my x86_64, ubuntu, I ran into a small problem. here is how I build.
> > $make ARCH=amd64 CC=/opt/llvm/bin/clang CXX=/opt/llvm/bin/clang++
> > LLVM=/opt/llvm/
> > I can't
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures.
> * internal macOS+ARM64
On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
wrote:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64:
On Wed, 7 Oct 2020 21:49:24 GMT, Yumin Qi wrote:
>> src/java.base/share/classes/jdk/internal/misc/CDS.java line 144:
>>
>>> 142: String line = s.trim();
>>> 143: if (!line.startsWith("[LF_RESOLVE]") &&
>>> !line.startsWith("[SPECIES_RESOLVE]")) {
>>> 144:
On Thu, 8 Oct 2020 07:21:56 GMT, Aleksey Shipilev wrote:
>> no-pch configuration is supposed to expose missing include dependencies. But
>> currently it runs with default (release)
>> bits, which misses symbols hidden in debug code. We should consider building
>> it in debug mode.
>> Attention
On Thu, 8 Oct 2020 07:18:28 GMT, Robin Westberg wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop "debug" from the names
>
> Looks good!
@erikj79, can you take a look as well? Or maybe @dholmes-ora wants
On Thu, 8 Oct 2020 11:00:41 GMT, Aleksei Voitylov wrote:
> @iignatev I resolved the conflict in whitebox.cpp and fixed a minor style nit
> on the way. Could you take a look?
LGTM
-
PR: https://git.openjdk.java.net/jdk/pull/49
On Thu, 8 Oct 2020 18:07:59 GMT, Ludovic Henry wrote:
>>> 1 question: binutils seems to support Windows AArch64. Did you try recently
>>> binutils? If we can use binutils on Windows
>>> AArch64, you can fix makefile only.
>>>
On Thu, 8 Oct 2020 12:30:13 GMT, Bernhard Urban-Forster
wrote:
>> IMHO, it's great to have an alternative disassembler. I personally had
>> better experience using llvm MC when I decoded
>> aarch64 and AVX instructions than BFD. Another argument is that LLVM
>> toolchain is supposed to
On Thu, 8 Oct 2020 13:59:20 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> *
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can
On Thu, 8 Oct 2020 12:54:12 GMT, Erik Joelsson wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/modules/java.base/gensrc/GensrcScopedMemoryAccess.gmk line 145:
>
>> 143:
On Thu, 8 Oct 2020 10:29:24 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> *
On Wed, 7 Oct 2020 08:02:59 GMT, Xin Liu wrote:
>> Can you separate LLVM and binutils from hsdis.cpp?
>>
>> I guess you say that the problem is both GCC and binutils are not available
>> on Windows AArch64. Is it right?
>> 1 question: binutils seems to support Windows AArch64. Did you try
This is the current proposed patch for the upcoming JEP 394, for pattern
matching for instanceof.
A summary of changes:
-making the feature permanent (non-preview)
-making the binding variables non-final (as per current specification proposal)
-producing a compile-time error for the case where
On Tue, 6 Oct 2020 02:00:06 GMT, David Holmes wrote:
>> I added the contributors that could be found in the portola project commits.
>> If anyone knows some other contributors I
>> missed, I'll be happy to stand corrected.
>
> @voitylov For future reference please don't force-push commits on
On Thu, 8 Oct 2020 10:58:56 GMT, Aleksei Voitylov wrote:
>> @voitylov For future reference please don't force-push commits on open PRs
>> as it breaks the commit history. I can no
>> longer just look at the two most recent commits and see what they added
>> relative to what I had previously
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jtreg directly and/or just build the JDK
>> and not the test
On Thu, 8 Oct 2020 10:29:24 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> *
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can
On Thu, 8 Oct 2020 06:53:41 GMT, Aleksey Shipilev wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/java/foreign/TestMismatch.java line 26:
>
>> 24: /*
>> 25: * @test
>>
On Wed, 7 Oct 2020 17:13:22 GMT, Maurizio Cimadamore
wrote:
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first,
On Wed, 7 Oct 2020 16:07:57 GMT, Aleksey Shipilev wrote:
> Zero VM and Minimal VM builds are routinely discovering the problems with
> internal Hotspot dependencies. Mostly because
> they turn off the whole lot of VM features, and every path that is not
> guarded by a feature #ifdef or build
On Thu, 8 Oct 2020 07:20:39 GMT, Aleksey Shipilev wrote:
>> Zero VM and Minimal VM builds are routinely discovering the problems with
>> internal Hotspot dependencies. Mostly because
>> they turn off the whole lot of VM features, and every path that is not
>> guarded by a feature #ifdef or
On Thu, 8 Oct 2020 07:07:40 GMT, Robin Westberg wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop "debug" from the names
>
> .github/workflows/submit.yml line 108:
>
>> 106: - build release
>>
> Zero VM and Minimal VM builds are routinely discovering the problems with
> internal Hotspot dependencies. Mostly because
> they turn off the whole lot of VM features, and every path that is not
> guarded by a feature #ifdef or build file list
> fails. It would be good to add Zero and
> no-pch configuration is supposed to expose missing include dependencies. But
> currently it runs with default (release)
> bits, which misses symbols hidden in debug code. We should consider building
> it in debug mode.
> Attention @rwestberg.
>
> Testing:
> - [x] GH workflow still works,
On Thu, 8 Oct 2020 07:19:21 GMT, Aleksey Shipilev wrote:
>> no-pch configuration is supposed to expose missing include dependencies. But
>> currently it runs with default (release)
>> bits, which misses symbols hidden in debug code. We should consider building
>> it in debug mode.
>> Attention
On Thu, 8 Oct 2020 07:12:12 GMT, Aleksey Shipilev wrote:
>> That makes sense. We should change the order in #547 then first? So the
>> final thing would be:
>>
>> - build release
>> - build debug
>> - build hotspot no-pch debug
>> - build hotspot zero no-pch debug
>> - build hotspot minimal
On Thu, 8 Oct 2020 07:08:46 GMT, Aleksey Shipilev wrote:
>> .github/workflows/submit.yml line 109:
>>
>>> 107: - build debug
>>> 108: - build hotspot no-pch
>>> 109: - build debug hotspot no-pch zero
>>
>> Suggestion:
>>
>> - build hotspot zero no-pch
On Thu, 8 Oct 2020 06:58:38 GMT, Robin Westberg wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Build with debug and no-pch for zero and minimal
>
> .github/workflows/submit.yml line 109:
>
>> 107:
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote:
>> Zero VM and Minimal VM builds are routinely discovering the problems with
>> internal Hotspot dependencies. Mostly because
>> they turn off the whole lot of VM features, and every path that is not
>> guarded by a feature #ifdef or
On Wed, 7 Oct 2020 20:36:18 GMT, Mandy Chung wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains
>> 23 commits:
>> - Added new separate function to CDS for logging species and modified the
>> existing function to
On Tue, 6 Oct 2020 20:46:17 GMT, Yumin Qi wrote:
>> This patch is reorganized after 8252725, which is separated from this patch
>> to refactor jlink glugin code. The previous
>> webrev with hg can be found at:
>> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>>
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote:
>> Zero VM and Minimal VM builds are routinely discovering the problems with
>> internal Hotspot dependencies. Mostly because
>> they turn off the whole lot of VM features, and every path that is not
>> guarded by a feature #ifdef or
On Wed, 7 Oct 2020 17:13:22 GMT, Maurizio Cimadamore
wrote:
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first,
39 matches
Mail list logo
