Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Alexey Semenyuk
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Ekaterina Pavlova
On Wed, 14 Oct 2020 00:34:04 GMT, Sandhya Viswanathan wrote: >> There are several gc tests crashed in panama-vector tier3 testing which >> seems are not observed in openjdk repo. >> The crashes look like: >> # assert(oopDesc::is_oop(obj)) failed: not an oop: 0xfff1 >> # >> # JRE

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Sandhya Viswanathan
On Tue, 13 Oct 2020 21:29:52 GMT, Ekaterina Pavlova wrote: >> Build changes look good. > > There are several gc tests crashed in panama-vector tier3 testing which seems > are not observed in openjdk repo. > The crashes look like: > # assert(oopDesc::is_oop(obj)) failed: not an oop:

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick
On Tue, 13 Oct 2020 23:28:24 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8252870: Finalize (remove "incubator" from) jpackage >> - reverting two auto-generated files, and

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Alexander Matveev
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 21:30:05 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8252870: Finalize (remove "incubator" from) jpackage >> - reverting two auto-generated files, and

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Ekaterina Pavlova
On Mon, 12 Oct 2020 12:56:10 GMT, Erik Joelsson wrote: >> Paul Sandoz has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains ten commits: >> - Merge master >> - Fix related to merge >> - HotspotIntrinsicCandidate to

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Alexander Matveev
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-13 Thread Andrew John Hughes
On Tue, 13 Oct 2020 11:32:54 GMT, Kiran Sidhartha Ravikumar wrote: >> Looks good. I think we should release-note the removal of the >> "US/Pacific-New" Link on the off chance that some >> production/testing system is looking for such a zone. > > Thanks for the review everyone, I have added a

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Integrated: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-13 Thread Ludovic Henry
On Fri, 9 Oct 2020 15:39:18 GMT, Ludovic Henry wrote: > We made a typo in https://github.com/openjdk/jdk/pull/212 when updating > make/devkit/createWindowsDevkit2017.sh. This pull request has now been integrated. Changeset: 715e24af Author:Ludovic Henry Committer: Tobias Hartmann URL:

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Erik Joelsson
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v3]

2020-10-13 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick
On Tue, 13 Oct 2020 13:44:22 GMT, Kevin Rushforth wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8252870: Finalize (remove "incubator" from) jpackage >> - reverting two auto-generated files, and changing

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick
> JDK-8252870: Finalize (remove "incubator" from) jpackage Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8252870: Finalize (remove "incubator" from) jpackage - reverting two auto-generated files, and changing module-info to

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 13:51:27 GMT, Kevin Rushforth wrote: >> I spot checked it and left a couple comments. The rest looks good. I'll >> review it in more detail later this week. > > @andyherrick the "reviewer credit" command should not be used in this manner. > It is intended for the case where

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 13:49:13 GMT, Kevin Rushforth wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > I spot checked it and left a couple comments. The rest looks good. I'll > review it in more detail later this week. @andyherrick the "reviewer credit" command should not be

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 12:51:54 GMT, Andy Herrick wrote: > JDK-8252870: Finalize (remove "incubator" from) jpackage I spot checked it and left a couple comments. The rest looks good. I'll review it in more detail later this week. make/data/symbols/jdk.jpackage-E.sym.txt line 29: > 27: #

RFR: 8254231: Implementation of Foreign Linker API (Incubator)

2020-10-13 Thread Maurizio Cimadamore
This patch contains the changes associated with the first incubation round of the foreign linker access API incubation (see JEP 389 [1]). This work is meant to sit on top of the foreign memory access support (see JEP 393 [2] and associated pull request [3]). The main goal of this API is to

RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-10-13 Thread Andy Herrick
JDK-8252870: Finalize (remove "incubator" from) jpackage - Commit messages: - JDK-8252870: Finalize (remove "incubator" from) jpackage - 8252869 Finalize (remove incubator from) jpackage (implementation) Changes: https://git.openjdk.java.net/jdk/pull/633/files Webrev:

Integrated: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-13 Thread Kiran Sidhartha Ravikumar
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug:

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-13 Thread Kiran Sidhartha Ravikumar
On Tue, 13 Oct 2020 11:07:13 GMT, Sean Coffey wrote: >> Hi Guys, >> >> Please review the patch for tzdata2020b integration into JDK. >> >> Release details can be found here: >> >> https://mm.icann.org/pipermail/tz-announce/2020-October/59.html >> >> Bug:

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v11]

2020-10-13 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

2020-10-13 Thread Sean Coffey
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug:

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v10]

2020-10-13 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v9]

2020-10-13 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v6]

2020-10-13 Thread Aleksei Voitylov
On Fri, 9 Oct 2020 06:02:04 GMT, David Holmes wrote: >> Aleksei Voitylov has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains three commits: >> - Merge branch 'master' into JDK-8247589 >> - JDK-8247589: Implementation of Alpine

Integrated: 8247591: Document Alpine Linux build steps in OpenJDK build guide

2020-10-13 Thread Aleksei Voitylov
On Mon, 5 Oct 2020 18:13:49 GMT, Aleksei Voitylov wrote: > Please review the build guide update for Alpine Linux. > > building.html was generated by "make update-build-docs". However, this > command produced a slightly different > building.html, with some other sections modified as well. This

Integrated: JDK-8247589: Implementation of Alpine Linux/x64 Port

2020-10-13 Thread Aleksei Voitylov
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote: > continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run