On 2020-11-03 05:27, Sergey Bylokhov wrote:
On Tue, 3 Nov 2020 01:07:51 GMT, Phil Race wrote:
If we build a headless only JDK, configure will require X11 libraries and
headers to be present. This used to be necessary, but thanks to massive
cleanups in the AWT headless code, this is no
On Tue, 3 Nov 2020 04:25:37 GMT, Sergey Bylokhov wrote:
>> Marked as reviewed by prr (Reviewer).
>
> Do we have a tier 1-build task or something that will check that we did not
> break building headless w/o x11?
I think you are confusing the modest goal of making it possible, with ensure ..
On Tue, 3 Nov 2020 01:07:51 GMT, Phil Race wrote:
>> If we build a headless only JDK, configure will require X11 libraries and
>> headers to be present. This used to be necessary, but thanks to massive
>> cleanups in the AWT headless code, this is no longer the case.
>>
>> We should fix
Hi,
On 29/10/2020 1:21 pm, 柳鲲鹏 wrote:
Hello!
I have built OpenJDK8-272 on windows 10. I found there is a bug:
Compre files between j2re-image and j2sdk-image, j2re-image lost two files:
sawindbg.dll
attach.dll
A JRE and a JDK have different contents - this is one of those
differences. A JRE
On Tue, 3 Nov 2020 00:33:09 GMT, Magnus Ihse Bursie wrote:
> If we build a headless only JDK, configure will require X11 libraries and
> headers to be present. This used to be necessary, but thanks to massive
> cleanups in the AWT headless code, this is no longer the case.
>
> We should fix
On Tue, 3 Nov 2020 00:33:09 GMT, Magnus Ihse Bursie wrote:
> If we build a headless only JDK, configure will require X11 libraries and
> headers to be present. This used to be necessary, but thanks to massive
> cleanups in the AWT headless code, this is no longer the case.
>
> We should fix
On Tue, 3 Nov 2020 00:33:09 GMT, Magnus Ihse Bursie wrote:
> If we build a headless only JDK, configure will require X11 libraries and
> headers to be present. This used to be necessary, but thanks to massive
> cleanups in the AWT headless code, this is no longer the case.
>
> We should fix
If we build a headless only JDK, configure will require X11 libraries and
headers to be present. This used to be necessary, but thanks to massive
cleanups in the AWT headless code, this is no longer the case.
We should fix configure so that headless can be built without X11 libraries and
On Tue, 3 Nov 2020 00:00:26 GMT, Kiran Sidhartha Ravikumar
wrote:
>> My question is why it is failing. Have you figured it? The existing
>> exceptions are either negative DST or last rule beyond 2037, which javazic
>> cannot handle. The changes introduced with 2020d does not meet either of
On Mon, 2 Nov 2020 18:14:47 GMT, Naoto Sato wrote:
>> It's probably these last rule what is causing the issue
>>
>> Rule Palestine 2020max - Mar Sat>=24 0:001:00
>> S
>> Rule Palestine 2020max - Oct Sat>=24 1:000
>> -
>>
>> The
On Mon, 2 Nov 2020 14:40:35 GMT, Erik Joelsson wrote:
> We have at least one java file with a '$' in the name. As we have learned
> over the years, having $ in unexpected places quickly leads to unexpected
> behavior in a shell/make based build. In this case it's our override
> mechanism of
On Mon, 2 Nov 2020 20:22:21 GMT, Vladimir Kozlov wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains five
>>
On Mon, 2 Nov 2020 18:15:09 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Tue, 27 Oct 2020 16:09:45 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
>> line 88:
>>
>>> 86:
>>> 87: @Override
>>> 88: protected Content getDeprecatedOrPreviewLink(Element member) {
>>
>>
On Fri, 16 Oct 2020 16:07:41 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating
On Tue, 20 Oct 2020 15:46:36 GMT, Bernhard Urban-Forster
wrote:
>> Use r18 as allocatable register on Linux only.
>>
>> A bootstrap works now (it has been crashing before due to r18 being
>> allocated):
>> $ ./windows-aarch64-server-fastdebug/bin/java.exe
>> -XX:+UnlockExperimentalVMOptions
On Mon, 2 Nov 2020 20:05:10 GMT, Bernhard Urban-Forster
wrote:
>> make/autoconf/jvm-features.m4 line 309:
>>
>>> 307: if test "x$OPENJDK_TARGET_CPU" = "xx86_64"; then
>>> 308: AC_MSG_RESULT([yes])
>>> 309: elif test "x$OPENJDK_TARGET_CPU" = "xaarch64"; then
>>
>> You are missing
On Mon, 2 Nov 2020 19:33:39 GMT, Vladimir Kozlov wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains five
>>
On Tue, 20 Oct 2020 15:46:36 GMT, Bernhard Urban-Forster
wrote:
>> Use r18 as allocatable register on Linux only.
>>
>> A bootstrap works now (it has been crashing before due to r18 being
>> allocated):
>> $ ./windows-aarch64-server-fastdebug/bin/java.exe
>> -XX:+UnlockExperimentalVMOptions
On Tue, 20 Oct 2020 15:46:36 GMT, Bernhard Urban-Forster
wrote:
>> Use r18 as allocatable register on Linux only.
>>
>> A bootstrap works now (it has been crashing before due to r18 being
>> allocated):
>> $ ./windows-aarch64-server-fastdebug/bin/java.exe
>> -XX:+UnlockExperimentalVMOptions
On Mon, 2 Nov 2020 17:43:31 GMT, Andrew Haley wrote:
>> https://github.com/openjdk/jdk/pull/1013
>
>> @lewurm
>> This patch seems to break on linux-aarch64 with gcc:
>
> Builds cleanly on Linux/GCC or me.
@theRealAph what gcc version?
I can reproduce with
$ gcc --version
gcc (Ubuntu
On Mon, 2 Nov 2020 18:06:28 GMT, Kiran Sidhartha Ravikumar
wrote:
>> test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 201:
>>
>>> 199: zid.equals("Iran") || // last rule mismatch
>>> 200: zid.equals("Asia/Gaza") || // last rule mismatch
>>> 201:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview
On Mon, 2 Nov 2020 17:10:34 GMT, Naoto Sato wrote:
>> Hi Guys,
>>
>> Please review the integration of tzdata2020d to JDK.
>>
>> Details regarding the change can be viewed at -
>> https://mm.icann.org/pipermail/tz-announce/2020-October/62.html
>> Bug:
On Thu, 29 Oct 2020 09:26:05 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1288:
>>
>>> 1286: case FIELD: case INSTANCE_INIT: case LOCAL_VARIABLE:
>>> case PARAMETER:
>>> 1287: case
On Thu, 29 Oct 2020 09:43:56 GMT, Jan Lahoda wrote:
>> I don't think there should be much interaction with -source .
>> We don't support preview features from previous version or preview class
>> files from previous versions, so I think it should be enough to handle the
>> currently present
On Mon, 2 Nov 2020 17:05:19 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm Open a new JBS issue with the bug. If you can find a fix in a short
>> amount of time (which I would believe should be possible; probably just need
>> a proper cast) it's acceptable to fix it directly. What amounts to a
On Mon, 2 Nov 2020 16:29:07 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the integration of tzdata2020d to JDK.
>
> Details regarding the change can be viewed at -
> https://mm.icann.org/pipermail/tz-announce/2020-October/62.html
> Bug:
On Mon, 2 Nov 2020 16:16:25 GMT, Magnus Ihse Bursie wrote:
>> @magicus I did test the initial version of this PR on linux+arm64, but not
>> the latest iteration. sorry about that
>>
>> What is the policy here? Submit a revert right away or investigate a fix?
>
> @lewurm Open a new JBS issue
On Mon, 2 Nov 2020 16:52:02 GMT, Coleen Phillimore wrote:
>> I thought that we didn't load the archived heap from CDS, if JVMTI heap
>> walker capabilities are in place, as we didn't want this kind of
>> interactions. But maybe I'm missing something, since you said having this if
>> statement
On Mon, 2 Nov 2020 15:45:18 GMT, Erik Österlund wrote:
>> Because it crashed with my changes and didn't without. I cannot recollect
>> why.
>
> I thought that we didn't load the archived heap from CDS, if JVMTI heap
> walker capabilities are in place, as we didn't want this kind of
>
Hi Guys,
Please review the integration of tzdata2020d to JDK.
Details regarding the change can be viewed at -
https://mm.icann.org/pipermail/tz-announce/2020-October/62.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8255226
TestZoneInfo310.java test failure is addressed along with it.
On Mon, 2 Nov 2020 12:33:17 GMT, Magnus Ihse Bursie wrote:
> I'm just a bit curious about the added, empty,
> `src/java.desktop/share/native/libharfbuzz/abc.txt`...
>
> If it really is in upstream source, I'm not saying you should remove it. It
> just looks very odd. It's not a merge
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an
> OpenType text shaping library
>
> https://bugs.openjdk.java.net/browse/JDK-8247872
>
> This has passed building and headless and headful automated tests on all
> platforms.
Phil Race has updated the pull request
On Mon, 2 Nov 2020 15:18:43 GMT, Erik Österlund wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code review comments from StefanK.
>
>
On Mon, 2 Nov 2020 16:06:15 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm
>> This patch seems to break on linux-aarch64 with gcc:
>> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
>> comparison of integer expressions of different signedness: 'size_t' {aka
>> 'long
On Mon, 2 Nov 2020 12:50:23 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 954:
>>
>>> 952: o->klass()->external_name());
>>> 953: return;
>>> 954: }
>>
>> Why is this done as a part of this RFE? Is this a bug fix that should be
>>
On Mon, 2 Nov 2020 15:58:15 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
On Fri, 30 Oct 2020 17:40:51 GMT, Vladimir Kozlov wrote:
> We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an
> experimental feature. We shipped Graal as an experimental JIT compiler in JDK
> 10. We haven't seen much use of these features, and the effort required to
>
On Mon, 2 Nov 2020 15:41:06 GMT, Magnus Ihse Bursie wrote:
>> Thank you Andrew.
>
> @lewurm
> This patch seems to break on linux-aarch64 with gcc:
> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
> comparison of integer expressions of different signedness: 'size_t' {aka
On Mon, 2 Nov 2020 15:58:15 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table
On Mon, 2 Nov 2020 14:00:33 GMT, Bernhard Urban-Forster
wrote:
>>> Would you mind to sponsor it @theRealAph or @magicus?
>>
>> Hmm, I think you have to integrate it first.
>> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/sponsor
>
> Thank you Andrew.
On Mon, 2 Nov 2020 14:40:35 GMT, Erik Joelsson wrote:
> We have at least one java file with a '$' in the name. As we have learned
> over the years, having $ in unexpected places quickly leads to unexpected
> behavior in a shell/make based build. In this case it's our override
> mechanism of
On Fri, 30 Oct 2020 17:19:56 GMT, Erik Joelsson wrote:
> In JDK-8206311, when I introduced a new docs build profile, I forgot to add
> the version configure arguments to it. This causes the docs bundles for
> CI/promoted builds to be generated with the default adhoc version information
>
We have at least one java file with a '$' in the name. As we have learned over
the years, having $ in unexpected places quickly leads to unexpected behavior
in a shell/make based build. In this case it's our override mechanism of java
files that needs protection against expanding such
On Fri, 30 Oct 2020 17:19:56 GMT, Erik Joelsson wrote:
> In JDK-8206311, when I introduced a new docs build profile, I forgot to add
> the version configure arguments to it. This causes the docs bundles for
> CI/promoted builds to be generated with the default adhoc version information
>
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation (see JEP 393 [1]). This iteration
> focus on improving the usability of the API in 3 main ways:
>
> * first, by providing a way to obtain truly *shared* segments, which
On Mon, 2 Nov 2020 13:41:53 GMT, Andrew Haley wrote:
>> Marked as reviewed by aph (Reviewer).
>
>> Would you mind to sponsor it @theRealAph or @magicus?
>
> Hmm, I think you have to integrate it first.
>
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph (Reviewer).
> Would you mind to sponsor
On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
wrote:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64:
On Fri, 30 Oct 2020 20:46:31 GMT, Erik Joelsson wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
On Mon, 2 Nov 2020 08:08:53 GMT, Stefan Karlsson wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
On Fri, 30 Oct 2020 20:23:04 GMT, Coleen Phillimore wrote:
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
>
On Mon, 2 Nov 2020 08:34:17 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 126:
>>
>>> 124: // concurrent GCs. So fix it here once we have a lock or are
>>> 125: // at a safepoint.
>>> 126: // SetTag and GetTag should not post events!
>>
>> I think it would
On Mon, 2 Nov 2020 04:19:57 GMT, Phil Race wrote:
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an
> OpenType text shaping library
>
> https://bugs.openjdk.java.net/browse/JDK-8247872
>
> This has passed building and headless and headful automated tests on all
>
On Fri, 30 Oct 2020 20:23:04 GMT, Coleen Phillimore wrote:
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
>
On Fri, 30 Oct 2020 17:40:51 GMT, Vladimir Kozlov wrote:
> We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an
> experimental feature. We shipped Graal as an experimental JIT compiler in JDK
> 10. We haven't seen much use of these features, and the effort required to
>
On Mon, 2 Nov 2020 11:59:09 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation (see JEP 393 [1]). This
>> iteration focus on improving the usability of the API in 3 main ways:
>>
>> *
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation (see JEP 393 [1]). This iteration
> focus on improving the usability of the API in 3 main ways:
>
> * first, by providing a way to obtain truly *shared* segments, which
On Mon, 2 Nov 2020 08:25:28 GMT, Stefan Karlsson wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>>
On Fri, 30 Oct 2020 20:23:04 GMT, Coleen Phillimore wrote:
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
>
On Sun, 1 Nov 2020 16:06:32 GMT, Alan Bateman wrote:
> The javadoc for copyFrom isn't changed in this update but I notice it
> specifies IndexOutOfBoundException when the source segment is larger than the
> receiver, have other exceptions been examined?
This exception is consistent with other
On Sun, 1 Nov 2020 16:06:32 GMT, Alan Bateman wrote:
> Now that MemorySegment is AutoCloseable then maybe the term "alive" should be
> replaced with "open" or "closed" and isAlive replaced with isOpen is isClosed.
While the reason for the method being called "isAlive" are mostly historical
64 matches
Mail list logo
