On 12/03/2021 5:12 pm, Anton Kozlov wrote:
On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote:
Anton Kozlov has updated the pull request incrementally with one additional
commit since the last revision:
8262903: [macos_aarch64] Thread::current() called on detached thread
src/hotspot/s
On Fri, 12 Mar 2021 01:01:09 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8262903: [macos_aarch64] Thread::current() called on detached thread
>
> src/hotspot/share/runtime/safefetch.inline.hpp
> On 12-Mar-2021, at 10:30 AM, Sergey Bylokhov wrote:
>
> On Fri, 12 Mar 2021 00:09:54 GMT, Kevin Rushforth wrote:
>
>>> Ajit Ghaisas has updated the pull request with a new target base due to a
>>> merge or a rebase. The incremental webrev excludes the unrelated changes
>>> brought in by
> On 12-Mar-2021, at 9:29 AM, Scott Palmer wrote:
>
>
>> On Mar 11, 2021, at 9:53 PM, Sergey Bylokhov wrote:
>>
>> On Fri, 12 Mar 2021 02:29:04 GMT, Jayathirth D V wrote:
>>
src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java line
323:
> 321: * m
On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Fri, 12 Mar 2021 00:09:54 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
On Fri, 12 Mar 2021 01:04:22 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
On Fri, 12 Mar 2021 00:48:58 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
> On Mar 11, 2021, at 9:53 PM, Sergey Bylokhov wrote:
>
> On Fri, 12 Mar 2021 02:29:04 GMT, Jayathirth D V wrote:
>
>>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java line
>>> 323:
>>>
321: * more code just to support a few uncommon cases.
322: */
On Fri, 12 Mar 2021 02:29:04 GMT, Jayathirth D V wrote:
>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java line
>> 323:
>>
>>> 321: * more code just to support a few uncommon cases.
>>> 322: */
>>> 323: public boolean canRenderLCDText(SunGraphics2D sg2d) {
>>
On Fri, 12 Mar 2021 00:42:35 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Wed, 10 Mar 2021 11:43:43 GMT, Ajit Ghaisas wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java line
>> 304:
>>
>>> 302: };
>>> 303: }
>>> 304: public MTLLayer createMTLLayer() {
>>
>> TODO to test that this functionality wo
On Tue, 9 Mar 2021 20:16:25 GMT, Alexey Ushakov wrote:
>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLBlitLoops.java line 499:
>>
>>> 497: }
>>> 498:
>>> 499: // We can convert argb_pre data from MTL surface in two places:
>>
>> Does anybody check that this is true for
On Thu, 11 Mar 2021 14:53:22 GMT, Roger Riggs wrote:
>> Disable the "missing" target for java.smartcardio from doclint.
>
> Please assign a new bug and title to ignore/suppress the warnings.
> The original issue 8252833 should be left open.
> Thanks
Closing, as it's unclear which approach shou
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/2930
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Tue, 9 Mar 2021 17:55:12 GMT, Anton Kozlov wrote:
>> src/hotspot/share/runtime/thread.cpp line 2515:
>>
>>> 2513: void JavaThread::check_special_condition_for_native_trans(JavaThread
>>> *thread) {
>>> 2514: // Enable WXWrite: called directly from interpreter native wrapper.
>>> 2515: MA
On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi wrote:
> Hi, Please review
>
> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The
> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We
> should check ENABLE_CDS instead.
>
> Thanks
> Yumin
This pull requ
On Thu, 11 Mar 2021 18:42:53 GMT, Ioi Lam wrote:
>> Hi, Please review
>>
>> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The
>> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We
>> should check ENABLE_CDS instead.
>>
>> Thanks
>> Yumin
>
> LGTM
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi wrote:
> Hi, Please review
>
> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The
> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We
> should check ENABLE_CDS instead.
>
> Thanks
> Yumin
Looks good to
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi wrote:
> Hi, Please review
>
> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The
> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We
> should check ENABLE_CDS instead.
>
> Thanks
> Yumin
Marked as revi
Hi, Please review
JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason
is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should
check ENABLE_CDS instead.
Thanks
Yumin
-
Commit messages:
- 8263465: JDK-8236847 causes tier1 build failure
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi wrote:
> Hi, Please review
>
> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The
> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We
> should check ENABLE_CDS instead.
>
> Thanks
> Yumin
LGTM
On Thu, 11 Mar 2021 07:40:47 GMT, Alexey Ushakov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 45 additional
>> commits
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project -
On Mon, 8 Feb 2021 18:47:09 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m
>> line 82:
>>
>>> 80: (JNIEnv *env, jclass mtlgc)
>>> 81: {
>>> 82: FILE *f = popen("/usr/sbin/system_profiler SPDisplaysDataType",
>>> "r");
>>
>>
On Tue, 9 Mar 2021 23:15:57 GMT, Sergey Bylokhov wrote:
>> Also, MTLSD_WINDOW is supported
>
> How it is used? Can we really draw to the window directly? It looks like it
> copied from the OGL where it is unused since CLayer integration. Something is
> inconsistent here.
Here is a follow-up is
On Fri, 19 Feb 2021 18:15:45 GMT, Yumin Qi wrote:
> Hi, Please review
> Usually most OSes are configured with page size of 4K, but some others are
> configured with 64K. If jdk binary is built on 4K platform and run on
> different configured platforms, CDS fails to be loaded due to region
>
On Wed, 10 Mar 2021 18:33:53 GMT, Thomas Stuefe wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into jdk-8236847
>> - Merge master
>> - Add --enable-compatible-cds
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
Please assign a new bug and title to ignore/suppress the warnings.
The original issue 8252833 should be left open.
Thanks
-
Changes requested by rriggs (Rev
On Wed, 3 Mar 2021 15:57:13 GMT, Gerard Ziemski wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 207:
>>
>>> 205: // Enable WXWrite: this function is called by the signal handler at
>>> arbitrary
>>> 206: // point of execution.
>>> 207: ThreadWXEnable wx(WXWrite, thread);
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
Revoking approval.
-
Changes requested by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2930
On Thu, 11 Mar 2021 09:25:34 GMT, Magnus Ihse Bursie wrote:
>> Disable the "missing" target for java.smartcardio from doclint.
>
> Looks good to me.
... however, this fix does not achieve what the bug report is asking for.
The patch here will modify flags to javac. The JBS issue talks about fla
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
Looks good to me.
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2930
39 matches
Mail list logo
