> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removing preview
> related comments from APIs plus options in test cases. Please
On Thu, 6 May 2021 16:38:52 GMT, Phil Race wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> switch off warning in build instead of fixing it
>
> The policy is to do what you ended up doing. We (almost) never modify
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote:
>> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS
>> issue.
>>
>> I fixed the issue in the harfbuzz sources, but I am not sure of the policy
>> here. Do we modify the harfbuzz sources or leave them untouched? Advi
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote:
> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS
> issue.
>
> I fixed the issue in the harfbuzz sources, but I am not sure of the policy
> here. Do we modify the harfbuzz sources or leave them untouched? Advice is
On Thu, 6 May 2021 07:53:52 GMT, Richard Reingruber wrote:
> Looks good to me, thanks!
> Personally I'm building with gcc 9. I've test your fix successfully with gcc
> 7.5.
>
> Cheers, Richard.
Thanks Richard! I tested the build on Debian with gcc 7 and gcc 9, it worked.
Since I now have enou
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote:
>> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS
>> issue.
>>
>> I fixed the issue in the harfbuzz sources, but I am not sure of the policy
>> here. Do we modify the harfbuzz sources or leave them untouched? Advi
