Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-30 Thread Ioi Lam
On Mon, 30 Aug 2021 12:51:43 GMT, Daniel Fuchs wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dfuch comments > > make/jdk/src/classes/build/tools/classlist/SortClasslist.java line 58: > >> 56: String

Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-30 Thread Ioi Lam
> When the classlist is generated using build.tools.classlist.HelloClasslist, > its contents may be non-deterministic due to Java thread execution order. > > We should sort the generated classlist to make the JDK image's contents more > deterministic. > > Tested with Mach5 tier1, tier2,

Integrated: 8270438: "Cores to use" output in configure is misleading

2021-08-30 Thread Magnus Ihse Bursie
On Mon, 30 Aug 2021 13:06:19 GMT, Magnus Ihse Bursie wrote: > Description from the bug: > > When building the JDK and running `configure` the output includes (example): > > Build performance summary: > * Cores to use: 4 > * Memory limit: 32768 MB > > > The "Cores to use" value is

Re: RFR: 8270438: "Cores to use" output in configure is misleading

2021-08-30 Thread Erik Joelsson
On Mon, 30 Aug 2021 13:06:19 GMT, Magnus Ihse Bursie wrote: > Description from the bug: > > When building the JDK and running `configure` the output includes (example): > > Build performance summary: > * Cores to use: 4 > * Memory limit: 32768 MB > > > The "Cores to use" value is

Bumping minimum GCC from 5.x to 6.x?

2021-08-30 Thread Magnus Ihse Bursie
Hi all, There is an open request[1] to bump the minimum GCC version from 5 to 6. We've traditionally been very conservative with supporting old GCC versions, but GCC 6 was released in 2016 (compared to GCC 5 in 2015), and I think this sounds conservative enough. Would it create a lot of

RFR: 8270438: "Cores to use" output in configure is misleading

2021-08-30 Thread Magnus Ihse Bursie
Description from the bug: When building the JDK and running `configure` the output includes (example): Build performance summary: * Cores to use: 4 * Memory limit: 32768 MB The "Cores to use" value is misleading; it is not actually the number of cores specified using `--with-num-cores`,

Re: RFR: 8273092: Sort classlist in JDK image

2021-08-30 Thread Daniel Fuchs
On Fri, 27 Aug 2021 23:12:52 GMT, Ioi Lam wrote: > When the classlist is generated using build.tools.classlist.HelloClasslist, > its contents may be non-deterministic due to Java thread execution order. > > We should sort the generated classlist to make the JDK image's contents more >

Integrated: 8229031: Exporting CLASSPATH from shell can result in build failures

2021-08-30 Thread Magnus Ihse Bursie
On Fri, 27 Aug 2021 14:28:07 GMT, Magnus Ihse Bursie wrote: > Having the environment variable CLASSPATH set when building can cause > hard-to-diagnose build errors. We should not silently accept the CLASSPATH > variable when building. Normally, the classpath should be correctly setup for >

Re: RFR: 8273092: Sort classlist in JDK image

2021-08-30 Thread Magnus Ihse Bursie
On Fri, 27 Aug 2021 23:12:52 GMT, Ioi Lam wrote: > When the classlist is generated using build.tools.classlist.HelloClasslist, > its contents may be non-deterministic due to Java thread execution order. > > We should sort the generated classlist to make the JDK image's contents more >