Re: RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER

2021-11-24 Thread Erik Joelsson
On Wed, 24 Nov 2021 18:42:35 GMT, Andrew Leonard wrote: >> make/autoconf/basic.m4 line 99: >> >>> 97: >>> 98: # Setup username (for use in adhoc version strings etc) >>> 99: AC_ARG_WITH([build-user], [AS_HELP_STRING([--with-build-user], >> >> This variable is currently initiated in a

Re: RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER

2021-11-24 Thread Andrew Leonard
On Wed, 24 Nov 2021 17:36:03 GMT, Erik Joelsson wrote: >> To better allow "reproducible builds", a new configure parameter is added to >> set the USERNAME build variable, rather than always using the current user: >> --with-build-user= >> HOTSPOT_BUILD_USER is then set to a reproducible

Re: RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER

2021-11-24 Thread Erik Joelsson
On Wed, 24 Nov 2021 16:49:31 GMT, Andrew Leonard wrote: > To better allow "reproducible builds", a new configure parameter is added to > set the USERNAME build variable, rather than always using the current user: > --with-build-user= > HOTSPOT_BUILD_USER is then set to a reproducible

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-24 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: fix whitespace error, add missing code tag

Re: RFR: 8277459: Add jwebserver tool [v2]

2021-11-24 Thread Daniel Fuchs
On Wed, 24 Nov 2021 17:15:35 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since

Re: RFR: 8277459: Add jwebserver tool [v2]

2021-11-24 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments: * update module and

RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER

2021-11-24 Thread Andrew Leonard
To better allow "reproducible builds", a new configure parameter is added to set the USERNAME build variable, rather than always using the current user: --with-build-user= HOTSPOT_BUILD_USER is then set to a reproducible USERNAME if required. Signed-off-by: Andrew Leonard -

Re: Integrated: 8275063: Implementation of Foreign Function & Memory API (Second incubator)

2021-11-24 Thread Maurizio Cimadamore
I think this discussion should go either on core-libs or on panama-dev. build-dev is not the place for it. I'm addding panama-dev - and then I'll reply from there. Maurizio On 24/11/2021 16:15, Ty Young wrote: Was this code actually reviewed or even used/tested at all? All "Java"

Re: Integrated: 8275063: Implementation of Foreign Function & Memory API (Second incubator)

2021-11-24 Thread Ty Young
Was this code actually reviewed or even used/tested at all? All "Java" ValueLayouts have an 8-bit alignment, even if they are 2-byte, 4-byte, or 8-byte in size:

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Julia Boes
On Wed, 24 Nov 2021 11:57:16 GMT, Daniel Fuchs wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java > line 110:

RE: Xcode version output when devkit is used

2021-11-24 Thread Baesken, Matthias
>It sounds like a bug that should get fixed. :) > >Let me just verify that I understand this correctly. Your specified >devkit is used to actually compile the JDK, it's just in the configure >script output that things look wrong? (I suspect this will also mess up >version checking for clang in

Re: Xcode version output when devkit is used

2021-11-24 Thread Magnus Ihse Bursie
On 2021-11-24 12:50, Baesken, Matthias wrote: Hi, I noticed a small issue when using an XCode devkit (--with-devkit pointing to XCode 13.1 in this case.) in the jdk/jdk build. In the configure output, we get this : configure: Xcode major version: 10 *

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Magnus Ihse Bursie
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Build changes look good.

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Daniel Fuchs
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/resources/simpleserver.properties

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Daniel Fuchs
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java line 110: > 108: *

Integrated: 8275063: Implementation of Foreign Function & Memory API (Second incubator)

2021-11-24 Thread Maurizio Cimadamore
On Tue, 12 Oct 2021 11:16:51 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] -

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Julia Boes
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. This change adds a dedicated command-line tool for the Simple Web Server, to improve convenience

RFR: 8277460: Add jwebserver tool

2021-11-24 Thread Julia Boes
This change introduces jwebserver, a dedicated JDK tool for the Simple Web Server. A description is provided in a follow-up comment. - Commit messages: - update module summary - Merge branch 'master' into jwebserver - add version option, consolidate tests, update module and

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v3]

2021-11-24 Thread Magnus Ihse Bursie
On Tue, 23 Nov 2021 19:23:40 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >>