RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

2021-12-03 Thread Sergey Bylokhov
The "missing-explicit-ctor" check was disabled by the [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). So we can re-enable this check again. The fix will remove the "Java.gmk" file and as

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > does this; it wou

Integrated: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > does this; it wou

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Phil Race
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > does this; it wou

Re: RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation [v2]

2021-12-03 Thread Rajan Halade
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote: >> Addition of a configure option --with-cacerts-src='user cacerts folder' to >> allow developers to specify their own cacerts PEM folder for generation of >> the cacerts store using the deterministic openjdk GenerateCacerts tool. >> >> Si

Re: RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation

2021-12-03 Thread Sergey Bylokhov
On Thu, 2 Dec 2021 10:55:57 GMT, Andrew Leonard wrote: > This is the case at Adoptium for example, which uses the Mozilla trusted CA > certs. But they didn't think skipping this test was too strong a step? For example validation of the certs expiration is quite useful. I tried to update the te

Integrated: JDK-8278179: Enable all doclint warnings for build of java.naming

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy wrote: > An exploratory build indicates that it is not necessary to disable the > accessibility doclint check for the java.naming module. This pull request has now been integrated. Changeset: 780b8b10 Author:Joe Darcy URL: https://git.open

Integrated: 8251400: Fix incorrect addition of library to test in JDK-8237858

2021-12-03 Thread Magnus Ihse Bursie
On Thu, 2 Dec 2021 22:45:37 GMT, Magnus Ihse Bursie wrote: > In JDK-8237858, -pthread was added to all native tests, instead of the one > single test that needed it. In the meantime, two new tests with pthread > dependencies has crept in unnoticed due to this. This pull request has now been in

Re: RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858

2021-12-03 Thread Magnus Ihse Bursie
On Fri, 3 Dec 2021 03:22:03 GMT, David Holmes wrote: >> In JDK-8237858, -pthread was added to all native tests, instead of the one >> single test that needed it. In the meantime, two new tests with pthread >> dependencies has crept in unnoticed due to this. > > Looks good. > > I don't think `-

Re: RFR: JDK-8272945: Use snippets in java.compiler documentation

2021-12-03 Thread Erik Joelsson
On Fri, 3 Dec 2021 00:41:23 GMT, Magnus Ihse Bursie wrote: >> Please review a patch to use snippets in the `java.compiler` documentation, >> instead of a mix of raw HTML and/or `{@code ...}`. The change is just about >> the presentation of the code fragments; there are no changes to the >> no

Re: RFR: JDK-8278179: Enable all doclint warnings for build of java.naming

2021-12-03 Thread Erik Joelsson
On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy wrote: > An exploratory build indicates that it is not necessary to disable the > accessibility doclint check for the java.naming module. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6688

Re: RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858

2021-12-03 Thread Erik Joelsson
On Thu, 2 Dec 2021 22:45:37 GMT, Magnus Ihse Bursie wrote: > In JDK-8237858, -pthread was added to all native tests, instead of the one > single test that needed it. In the meantime, two new tests with pthread > dependencies has crept in unnoticed due to this. Marked as reviewed by erikj (Revi

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Erik Joelsson
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > does this; it wou

Integrated: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup

2021-12-03 Thread Andrew Leonard
On Thu, 2 Dec 2021 21:07:30 GMT, Andrew Leonard wrote: > PR https://github.com/openjdk/jdk/pull/6647 resolved the GENDATA_CACERTS_SRC > fir --with-cacerts-src after the recipe, which meant the dependencies were > wrong. > This PR moves it before the recipe. > > Signed-off-by: Andrew Leonard

Re: RFR: JDK-8272945: Use snippets in java.compiler documentation

2021-12-03 Thread Alan Bateman
On Fri, 3 Dec 2021 00:26:10 GMT, Jonathan Gibbons wrote: > Please review a patch to use snippets in the `java.compiler` documentation, > instead of a mix of raw HTML and/or `{@code ...}`. The change is just about > the presentation of the code fragments; there are no changes to the normative