Re: Warning about git from 'make test' on Windows

2022-06-13 Thread Bradford Wetmore
Andrey/Christoph, This may be a little late, but... Maybe this gives a hint on how to fix it? I (and others in my group) typically use the root c:/cygwin and avoid this whole issue. Brad On 6/3/2022 12:09 AM, Langer, Christoph wrote: Hi, I see the same on my windows build. I verified

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Bradford Wetmore
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/theā€¦ > > It's the last issue in the series, and it still touches different areas of > the code. Looked at -java.security.jgss. LGTM --

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Bradford Wetmore
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo LGTM also. Similar suggestion for updating copyrights. - Marked as reviewed by wetmore (Reviewer). PR: https:/

[jdk17] Integrated: 8268901: JDK-8268768 missed removing two files

2021-06-16 Thread Bradford Wetmore
On Wed, 16 Jun 2021 16:16:51 GMT, Bradford Wetmore wrote: > JDK-8268768 reverted a couple putbacks that changed the way the idea projects > are generated. > > Two new template files from JDK-8267706 were missed, and will be removed in > this fix. > > See original bu

[jdk17] RFR: 8268901: JDK-8268768 missed removing two files

2021-06-16 Thread Bradford Wetmore
JDK-8268768 reverted a couple putbacks that changed the way the idea projects are generated. Two new template files from JDK-8267706 were missed, and will be removed in this fix. See original bug for further details. - Commit messages: - 8268901: JDK-8268768 missed removing two

Integrated: 8263827: Suspend "missing" javadoc doclint checks for smartcardio

2021-03-18 Thread Bradford Wetmore
On Thu, 18 Mar 2021 18:49:22 GMT, Bradford Wetmore wrote: > Build change only. This is to prevent javadoc build failures in > java.smartcardio when "missing" is eventually removed from the doclint > exclude target list. > > This is a follow-on to JDK-8252833, which is

RFR: 8263827: Suspend "missing" javadoc doclint checks for smartcardio

2021-03-18 Thread Bradford Wetmore
Build change only. This is to prevent javadoc build failures in java.smartcardio when "missing" is eventually removed from the doclint exclude target list. This is a follow-on to JDK-8252833, which is a subtask of JDK-8251202. - Commit messages: - jcheck/whitespace problem - Merg

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Bradford Wetmore
On Thu, 11 Mar 2021 14:53:22 GMT, Roger Riggs wrote: >> Disable the "missing" target for java.smartcardio from doclint. > > Please assign a new bug and title to ignore/suppress the warnings. > The original issue 8252833 should be left open. > Thanks Closing, as it's unclear which approach shou

Withdrawn: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-11 Thread Bradford Wetmore
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2930

RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Bradford Wetmore
Disable the "missing" target for java.smartcardio from doclint. - Commit messages: - Forgot copyright date update - 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module Changes: https://git.openjdk.java.net/jdk/pull/2930/files Webrev: https://webrevs.ope

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-11 Thread Bradford Wetmore
On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy wrote: >> 1) This is un-necessary churn. >> 2) I can't even be sure I am finding the ones in my area because there's so >> much here >> 3) The ones I can find have no need of whatever performance improvement this >> might bring. >> I think th

Re: JDK-8244763: Update --release 8 symbol information after JSR 337 MR3

2020-05-18 Thread Bradford Wetmore
Thanks again Jan for looking into and fixing this. I looked over the new entries last week, and the new MR3 ALPN/PSS items looked good. My only comment is that as a newbie to this area, the "header" attribute includes the "innerclass" parameters: innerclass isn't an attribute on its own whi

Re: RFR: JDK-8244093 Move all IDE support into coherent structure in make directory

2020-05-06 Thread Bradford Wetmore
On 4/30/2020 12:28 AM, Jan Lahoda wrote: Hi Brad, This is very similar to what I do. Some small comments inline. On 29. 04. 20 21:02, Bradford Wetmore wrote: Jan, What is your current recommended technique to use NetBeans to build/edit/test OpenJDK for normal OpenJDK library developers

Re: RFR: JDK-8244093 Move all IDE support into coherent structure in make directory

2020-04-29 Thread Bradford Wetmore
Jan, What is your current recommended technique to use NetBeans to build/edit/test OpenJDK for normal OpenJDK library developers? After many versions of Netbeans, my current setup is to: 1. Do an external "exploded" build 2. Run Netbeans, open the src/java.base module project and any other

Re: RFR: JDK-8176033: New cygwin grep does not match \r as newline

2017-03-01 Thread Bradford Wetmore
Looks ok to me too, but I see it's already been pushed. Since I doubt the JPRG machines are new enough, I will reload the new grep onto my machine and ensure it works. Unless you hear from me, assume we're ok. Brad On 3/1/2017 9:24 AM, Magnus Ihse Bursie wrote: Looks good to me. /Magnu

RFR: 8170157/8169335: Unlimited Cryptography Policy Changes

2016-12-02 Thread Bradford Wetmore
Hi, I need reviewers for these related bugs: https://bugs.openjdk.java.net/browse/JDK-8170157 Enable unlimited cryptographic policy by default in OracleJDK https://bugs.openjdk.java.net/browse/JDK-8169335 Add a crypto policy fallback in case Security Property 'crypto.policy' does not exis

Re: RFR: 8157561 :Ship the unlimited policy files in JDK Updates

2016-11-07 Thread Bradford Wetmore
~coffeys/webrev.8157561.8u.jdk.v5/webrev/ Regards, Sean. On 04/11/16 22:56, Bradford Wetmore wrote: I didn't see anything majorly different in what I looked at earlier, I didn't check java.security or the test case. CryptoLevel.java 49: Your usage mentions only unlimited|limited.

Re: RFR: 8157561 :Ship the unlimited policy files in JDK Updates

2016-11-04 Thread Bradford Wetmore
I didn't see anything majorly different in what I looked at earlier, I didn't check java.security or the test case. CryptoLevel.java 49: Your usage mentions only unlimited|limited. Do you want to include a check for that? JceSecurity.java 300: Indention pr

Re: RFR: JDK-8165314: Javac server process left running if build fails on Windows

2016-09-02 Thread Bradford Wetmore
P.S. It fixed the problem on my Windows build. Thanks! Brad On 9/2/2016 1:13 PM, Bradford Wetmore wrote: Looks good to me. Ditto. Always learn something new about gmake reading the build code. Thanks for adding the ReportBuildTimes. That's a nice thing to have. Brad On 9/2/2

Re: RFR: JDK-8165314: Javac server process left running if build fails on Windows

2016-09-02 Thread Bradford Wetmore
> Looks good to me. Ditto. Always learn something new about gmake reading the build code. Thanks for adding the ReportBuildTimes. That's a nice thing to have. Brad On 9/2/2016 8:02 AM, Tim Bell wrote: On 09/02/16 05:16, Erik: The symptom of this problem is that if the build fails, quic

Re: RFR 8074838: Resolve disabled warnings for libj2pkcs11

2016-08-25 Thread Bradford Wetmore
Looks ok to me... I had to look at the C declaration one twice. Too much Java, not enough C lately. Brad On 8/25/2016 2:20 PM, Anthony Scarpino wrote: Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the pkcs1

Fwd: RFR: 8061842: Package jurisdiction policy files as something other than JAR

2016-08-17 Thread Bradford Wetmore
Forwarding from security-dev to build-dev, as there is a change proposed for the way the cryptographic policy files are built. https://bugs.openjdk.java.net/browse/JDK-8061842 http://cr.openjdk.java.net/~wetmore/8061842/webrev.01/ The proposal is to move the configuration files from the jar fi

Re: RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

2016-06-29 Thread Bradford Wetmore
Jesper, This is not a review comment, but could you tell us how these netbeans projects are supposed to be used? To do my JDK debugging, I usually create an exploded JDK build using the normal make files, then in Netbeans created a new platform that pointed at the build/*/jdk directory, then

Re: RFE/RFC reproducible policies

2016-05-26 Thread Bradford Wetmore
Hi Jiri, This is open issue #2 from JEP-220 [1] that we still need to address for JDK 9, so your patch will likely be moot soon. It's possible that the jar will be going away. If you would like to watch the progress, please add yourself to: JDK-8061842: Package jurisdiction policy files as

Re: build failure in perfMemory_solaris.cpp?

2015-01-23 Thread Bradford Wetmore
Is there a bug id yet? I haven't seen one showing up in a quick search for dd_fd or perfMemory_solaris.cpp. For the record, I'm on what I think is the required platform/compilers: % uname -a SunOS sca00bkv 5.11 11.1 sun4v sparc sun4v % more /etc/release Oracle Sola

Re: RFR: JDK-8068748: missing US_export_policy.jar in jdk9-b44 is causing compilation errors building jdk9 source code

2015-01-15 Thread Bradford Wetmore
Looks good, thanks for fixing this! Brad On 1/15/2015 3:05 AM, Erik Joelsson wrote: Hello, Please review the open part of this patch, which changes the building of policy jars to happen even if BUILD_CRYPTO is false. Previously these weren't built as there were signed versions of these jars

Re: RFR: JDK-8058845 : Update JCE environment for build improvements

2014-09-25 Thread Bradford Wetmore
javax/crypto/JceSecurity.java line 79: this could be (PrivilegedExceptionAction) as the return value is ignored Good catch. It may be better to rename URLVerifier to ProviderVerifier as it verifies the security provider of the given codebase. URLVerifier might give an interpretation

RFR: JDK-8058845 : Update JCE environment for build improvements

2014-09-21 Thread Bradford Wetmore
Hi Sean/Mandy/Erik/Magnus/Alan/David/others, Please review: JDK-8058845 : Update JCE environment for build improvements http://cr.openjdk.java.net/~wetmore/8058845/ This change is to alleviate some of the overly-complicated steps we (Oracle) have in building and maintaining the JCE ja

Re: .hgignore missing webrevs?

2014-09-11 Thread Bradford Wetmore
many directories have that pattern: ./hotspot/test/runtime/7162488 ./hotspot/test/runtime/7162488/Test7162488.sh so decided against it. [1] On 9/10/2014 7:21 PM, John Rose wrote: On Sep 10, 2014, at 4:22 PM, Bradford Wetmore mailto:bradford.wetm...@oracle.com>> wrote: My or

Re: .hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
. Brad On 9/10/2014 4:18 PM, Jonathan Gibbons wrote: The langtools/ change is OK by me. -- Jon On 09/10/2014 04:11 PM, Bradford Wetmore wrote: I created: https://bugs.openjdk.java.net/browse/JDK-8058180 The code review is: http://cr.openjdk.java.net/~wetmore/8058180/open/ Brad

Re: .hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
I created: https://bugs.openjdk.java.net/browse/JDK-8058180 The code review is: http://cr.openjdk.java.net/~wetmore/8058180/open/ Brad On 9/10/2014 12:00 PM, Bradford Wetmore wrote: I've noticed in various repos that the .hgignore files include variations on webrev, ^webrev

.hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
I've noticed in various repos that the .hgignore files include variations on webrev, ^webrev/, or leave it out completely. In other words, it's inconsistent. Mark offered: http://mail.openjdk.java.net/pipermail/build-dev/2008-February/000742.html which add your own personal .hgignore file

Re: RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

2014-03-18 Thread Bradford Wetmore
Looks good. Brad On 3/18/2014 8:04 AM, Tim Bell wrote: Hi Erik: On 2014-03-18 11:42, Erik Joelsson wrote: Please review this very simple fix to unzipping pre built security classes. When building incrementally, unzip will go into interactive mode and ask if it should overwrite files. The fi

Re: JDK9 build failure on Windows : javac OutOfMemoryError

2014-03-13 Thread Bradford Wetmore
Phil, That looks exactly like my problem. http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012089.html Subject: Heads Up: OutOfMemoryError when building a 64-bit JDK 9 using a 32-bit bootdir. > Yes, 32 bit it appears, although I didn't supply the boot dir option, > it chose it al

Heads Up: OutOfMemoryError when building a 64-bit JDK 9 using a 32-bit bootdir.

2014-03-09 Thread Bradford Wetmore
For quite some time I've been building on my Windows 7 laptop using something like this: % bash configure --enable-debug \ --with-boot-jdk=/cygdrive/d/java/bootdirs/i586/jdk1.7.0_XX As of Wed, my builds started dying in the big "compile the JDK world" javac part [1] of the jdk repo with

Re: RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Bradford Wetmore
On 2/25/2014 6:13 AM, Kumar Srinivasan wrote: Never mind it is indeed the same issue, I found the bug filed by Brad on this. Just FYI, this morning's push addressed my problem. Brad Thanks Kumar On 2/25/2014 6:11 AM, Kumar Srinivasan wrote: Hello Magnus, On our team CI server we are s

Re: JDK 9 RFR of JDK-8032734: Add cast lint warning to build of jdk repository

2014-01-27 Thread Bradford Wetmore
Looks good here also. :) brad On 1/27/2014 12:19 AM, Dave Pointon wrote: Hi Joe , On Fri, 2014-01-24 at 13:45 -0800, Joe Darcy wrote: Hello, Work has started to clear the jdk repo of the "cast" category of lint warnings (JDK-8032733, "Fix cast lint warnings in client libraries"). Anticipa

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
P.S. Forgot to mention, this looks good to me. Thanks for jumping in on this one. ;) Brad On 1/9/2014 12:07 AM, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & si

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
On 1/9/2014 12:34 AM, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_V

Re: How to increment JDK_MINOR_VERSION for JDK 9? -- request for review

2013-12-19 Thread Bradford Wetmore
This is blocking JDK-8030823 (JCE prebuilt jar files), so I looked at it also. Ditto the comments from Erik. The plan is these @ignores will be pulled out when 8030656 is fixed? Brad On 12/19/2013 1:38 AM, Erik Joelsson wrote: Build change looks good to me. I'm not familiar with the tests

Re: [8]: help on PKCS#11 tests build

2013-12-04 Thread Bradford Wetmore
IIRC, and in case it wasn't clear from reading the responses, the permission changes are done by the Makefiles (e.g. jdk/test/Makefile:193), and not by JTREG itself. I agree with Jon's comment, perhaps a .dll copy to the temporary working directory is in order. That would save people trying t

Re: RFR: JDK-8027963: Create unlimited policy jars.

2013-12-02 Thread Bradford Wetmore
Erik, Given the name of your workspace /localhome/hg/jdk8-tl, I'm assuming this will be going through the TL gate instead of build? Please do use tl, as there will be some parallel changes to the RE scripts that I need to make, and we won't be surprised when the changes hit the gate weeks l

Re: RFR: JDK-8027963: Create unlimited policy jars.

2013-11-27 Thread Bradford Wetmore
Erik, Thanks so much for handling much of the build work here. I was planning on doing it, but you've got the background in the new build-infra so this probably much easier for you. I've enjoyed learning new GnuMake techniques. I've reviewed this pretty well, but didn't hit the previous 2

Re: Removal of the old build system, partial review

2013-11-06 Thread Bradford Wetmore
On 11/6/2013 9:31 PM, Bradford Wetmore wrote: I've looked over: jdk/make/com/oracle/security/ucrypto jdk/make/com/sun/crypto/provider jdk/make/com/sun/security jdk/make/java/security jdk/make/javax/crypto There may be some things we want to add back as part of the work ErikJ/

Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-06 Thread Bradford Wetmore
I've looked at: jdk/makefiles/CreateSecurityJars.gmk jdk/make/data/cryptopolicy My only comment is the non-CamelCase style names (swingbeaninfo/cryptopolicy/characterdata/charsetmapping/etc), but I guess I can live with it. Brad On 11/1/2013 6:43 AM, Magnus Ihse Bursie wrote: Here is p

Re: Removal of the old build system, partial review

2013-11-06 Thread Bradford Wetmore
I've looked over: jdk/make/com/oracle/security/ucrypto jdk/make/com/sun/crypto/provider jdk/make/com/sun/security jdk/make/java/security jdk/make/javax/crypto There may be some things we want to add back as part of the work ErikJ/I are doing jdk/make/javax/others jdk/make/javax/rmi jdk/ma

Re: RFR: JDK-8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-05 Thread Bradford Wetmore
On 11/5/2013 1:31 AM, Erik Joelsson wrote: On 2013-11-04 20:57, Bradford Wetmore wrote: Hi Erik, Thanks for the update! Looks good, but one minor comment: SignJars.gmk 78:100:106:111-116 > 80 chars per line. Thanks. We have not enforced 80 chars in any other file in the

Re: RFR: JDK-8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-04 Thread Bradford Wetmore
low. I must have missed the save button before generating the webrev when adding ucrypto.jar, but it's there now at least. /Erik On 2013-11-02 01:35, Bradford Wetmore wrote: On 11/1/2013 3:34 AM, Erik Joelsson wrote: Please review this simple fix, adding sunmscapi.jar and ucrypto.jar to

Re: RFR: JDK-8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-01 Thread Bradford Wetmore
On 11/1/2013 3:34 AM, Erik Joelsson wrote: Please review this simple fix, adding sunmscapi.jar and ucrypto.jar to the list of jars to be signed by the sign-jars target. Since these jars are platform dependent, they aren't always present. Bug: https://bugs.openjdk.java.net/browse/JDK-8027698 We

Re: Heads up: New version of CYGWIN's cache breaks the windows build.

2013-11-01 Thread Bradford Wetmore
On 10/31/2013 4:51 PM, Mike Duigou wrote: Magnus indicated in another thread earlier today that ccache doesn't do anything on windows since we use the microsoft compilers. --disable-ccache or uninstall it. I filed an RFE to disable ccache on windows. Mike On Oct 31 2013, at 15:50 , Bradfo

Re: Heads up: New version of CYGWIN's cache breaks the windows build.

2013-10-31 Thread Bradford Wetmore
P.S. This version of ccache was added two days ago. Brad On 10/31/2013 3:42 PM, Bradford Wetmore wrote: I just rebuilt my CYGWIN, and got ccache 3.1.9-2, which enables ccache in the new build environment. fixpath.exe does not play well with it. Please see: https://bugs.openjdk.java.net

Heads up: New version of CYGWIN's cache breaks the windows build.

2013-10-31 Thread Bradford Wetmore
I just rebuilt my CYGWIN, and got ccache 3.1.9-2, which enables ccache in the new build environment. fixpath.exe does not play well with it. Please see: https://bugs.openjdk.java.net/browse/JDK-8027683 JDK-8027683: New version of CYGWIN includes ccache 3.1.9-2, breaks the windows build. Th

Re: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security

2013-10-22 Thread Bradford Wetmore
On 10/22/2013 7:52 AM, Erik Joelsson wrote: Trying this again. Here is a new webrev against jdk8/build. Again, this solves the issue detailed by Alan in this bug. http://cr.openjdk.java.net/~erikj/8009280/webrev.04/ There will probably be more issues in "JDK-8006350 [build] JCE unusable using

Re: RFR: JDK-8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low

2013-10-22 Thread Bradford Wetmore
Looks good to me also. Brad On 10/22/2013 3:19 PM, Magnus Ihse Bursie wrote: On 2013-10-23 00:14, David Katleman wrote: Please review this simple fix, addressing a problem with yesterday's integration of JDK-8026528. NewMakefile.gmk was extended to recognize version 4 of make, but in the pro

Re: CYGWIN make is now at 4.01.

2013-10-21 Thread Bradford Wetmore
0/2013 10:58 AM, Tim Bell wrote: On 10/20/13 09:49 AM, Bradford Wetmore wrote: Have not researched how 4.01 is different from 3.82.90-1. Has anyone tried it? As an FYI, 3.81 is no longer available from the normal Cygwin "setup" distribution. The "previous" version is now 3.

CYGWIN make is now at 4.01.

2013-10-20 Thread Bradford Wetmore
Have not researched how 4.01 is different from 3.82.90-1. Has anyone tried it? As an FYI, 3.81 is no longer available from the normal Cygwin "setup" distribution. The "previous" version is now 3.82.90-1. Brad

Re: RFR: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-16 Thread Bradford Wetmore
On 10/16/2013 7:00 PM, David Holmes wrote: On 17/10/2013 11:55 AM, Bradford Wetmore wrote: Updated webrev: http://cr.openjdk.java.net/~wetmore/8026762/ Assuming this gets through a full JPRT build SHIP IT! :) Yes, that is my SOP! Brad Thanks, David Brad On 10/16/2013 6:35 PM

Re: RFR: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-16 Thread Bradford Wetmore
Updated webrev: http://cr.openjdk.java.net/~wetmore/8026762/ Brad On 10/16/2013 6:35 PM, Bradford Wetmore wrote: Ok, David Holmes, I will back out the indention changes. Thanks, David Katleman, my build just died with the issue you and Tim Bell found. So Windows TL is still broken. I&#x

Re: RFR: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-16 Thread Bradford Wetmore
13 11:10 AM, Bradford Wetmore wrote: http://cr.openjdk.java.net/~wetmore/8026762/webrev/ The JDK build broke because the JDK couldn't find the CORBA inbound files. Needs to be quoted due to Windows separator being a semi-colon: JAVAC: is path separator CYGWIN: is statement/command se

RFR: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-16 Thread Bradford Wetmore
http://cr.openjdk.java.net/~wetmore/8026762/webrev/ The JDK build broke because the JDK couldn't find the CORBA inbound files. Needs to be quoted due to Windows separator being a semi-colon: JAVAC: is path separator CYGWIN: is statement/command separator I also did two minor indention clea

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-11 Thread Bradford Wetmore
It never worked like it did in Teamware. Brad On 10/11/2013 11:33 AM, Mike Duigou wrote: I should also ask if anyone is using the -l option. I would like to delete it as well as it offers no particular value for mercurial (that I can tell). Mike On Oct 10 2013, at 17:20 , Weijun Wang wrote:

Re: X509CertImpl.java compilation error on linux-x86

2013-10-11 Thread Bradford Wetmore
Offhand, no idea. Instance lives in sun.security.getInstance, and you're finding that class. I haven't tried out sjavac, but given the warning build/linux-x86-normal-server-release/jdk/classes/javac_state, and that I've never seen this directory, might you be triggering a sjavac bug? If you

Re: RFR: 8025612: rt.jar still has old specification value in the manifest

2013-10-11 Thread Bradford Wetmore
As the submitter, I also agree with this part of the fix and all comments made here. ;) Erik, one thing I did not check is whether other .jars in j2re/j2sdk use a different manifest template than the one you modified. Have you checked them all? You do not need to check these .jars, they wil

Re: Commit responsibilities and Lines of Defense

2011-02-22 Thread Bradford Wetmore
>> Kelly just wrote: >> >> It's not clear...and slightly augmented by the openjdk bugzilla. >> > >> > I think Andrew was referring to http://bugs.openjdk.java.net. > I was. I'm not sure what else the phrase "OpenJDK bug database" > would refer to. There were several bug systems mentioned

hg: jdk7/build/jdk: 6647452: Remove obfuscation, framework and provider self-verification checking

2009-08-03 Thread bradford . wetmore
Changeset: fe61ef5aada9 Author:wetmore Date: 2009-08-03 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fe61ef5aada9 6647452: Remove obfuscation, framework and provider self-verification checking Reviewed-by: valeriep, vinnie ! make/com/sun/crypto/provider/Makefile !

jdk7/jsn/langtools: 4 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 5f835b2631d9 Author:tbell Date: 2007-11-12 20:54 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/5f835b2631d9 7654322: touch all Makefiles ! make/Makefile ! src/share/opensource/javac/Makefile ! test/Makefile Changeset: aef3dd3f6a18 Author:ohair Date:

jdk7/jsn/jdk: 27 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: b438378d48a9 Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/b438378d48a9 Added junk + junk Changeset: 0fe0b1b794be Author:ohair Date: 2007-11-09 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/0fe0b

jdk7/jsn/jaxws: 12 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: d861124b4394 Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxws/rev/d861124b4394 Added junk + junk Changeset: d0da022294cf Author:ohair Date: 2007-11-09 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxws/rev/d

jdk7/jsn/jaxp: 13 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 2030d4b64c3f Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxp/rev/2030d4b64c3f Added junk + junk Changeset: ad6c1ff92c0a Author:ohair Date: 2007-11-09 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxp/rev/ad6

jdk7/jsn/hotspot: 12 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 4fbb76406145 Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/4fbb76406145 Added junk + junk Changeset: 036a6d4ba0ac Author:ohair Date: 2007-11-09 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/r

jdk7/tl/langtools: 9 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 8d2bb475b3dd Author:wetmore Date: 2007-11-12 16:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8d2bb475b3dd Hello there, Duke! ! make/Makefile Changeset: 3191daff8073 Author:wetmore Date: 2007-11-12 17:07 -0800 URL: http://hg.openjdk.java.

jdk7/jsn/corba: 13 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 22306825ab5e Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/corba/rev/22306825ab5e Added junk + junk Changeset: 2e1498855d17 Author:ohair Date: 2007-11-09 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/corba/rev/2

jdk7/jsn: 34 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: cbb2915931cd Author:ohair Date: 2007-11-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/cbb2915931cd Added junk + junk Changeset: e1bdac1823a1 Author:xdono Date: 2007-11-09 15:56 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/e1bdac1823a1

jdk7/tl/jdk: 6 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: ff6031bc8f2c Author:wetmore Date: 2007-11-16 17:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff6031bc8f2c Move along, nothing to see here in the open. ! make/Makefile Changeset: 136e95de6f4a Author:chegar Date: 2007-11-28 16:18 + URL: http

jdk7/tl/jaxp: 2 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 2360a49d0e35 Author:weijun Date: 2007-11-28 18:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/2360a49d0e35 More README ! README Changeset: 17fd03b47103 Author:wetmore Date: 2007-12-04 15:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev

jdk7/tl/corba: 6 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: 51dc87a1de64 Author:weijun Date: 2007-11-29 10:52 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/51dc87a1de64 Second Try ! README Changeset: 4cbbdfccc885 Author:weijun Date: 2007-11-30 01:17 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev

jdk7/tl: 2 new changesets

2007-12-04 Thread bradford . wetmore
Changeset: a601faeb7172 Author:wetmore Date: 2007-11-16 18:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/a601faeb7172 Nothing to see here, daughter ! Makefile Changeset: bb6d85f9e68e Author:wetmore Date: 2007-12-04 15:23 -0800 URL: http://hg.openjdk.java.net/

jdk7/jsn/jdk: Move along, nothing to see here in the open.

2007-11-16 Thread bradford . wetmore
Changeset: ff6031bc8f2c Author:wetmore Date: 2007-11-16 17:57 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ff6031bc8f2c Move along, nothing to see here in the open. ! make/Makefile

jdk7/jsn: Nothing to see here, daughter

2007-11-16 Thread bradford . wetmore
Changeset: a601faeb7172 Author:wetmore Date: 2007-11-16 18:10 -0800 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/a601faeb7172 Nothing to see here, daughter ! Makefile