Re: RFR: 8285755: JDK-8285093 changed the default for --with-output-sync

On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote: > The make option '--output-sync recurse' can be useful in certain situations, > especially when dealing with very verbose output from makefiles and you want > to parse them after the fact. However, when running make interactively on the

Integrated: 8277517: Bump minimum boot jdk to JDK 18

On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds This pull request has now been integrated. Changeset: 46ce2ef1 Author:Mikael Vidstedt URL:

Re: RFR: 8277517: Bump minimum boot jdk to JDK 18

On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds Adding a random comment here in the hopes that it will generate an email and give everyb

Integrated: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

On Sun, 27 Mar 2022 05:08:52 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of Visual Studio for building the JDK on > Windows to Visual Studio 2022 17.1.0. > > This change adds support for building devkits based on VS 2022. Instead of > creating a new script

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v4]

with the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull requ

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v3]

On Mon, 28 Mar 2022 16:05:03 GMT, Mikael Vidstedt wrote: >> make/devkit/createWindowsDevkit.sh line 74: >> >>> 72: # Work around the insanely named ProgramFiles(x86) env variable >>> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v3]

with the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull request inc

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v2]

with the logic in > createWindowsDevkit2019.sh and rename the resulting file. I decided to > dropped support for VS 2017 since that version is pretty old now, let me know > if you'd prefer to see it kept around. > > Testing: tier1-5 + additional testing. Mikael Vidstedt has updated the pull request inc

Re: RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows [v2]

On Mon, 28 Mar 2022 11:54:28 GMT, Magnus Ihse Bursie wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove PROGRAMFILES workaround > > make/devkit/createWindowsDevkit.sh li

RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.1.0. This change adds support for building devkits based on VS 2022. Instead of creating a new script file for that I decided to combine it with the logic in createWindowsDevkit2019.sh and

Integrated: 8283057: Update GCC to version 11.2 for Oracle builds on Linux

On Fri, 18 Mar 2022 20:33:54 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of GCC for building the JDK on Linux to 11.2. > > Testing: tier1-5 + additional significant testing. Re-running > tier1,builds-tier{2,3,4,5} now for good luck. This pull request has now bee

RFR: 8283057: Update GCC to version 11.2 for Oracle builds on Linux

Oracle is updating the version of GCC for building the JDK on Linux to 11.2. Testing: tier1-5 + additional significant testing. Re-running tier1,builds-tier{2,3,4,5} now for good luck. - Commit messages: - gcc11.2.0 Changes: https://git.openjdk.java.net/jdk/pull/7871/files

Integrated: 8283062: Uninitialized warnings in libgtest with GCC 11.2

On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt wrote: > Background, from JBS: > > In file included from > googletest-release-1.8.1/googletest/src/gtest-all.cc:42: > googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function > 'bool testing::intern

RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2

Background, from JBS: In file included from googletest-release-1.8.1/googletest/src/gtest-all.cc:42: googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()': googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1224:24: error:

Integrated: 8279884: Use better file for cygwin source permission check

On Tue, 11 Jan 2022 21:07:17 GMT, Mikael Vidstedt wrote: > For sanity, configure tries to verify that source files have the right > permissions by checking the LICENSE file in TOPDIR. That file may not always > be available, and for builds where it isn't configure will generate a &g

RFR: 8279884: Use better file for cygwin source permission check

For sanity, configure tries to verify that source files have the right permissions by checking the LICENSE file in TOPDIR. That file may not always be available, and for builds where it isn't configure will generate a (harmless) error along the lines of: - Commit messages: -

Integrated: 8266839: Enable pandoc on macosx-aarch64 at Oracle

On Wed, 1 Dec 2021 18:37:53 GMT, Mikael Vidstedt wrote: > Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. > > Testing: > > * Passes tier1 > * Verified that the product bundle includes man pages as expected > * Sampling a few of the man pages

Re: RFR: 8266839: Enable pandoc on macosx-aarch64 at Oracle

On Wed, 1 Dec 2021 18:37:53 GMT, Mikael Vidstedt wrote: > Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. > > Testing: > > * Passes tier1 > * Verified that the product bundle includes man pages as expected > * Sampling a few of the man pages they loo

RFR: 8266839: Enable pandoc on macosx-aarch64 at Oracle

Enabling pandoc on macosx-aarch64 at Oracle to produce man pages etc. Testing: * Passes tier1 * Verified that the product bundle includes man pages as expected * Sampling a few of the man pages they look as expected - Commit messages: - 8266839: Enable pandoc on macosx-aarch64

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >>

Integrated: 8267636: Bump minimum boot jdk to JDK 17

On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds This pull request has now been integrated. Changeset: 75404ea2 Author:Mikael V

RFR: 8267636: Bump minimum boot jdk to JDK 17

With the JDK 17 GA out it's time to bump the minimum boot JDK version for mainline/JDK 18. Testing: tier1-5, GHA builds - Commit messages: - 8267636: Bump minimum boot jdk to JDK 17 Changes: https://git.openjdk.java.net/jdk/pull/5639/files Webrev:

Re: RFR: Merge jdk17 [v2]

On Mon, 2 Aug 2021 23:53:59 GMT, Jesper Wilhelmsson wrote: >> Forwardport JDK 17 -> JDK 18 > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Revert "8271150: Remove EA from JDK 17 version string starting with Initial

Re: [jdk17] RFR: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)

On Fri, 30 Jul 2021 06:47:07 GMT, Saravana Kumar Vijayasekaran wrote: > 8271150: Remove EA from JDK 17 version string starting with Initial RC > promotion on Aug 5, 2021(B34) Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/297

Re: RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf wrote: > Hi! > > Please review this tiny patch which removes the special casing of > `--with-native-debug-symbols=external` for the static libs build. I don't see > why this is needed. If no debug symbols are wanted >

Re: [jdk17] RFR: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848

On Wed, 14 Jul 2021 07:34:58 GMT, Erik Joelsson wrote: > This patch extends the filter for marker files when creating jmods. Our > latest established marker file format is `_*.marker` and through > ExecuteWithLog, we regularly append additional suffixes to such file names. > Thus I propose we

Re: [jdk17] RFR: 8268861: Disable Windows-Aarch64 build in GitHub Actions [v3]

On Wed, 16 Jun 2021 04:53:08 GMT, David Holmes wrote: >> This has been failing for a while so disabling it until it can be fixed. >> >> Thanks, >> David > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > Completely remove

Integrated: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

On Thu, 3 Jun 2021 21:24:21 GMT, Mikael Vidstedt wrote: > Mimic what's being done on linux-x64 for consistency. This pull request has now been integrated. Changeset: e2d5ff9d Author: Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/com

RFR: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

Mimic what's being done on linux-x64 for consistency. - Commit messages: - 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle Changes: https://git.openjdk.java.net/jdk/pull/4347/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4347=00

Integrated: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle

On Thu, 3 Jun 2021 18:24:51 GMT, Mikael Vidstedt wrote: > With promoted builds available it's a good time to switch the boot JDK etc. This pull request has now been integrated. Changeset: 1b4378e5 Author: Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/com

RFR: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle

With promoted builds available it's a good time to switch the boot JDK etc. - Commit messages: - Merge branch 'master' into 8268142-macos-aarch64-jdk17 - 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle Changes: https://git.openjdk.java.net/jdk/pull/4341/files Webrev:

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt wrote: >> Apple rebranded the operating system as "macOS" back in 2016. The JDK >> bundles files are still use the legacy "osx" string. They should be >> modernized to use "macos" instead.

Integrated: 8266318: Switch to macos prefix for macOS bundles

On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt wrote: > Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. This pull requ

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. Mikael Vidstedt has updated the pull request incrementally with one add

RFR: 8266318: Switch to macos prefix for macOS bundles

Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles files are still use the legacy "osx" string. They should be modernized to use "macos" instead. - Commit messages: - 8266318: Switch to macos prefix for macOS bundles Changes:

Integrated: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not

RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 from early December, so does not include all the JDK 16 GA functionality. This leads to build issues after JDK-8263621 which uses a method not included in the custom version. Let's bump the bootjdk used for macosx-aarch64

Integrated: 8257459: Bump minimum boot jdk to JDK 16

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. This pull request has now been integrated. Changeset: 72c88fc4 Author:Mikael V

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. Joe, Iris, Erik - thank you for the reviews! - PR: https://git.openjdk.

RFR: 8257459: Bump minimum boot jdk to JDK 16

With JDK 16 having gone GA about a month ago it's time to bump the minimum boot JDK version for mainline/JDK 17. Testing: tier1-5. - Commit messages: - Update GHA configuration - 8257459: Bump minimum boot jdk to JDK 16 Changes: https://git.openjdk.java.net/jdk/pull/3555/files

Re: RFR: JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle [v2]

On Fri, 16 Apr 2021 20:36:05 GMT, Erik Joelsson wrote: >> Oracle is updating the version of GCC for building the JDK to 10.3. >> >> In addition to the version bump, I'm also enabling cross compilation OOTB >> using jib from a linux-aarch64 to linux-x64 binaries, which was the last >> missing

Re: RFR: JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle

On Fri, 16 Apr 2021 19:21:11 GMT, Erik Joelsson wrote: > Oracle is updating the version of GCC for building the JDK to 10.3. > > In addition to the version bump, I'm also enabling cross compilation OOTB > using jib from a linux-aarch64 to linux-x64 binaries, which was the last > missing

Re: RFR: JDK-8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle

On Fri, 16 Apr 2021 18:58:27 GMT, Erik Joelsson wrote: > Oracle is updating the minor version of Visual Studio for building the JDK to > 16.9.3. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3550

Integrated: 8264224: Add macosx-aarch64 to Oracle build configurations

On Tue, 30 Mar 2021 06:25:21 GMT, Mikael Vidstedt wrote: > This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. This pull request has now been integrated. Changeset: 008fc75a Author:Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v4]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into 8264224-macosx-aarch64 -

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v3]

On Wed, 31 Mar 2021 19:02:46 GMT, Mikael Vidstedt wrote: >> This adds the necessary macosx-aarch64 support to the build configurations >> at Oracle. > > Mikael Vidstedt has updated the pull request with a new target base due to a > merge or a rebase. The pull request now c

Integrated: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

On Wed, 7 Apr 2021 22:22:55 GMT, Mikael Vidstedt wrote: > Switch to Xcode 12.4 for building macosx-x64 at Oracle. The new lldb > dependency is needed to ensure that we can collect information when testing > on older versions of macOS which do not support Xcode 12.4. This pull reques

RFR: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

Switch to Xcode 12.4 for building macosx-x64 at Oracle. The new lldb dependency is needed to ensure that we can collect information when testing on older versions of macOS which do not support Xcode 12.4. - Commit messages: - 8264623: Change to Xcode 12.4 for building on Macos at

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v3]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

On Tue, 30 Mar 2021 14:42:22 GMT, Kevin Rushforth wrote: >> To answer Magnus, on line 1133, we define a different dependency, called >> "lldb". That dependency is an older devkit which only purpose is to provide >> lldb for the failure handler when running tests. We need this because we are

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

On Tue, 30 Mar 2021 12:31:25 GMT, Erik Joelsson wrote: >> I don't think we need to set SETFILE anymore. This used to be needed because >> the SetFile binary in older Xcode versions was 32 bit and Catalina no longer >> supports 32 bit apps. This should definitely not be a problem on aarch64. >

Re: RFR: 8264224: Add macosx-aarch64 to Oracle build configurations [v2]

> This adds the necessary macosx-aarch64 support to the build configurations at > Oracle. Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Remove SETFILE override - Changes: - all: https://git.openjdk.java.n

RFR: 8264224: Add macosx-aarch64 to Oracle build configurations

This adds the necessary macosx-aarch64 support to the build configurations at Oracle. - Commit messages: - 8264224: Add macosx-aarch64 to Oracle build configurations Changes: https://git.openjdk.java.net/jdk/pull/3258/files Webrev:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:08:28 GMT, Mikael Vidstedt wrote: >>> I wonder if this is the right choice >>> ... >>> ``` >>> OopStorageParIterPerf::~OopStorageParIterPerf() { >>> ... >>> ``` >>> >> >> The transition in OopSt

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote: >> Thank you all for your comments regarding W^X implementation. I've made a >> change that reduces the footprint of the implementation, also addressing >> most of the comments. I'll revisit them individually to make sure nothing is >>

Re: [jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh Marked as reviewed by mikael (Reviewer).

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around

Re: RFR: 8257450: Start of release updates for JDK 17

On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: JDK-8257633: Missing -mmacosx-version-min=X flag when linking libjvm

On Fri, 4 Dec 2020 14:44:49 GMT, Erik Joelsson wrote: > We have historically provided -mmacosx-version-min=10.9.0 flags when > compiling and linking all our native executables and libraries on Macosx. > That flag seems to have disappeared when linking libjvm. This is sometimes > causing our

Re: RFR: JDK-8256810: Incremental rebuild broken on Macosx

On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson wrote: > After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't > actually doing the right thing at all. It seems clang on Macosx is > inconsistent with outputting relative or absolute paths in the deps files, so > some files end

Re: RFR: 8255785: X11 libraries should not be required by configure for headless only

On Tue, 3 Nov 2020 00:33:09 GMT, Magnus Ihse Bursie wrote: > If we build a headless only JDK, configure will require X11 libraries and > headers to be present. This used to be necessary, but thanks to massive > cleanups in the AWT headless code, this is no longer the case. > > We should fix

Re: RFR: JDK-8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds

On Thu, 29 Oct 2020 20:53:00 GMT, Erik Joelsson wrote: > The OpenJDK build on Linux will determine if the JVM feature "dtrace" should > be enabled based on the availability of dtrace on the build host. For Oracle > produced OpenJDK builds, we implicitly had this disabled because our build >

Re: RFR: 8254862: lldb in devkit doesn't work

On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/711

Integrated: 8248984: Bump minimum boot jdk to JDK 15

On Wed, 23 Sep 2020 22:32:37 GMT, Mikael Vidstedt wrote: > JDK 15 is now GA. The minimum boot JDK version for mainline/JDK 16 should be > bumped to this version. > > Testing: tier1-5 passed with a slightly earlier version of this change. > Re-running tier1 now for good l

Integrated: 8253616: Change to GCC 10.2 for building on Linux at Oracle

On Thu, 24 Sep 2020 21:31:49 GMT, Mikael Vidstedt wrote: > Please review this change which updates the defaults in the linux devkit > creator, the doc/building.md file, and the JIB > (Oracle) configuration to gcc 10.2. This pull request has now been integrated. Changeset: d25b03

Re: RFR: 8253616: Change to GCC 10.2 for building on Linux at Oracle [v2]

> Please review this change which updates the defaults in the linux devkit > creator, the doc/building.md file, and the JIB > (Oracle) configuration to gcc 10.2. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The pull request now con

Re: RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle [v2]

On Thu, 24 Sep 2020 22:20:47 GMT, Erik Joelsson wrote: >> Oracle is changing the minor version of Visual Studio used for building the >> JDK on Windows. This patch updates the jib >> profiles configuration to point to the new devkit. > > Erik Joelsson has updated the pull request incrementally

RFR: 8253616: Change to GCC 10.2 for building on Linux at Oracle

Please review this change which updates the defaults in the linux devkit creator, the doc/building.md file, and the JIB (Oracle) configuration to gcc 10.2. - Commit messages: - 8253616: Change to GCC 10.2 for building on Linux at Oracle Changes:

Re: RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle

On Thu, 24 Sep 2020 20:25:27 GMT, Erik Joelsson wrote: > Oracle is changing the minor version of Visual Studio used for building the > JDK on Windows. This patch updates the jib > profiles configuration to point to the new devkit. Do you want to update doc/building.{md,html} to reflect the

RFR: 8248984: Bump minimum boot jdk to JDK 15

JDK 15 is now GA. The minimum boot JDK version for mainline/JDK 16 should be bumped to this version. Testing: tier1-5 passed with a slightly earlier version of this change. Re-running tier1 now for good luck. - Commit messages: - 8248984: Bump minimum boot jdk to JDK 15 Changes:

Re: RFC: 8229469 JEP 386: Alpine Linux/x64 Port

Great to see this - thank you for all the great work you’re putting into it! The changes are in line with what I’m expecting given that I’ve looked at them before, so looks good to me! That said, I’ve looked at this so many times now - and after all even authored some of the original changes

RFR(XS): 8251316: Sanity check the JDK under test before running tests

Please review this small change which adds a sanity check run of the JDK under test before running jtreg tests. JBS: https://bugs.openjdk.java.net/browse/JDK-8251316 webrev:

RFR(XS): 8250899: Backout JDK-8249628 from jdk/jdk

Please review this small change which will back out/revert the upcoming change[1] to remove the “ea” suffix from the JDK 15 version string. Specifically, when that change gets pushed to jdk/jdk15 and then bulk integrated to jdk/jdk it needs to be immediately reverted to ensure that jdk/jdk

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

The makefile changes look good to me! Cheers, Mikael > On Jun 16, 2020, at 12:22 PM, Erik Joelsson wrote: > > (re-sending this as it doesn't look like it was delivered) > > There are a lot of jtreg tests that use temporary files. These temporary > files add up over time and fill up the

Re: [16] RFR (XS) 8246803: Update link to license in Docs.gmk

Looks good. Cheers, Mikael > On Jun 8, 2020, at 10:31 PM, Iris Clark wrote: > > Hi. > > Please review this small change to update the link to the Specification > license referenced > by the JavaDoc API for JDK 16: > > bug: > >8246803: Update link to spec license in Docs.gmk >

Re: OpenJDK 10 zero For Mips32el java -version IncompatilveClassChangeError

Glad you got it working! Still curious though: any particular reason for building jdk10 specifically? :) Cheers, Mikael > On Jun 5, 2020, at 3:30 PM, William Larson wrote: > > Hello Mikael, > This is how I get the sources > > hg clone http://hg.openjdk.java.net/jdk10/jdk10 >

Re: OpenJDK 10 zero For Mips32el java -version IncompatilveClassChangeError

> On Jun 5, 2020, at 1:16 PM, Mikael Vidstedt <mailto:mikael.vidst...@oracle.com>> wrote: > > > >> On Jun 5, 2020, at 10:27 AM, William Larson > <mailto:wlars...@gmail.com>> wrote: >> >> Hello Magnus >> >> I got

Re: OpenJDK 10 zero For Mips32el java -version IncompatilveClassChangeError

> On Jun 5, 2020, at 10:27 AM, William Larson wrote: > > Hello Magnus > > I got the source code from the openjdk mercurial repository following the > building.html exactly. Can you give some more details here please - exactly how do you get the sources? > Here is the version numbers >

Re: OpenJDK 10 zero For Mips32el java -version IncompatilveClassChangeError

Where did you grab the source code for the JDK you’re trying to build? Cheers, Mikael > On Jun 4, 2020, at 11:07 PM, William Larson wrote: > > Hello David, > > When running configure > --with-buildjdk=./jdk/build/linux-x86_64-normal-server-release/jdk > > I get the following error > >

Re: OpenJDK 10 zero For Mips32el java -version IncompatilveClassChangeError

Looks like you’re using jdk9 as build jdk for jdk10. The build jdk does need to match the jdk you’re building. As Magnus points out in the email you linked to: "In theory, you should rebuild your buildjdk for each and every change ("make jdk CONF=buildjdk && make images CONF=mips"); but in

Re: RFR: JDK-8245401: AbsPathsInImage.java fails on Windows on jdwp.dll

Looks good. Cheers, Mikael > On May 20, 2020, at 10:51 AM, Erik Joelsson wrote: > > After some recent changes in JDI related code, we now have a new failure in > AbsPathsInImage.java on Windows. This keeps cropping up, so in this change > I'm changing the exception in the test to simply

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Including hotspot-runtime-dev since the zero patch touches hotspot (os_linux) - please review! > On May 12, 2020, at 3:05 PM, John Paul Adrian Glaubitz > wrote: > > Hi Mikael! > > On 5/12/20 12:08 AM, John Paul Adrian Glaubitz wrote: >>> Adrian, did you have a chance to look at the zero

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

> On May 11, 2020, at 3:08 PM, John Paul Adrian Glaubitz > wrote: > > Hi Mikael! > > On 5/12/20 12:05 AM, Mikael Vidstedt wrote: >>>> * GNM - Magnus to file a follow-up RFE >>>> >>>> * Zero - Waiting for somebody (Adrian?) to provide m

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

> On May 7, 2020, at 4:18 AM, John Paul Adrian Glaubitz > wrote: > > Hi Mikael! > > On 5/7/20 2:47 AM, Mikael Vidstedt wrote: >> New webrev available here: >> >> webrev: >> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/w

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

> On May 7, 2020, at 8:53 AM, Magnus Ihse Bursie > wrote: > > > > On 2020-05-07 13:18, John Paul Adrian Glaubitz wrote: >> Hi Mikael! >> >> On 5/7/20 2:47 AM, Mikael Vidstedt wrote: >>> New webrev available here: >>> >>> webrev:

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

be preserved Cheers, Mikael > On May 3, 2020, at 10:12 PM, Mikael Vidstedt > wrote: > > > Please review this change which implements part of JEP 381: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/824

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Magnus, thank you so much for the thorough review!! Will send out a new webrev in a bit, meanwhile some comments inline.. > On May 6, 2020, at 4:04 AM, Magnus Ihse Bursie > wrote: > > Hi Mikael, > > On 2020-05-04 07:12, Mikael Vidstedt wrote: >> Please review this

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

> On May 4, 2020, at 12:44 AM, John Paul Adrian Glaubitz > wrote: > > On 5/4/20 9:39 AM, John Paul Adrian Glaubitz wrote: >> I haven't looked at the changes yet, but please make sure you don't kill the >> possibility to build Zero on SPARC on Linux because that should still work >> without

RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/build/open/webrev/ JEP: https://bugs.openjdk.java.net/browse/JDK-8241787 Note: When reviewing this, please be

Re: RFR: JDK-8244214: Change to VS2019 for building on Windows at Oracle

Looks good. Cheers, Mikael > On Apr 30, 2020, at 3:37 PM, Erik Joelsson wrote: > > Please review this change which changes the compiler version used to build > for Windows at Oracle to Visual Studio 2019. > > http://cr.openjdk.java.net/~erikj/8244214/webrev.01/ > >

Re: RFR(XS): 8244061: Disable jvmci/graal/aot when building linux-aarch64 at Oracle

Vladimir/Magnus/Erik, Thanks for the reviews, change pushed. Cheers, Mikael > On Apr 29, 2020, at 5:45 AM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2020-04-28 21:12, Mikael Vidstedt wrote: >> Please review this small change which disables

Re: RFR(XS): 8244061: Disable jvmci/graal/aot when building linux-aarch64 at Oracle

> On Apr 29, 2020, at 3:44 AM, Andrew Haley wrote: > > On 4/29/20 10:02 AM, Mikael Vidstedt wrote: >> >>> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote: >>> >>> On 4/29/20 5:12 AM, Mikael Vidstedt wrote: >>>> Please review this

Re: RFR(XS): 8244061: Disable jvmci/graal/aot when building linux-aarch64 at Oracle

> On Apr 29, 2020, at 12:46 AM, Andrew Haley wrote: > > On 4/29/20 5:12 AM, Mikael Vidstedt wrote: >> Please review this small change which disables JVMCI, Graal, and AOT when >> building linux-aarch64 at Oracle, for now. >> >> JBS: https://bugs.openjdk.java

Re: RFR(XS): 8244061: Disable jvmci/graal/aot when building linux-aarch64 at Oracle

correctly, this disables building jvmci/graal/aot in *any* > linux-aarch64 jib based build, not just those done at Oracle. Wouldn’t this > be better done on the jib command line? > > -Doug > >> On 29 Apr 2020, at 06:12, Mikael Vidstedt wrote: >> >> >> Plea

RFR(XS): 8244061: Disable jvmci/graal/aot when building linux-aarch64 at Oracle

Please review this small change which disables JVMCI, Graal, and AOT when building linux-aarch64 at Oracle, for now. JBS: https://bugs.openjdk.java.net/browse/JDK-8244061 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244061/webrev.00/open/webrev/ Cheers, Mikael

Re: RFR: 8243634: Add pandoc dependency when building linux-aarch64 at Oracle

I take that back - the original change (webrev.00) is good, so I’ll use that. Cheers, Mikael > On Apr 28, 2020, at 6:13 PM, Mikael Vidstedt > wrote: > > > New version which only adds the dependency when cross compiling, for now: > > http://cr.openjdk.java.net/~m

Re: RFR: 8243634: Add pandoc dependency when building linux-aarch64 at Oracle

New version which only adds the dependency when cross compiling, for now: http://cr.openjdk.java.net/~mikael/webrevs/8243634/webrev.01/open/webrev/ Cheers, Mikael > On Apr 27, 2020, at 1:00 AM, Magnus Ihse Bursie > wrote: > > On 2020-04-27 07:51, Mikael Vidstedt wrote: >>

Re: RFR: 8243633: Remove cups dependency when building linux at Oracle

Magnus/Tim/Erik, thanks for the reviews! Change pushed. Cheers, Mikael > On Apr 27, 2020, at 1:58 PM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2020-04-27 12:30, Mikael Vidstedt wrote: >> Ah, good point/catch! I updated the title of the JBS issue

Re: RFR: 8243633: Remove cups dependency when building linux at Oracle (was: Remove cups dependency when building linux-aarch64 at Oracle)

AM, Magnus Ihse Bursie > wrote: > > On 2020-04-27 07:49, Mikael Vidstedt wrote: >> As on linux-x64, cups is already in the devkit, so no need for the explicit >> extra dependency. > Actually, I realized this goes for all our cross-platform linux devkits, i.e. > pp

RFR: 8243633: Remove cups dependency when building linux-aarch64 at Oracle

As on linux-x64, cups is already in the devkit, so no need for the explicit extra dependency. JBS: https://bugs.openjdk.java.net/browse/JDK-8243633 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8243633/webrev.00/open/webrev/ Cheers, Mikael

  1   2   >