Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. [v2]

2021-10-07 Thread Richard Reingruber
On Tue, 5 Oct 2021 07:38:28 GMT, Richard Reingruber wrote: >> The following sentence in the JDWP Specification describing the Dispose >> command confuses resume with suspend [1]: >> >> All threads suspended by the thread-level **resume** command or the >> VM

Integrated: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-07 Thread Richard Reingruber
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** comm

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. [v2]

2021-10-05 Thread Richard Reingruber
On Mon, 4 Oct 2021 18:20:42 GMT, Chris Plummer wrote: > > > Can you update the copyright please? Sure, thanks! > I checked the JDI spec and it looks correct there, which is actually > surprising since errors like this usually appear in both specs. Yes I noticed this too. Thanks for reviewi

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. [v2]

2021-10-05 Thread Richard Reingruber
com/en/java/javase/17/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_Dispose) Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision: Updated copyright. - Changes: - all: https://git.openjdk.java.net/jdk/pull/5804/files

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
On Mon, 4 Oct 2021 14:22:50 GMT, Alan Bateman wrote: > > > It looks like this typo goes all the way back to JDK 1.2 but was not noticed. Thanks for reviewing. JDK 1.2 is surely long ago. Nevertheless not too many will have read that sentence since then I reckon ;) - PR: https://

RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
The following sentence in the JDWP Specification describing the Dispose command confuses resume with suspend [1]: All threads suspended by the thread-level **resume** command or the VM-level **resume** command are resumed as many times as necessary for them to run. It should be changed to

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-06-28 Thread Richard Reingruber
On Wed, 16 Jun 2021 16:13:58 GMT, jtfuller111 wrote: >> Hello, could anyone kindly take a look at this? > >> Hi @jtfuller111, >> >> I've tested the fix and found that it eliminates the random moves of the >> view port when zooming. Thumbs up for that. It still changes the point that >> is cen

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered [v2]

2021-06-16 Thread Richard Reingruber
On Wed, 16 Jun 2021 15:54:14 GMT, jtfuller111 wrote: >> Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming >> now works as expected. > > jtfuller111 has updated the pull request incrementally with one additional > commit since the last revision: > > Zooming now act

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-06-15 Thread Richard Reingruber
On Thu, 10 Jun 2021 20:49:06 GMT, jtfuller111 wrote: >> Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming >> now works as expected. > > Hello, could anyone kindly take a look at this? Hi @jtfuller111, I've tested the fix and found that it eliminates the random moves

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Richard Reingruber
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote: >> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS >> issue. >> >> I fixed the issue in the harfbuzz sources, but I am not sure of the policy >> here. Do we modify the harfbuzz sources or leave them untouched? Advi

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-05 Thread Richard Reingruber
On Fri, 5 Mar 2021 11:11:44 GMT, Alan Hayward wrote: >>> I was building this PR on a new machine, and I now get the following error: >>> >>> > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31: >>> > error: cast to smaller integer t