RE: code review round 0 for minor FDS makefile fix (8033714)

2014-02-05 Thread Ron Durbin
Dan The changes look good Ron -Original Message- From: Daniel D. Daugherty Sent: Wednesday, February 05, 2014 4:21 PM To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.java.net; build-dev; Doug Simon; Tom Rodriguez Subject: code review round 0 for minor FDS

RE: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

2013-10-02 Thread Ron Durbin
Dan You have my thumbs up changes look good -Original Message- From: David Holmes Sent: Tuesday, October 01, 2013 8:53 PM To: Daniel Daugherty Cc: serviceability-...@openjdk.java.net; build-dev; hotspot-runtime-...@openjdk.java.net Subject: Re: code review round 0 for Full

RE: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-24 Thread Ron Durbin
I am not an official open source code reviewer, but I did review the code and it looks good.   Ron   From: Lois Foltan Sent: Thursday, September 19, 2013 9:11 AM To: hotspot-runtime-...@openjdk.java.net; build-dev@openjdk.java.net Subject: RFR (L) JDK-7195622: CheckUnhandledOops has limited

RE: S RFR JDK-8024050: Incorrect optimization level and comment specified for unsafe.cpp

2013-08-30 Thread Ron Durbin
Lois I am unofficial reviewer, but the change looks good. Ron -Original Message- From: Lois Foltan Sent: Friday, August 30, 2013 11:18 AM To: hotspot-runtime-...@openjdk.java.net; build-dev@openjdk.java.net Subject: S RFR JDK-8024050: Incorrect optimization level and comment

RE: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Ron Durbin
Your code looks good and it resolves the reported defect. -Original Message- From: Daniel D. Daugherty Sent: Friday, August 02, 2013 4:36 PM To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.java.net; build-dev Subject: code review (round 0) request for VS2010

RE: HSX-25: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Ron Durbin
Dan These changes look good. Ron -Original Message- From: Daniel D. Daugherty Sent: Tuesday, June 18, 2013 2:30 PM To: hotspot-runtime-...@openjdk.java.net; build-dev Subject: HSX-25: Code Review (round 0) request for MacOS X exported symbols fix (8014326) Greetings, I have

RE: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-19 Thread Ron Durbin
Dan These changes look good. Ron -Original Message- From: Daniel D. Daugherty Sent: Tuesday, June 18, 2013 2:50 PM To: hotspot-runtime-...@openjdk.java.net; build-dev Subject: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326) Greetings, I have

RE: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code

2012-12-19 Thread Ron Durbin
Harold, Did you have any more points or counter points to make on the use of snprintf and strncpy ? Ron From: Ron Durbin Sent: Tuesday, December 18, 2012 4:50 PM To: Daniel Daugherty; hotspot-runtime-...@openjdk.java.net; build-dev; serviceability-...@openjdk.java.net Subject: RE

RE: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code

2012-12-19 Thread Ron Durbin
9:17 AM, Ron Durbin wrote: Harold, Did you have any more points or counter points to make on the use of snprintf and strncpy ? Ron From: Ron Durbin Sent: Tuesday, December 18, 2012 4:50 PM To: Daniel Daugherty; HYPERLINK mailto:hotspot-runtime-...@openjdk.java.nethotspot-runtime

FW: Code Review fix for 7153050 ?remove crufty '_g' support from HotSpot run time

2012-12-18 Thread Ron Durbin
Intro: This set of changes removes the runtime support for generation of debug versions that follow _g semantics. Defect: JDK-8005044 remove crufty '_g' support from HS runtime code Webrev /u/rdurbin/8005044_exp/webrev/index.html Details: Files have been modified to remove

RE: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code

2012-12-18 Thread Ron Durbin
, I'm sponsoring this code review request from Ron Durbin. This change is targeted at JDK8/HSX-25 in the RT_Baseline repo. Dan Sending again with correct subject line, bug URLs and webrev URL. Intro: This set of changes removes the runtimesupport for generation of debug versions

RE: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code

2012-12-18 Thread Ron Durbin
/18/2012 3:46 PM, Daniel D. Daugherty wrote: Greetings, I'm sponsoring this code review request from Ron Durbin. This change is targeted at JDK8/HSX-25 in the RT_Baseline repo. Dan Sending again with correct subject line, bug URLs and webrev URL. Intro: This set of changes removes

RE: code review request for 7153050 remove crufty '_g' support

2012-12-13 Thread Ron Durbin
Thx again -Original Message- From: Daniel D. Daugherty Sent: Thursday, December 13, 2012 1:51 PM To: build-dev; serviceability-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net; Ron Durbin Subject: Re: code review request for 7153050 remove crufty '_g' support Serguei

RE: code review request for 7153050 remove crufty '_g' support

2012-12-13 Thread Ron Durbin
to the current module, jvm.dll or jvm_g.dll ./share/tools/ProjectCreator/ProjectCreator.java:+ jvm.dll and jvm_g.dll; no trailing slash); Thanks, Coleen On 12/13/2012 03:53 PM, Ron Durbin wrote: Thx again -Original Message- From: Daniel D. Daugherty Sent: Thursday, December 13