Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-30 Thread Andrew Dinn
On 30/07/2019 14:25, Andrew John Hughes wrote: > On 30/07/2019 09:48, Andrew Dinn wrote: >> I agree that this is needed. I also understand why Andrew is loath to >> see changes that are not upstream. However, in this case I don't think >> we can avoid adding changes that cause a difference from ups

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-30 Thread Andrew John Hughes
On 30/07/2019 09:48, Andrew Dinn wrote: > On 29/07/2019 19:30, Aleksey Shipilev wrote: >> On 7/29/19 7:37 PM, Severin Gehwolf wrote: >>> So, in light of the changed build system in JDK 9+, and the rather >>> small changes in this patch (on the grand scheme of things), it seems >>> reasonable to imp

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-30 Thread Andrew Dinn
On 29/07/2019 19:30, Aleksey Shipilev wrote: > On 7/29/19 7:37 PM, Severin Gehwolf wrote: >> So, in light of the changed build system in JDK 9+, and the rather >> small changes in this patch (on the grand scheme of things), it seems >> reasonable to implement this feature in the way proposed. It's

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-29 Thread Aleksey Shipilev
On 7/29/19 7:37 PM, Severin Gehwolf wrote: > So, in light of the changed build system in JDK 9+, and the rather > small changes in this patch (on the grand scheme of things), it seems > reasonable to implement this feature in the way proposed. It's a JDK 8u > *enhancement* after all. I am with Sev

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-29 Thread Severin Gehwolf
On Mon, 2019-07-29 at 16:32 +0100, Andrew John Hughes wrote: > > On 29/07/2019 11:10, Severin Gehwolf wrote: > > On Mon, 2019-07-29 at 10:19 +0100, Andrew Dinn wrote: > > > On 26/07/2019 18:32, Andrew John Hughes wrote: > > > > On 26/07/2019 16:53, Severin Gehwolf wrote: > > [...] > > > > > > What

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-29 Thread Andrew John Hughes
On 29/07/2019 11:10, Severin Gehwolf wrote: > On Mon, 2019-07-29 at 10:19 +0100, Andrew Dinn wrote: >> On 26/07/2019 18:32, Andrew John Hughes wrote: >>> On 26/07/2019 16:53, Severin Gehwolf wrote: > [...] > What exactly is being pushed > here? The following 4 patches: >>>

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-29 Thread Severin Gehwolf
On Mon, 2019-07-29 at 10:19 +0100, Andrew Dinn wrote: > On 26/07/2019 18:32, Andrew John Hughes wrote: > > On 26/07/2019 16:53, Severin Gehwolf wrote: [...] > > > > > > > What exactly is being pushed > > > > here? > > > > > > The following 4 patches: > > > > > > jdk: > > > http://cr.openj

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-29 Thread Andrew Dinn
On 26/07/2019 18:32, Andrew John Hughes wrote: > On 26/07/2019 16:53, Severin Gehwolf wrote: >> Hi Andrew, >> >> On Fri, 2019-07-26 at 14:46 +0100, Andrew John Hughes wrote: >>> On 25/07/2019 16:02, Severin Gehwolf wrote: >>> >>> snip... >>> > Done now. I've added fix-request comments/labels to

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Andrew John Hughes
On 26/07/2019 16:53, Severin Gehwolf wrote: > Hi Andrew, > > On Fri, 2019-07-26 at 14:46 +0100, Andrew John Hughes wrote: >> On 25/07/2019 16:02, Severin Gehwolf wrote: >> >> snip... >> Done now. I've added fix-request comments/labels to the above bugs and rebased on top of them. New

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Severin Gehwolf
Hi Andrew, On Fri, 2019-07-26 at 14:46 +0100, Andrew John Hughes wrote: > On 25/07/2019 16:02, Severin Gehwolf wrote: > > snip... > > > > Done now. I've added fix-request comments/labels to the above bugs and > > > rebased on top of them. New jdk changeset: > > > http://cr.openjdk.java.net/~sgeh

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Andrew John Hughes
On 25/07/2019 16:02, Severin Gehwolf wrote: snip... >> >> Done now. I've added fix-request comments/labels to the above bugs and >> rebased on top of them. New jdk changeset: >> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/04/jdk/webrev/ >> >> Test groups definition is the JDK 9 set p

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Severin Gehwolf
On Fri, 2019-07-26 at 10:44 +0200, Aleksey Shipilev wrote: > On 7/25/19 5:02 PM, Severin Gehwolf wrote: > > Any more thoughts? > > I think we should go on with it. The lack of tier1 in jdk8u is a serious > impediment for backports. I > have applied all the recent patches (04/jdk, 03/hotspot, 03/l

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Severin Gehwolf
On Fri, 2019-07-26 at 10:44 +0200, Aleksey Shipilev wrote: > On 7/25/19 5:02 PM, Severin Gehwolf wrote: > > Any more thoughts? > > I think we should go on with it. The lack of tier1 in jdk8u is a serious > impediment for backports. I > have applied all the recent patches (04/jdk, 03/hotspot, 03/l

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-26 Thread Aleksey Shipilev
On 7/25/19 5:02 PM, Severin Gehwolf wrote: > Any more thoughts? I think we should go on with it. The lack of tier1 in jdk8u is a serious impediment for backports. I have applied all the recent patches (04/jdk, 03/hotspot, 03/langtools/ 02/top), and tier1 works for me. That is, it produces test f

Re: [8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

2019-07-25 Thread Severin Gehwolf
On Mon, 2019-07-08 at 14:35 +0200, Severin Gehwolf wrote: > Hi Andrew, > > On Fri, 2019-06-28 at 14:45 +0100, Andrew John Hughes wrote: > > On 28/06/2019 10:52, Severin Gehwolf wrote: > > > Hi Andrew, > > > > > > On Thu, 2019-06-27 at 17:36 +0100, Andrew John Hughes wrote: > > > > On 22/05/2019 1