Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-10-06 Thread Daniel D. Daugherty
Sorry for missing this review request. I'm still learning to deal with my new e-mail filters (restored from memory after losing my MacBook Pro env). On 9/30/15 6:43 AM, Erik Joelsson wrote: Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-10-06 Thread Bengt Rutisson
Hi Erik, On 2015-10-05 11:38, Erik Joelsson wrote: Another friendly bump for an 8u (R)eviewer for this. Rubber stamped. (Thanks for walking me through the patch, Erik!) Bengt /Erik On 2015-10-01 15:16, Erik Joelsson wrote: Still looking for an official review from 8u reviewer for this.

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-10-05 Thread Erik Joelsson
Another friendly bump for an 8u (R)eviewer for this. /Erik On 2015-10-01 15:16, Erik Joelsson wrote: Still looking for an official review from 8u reviewer for this. Ideally someone from Hotspot. /Erik On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and review this fix for

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-10-01 Thread Erik Joelsson
Still looking for an official review from 8u reviewer for this. Ideally someone from Hotspot. /Erik On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-10-01 Thread Mikael Vidstedt
Looks ok. (This really needs to be unified, but we know that) Cheers, Mikael On 2015-10-01 06:16, Erik Joelsson wrote: Still looking for an official review from 8u reviewer for this. Ideally someone from Hotspot. /Erik On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-09-30 Thread Rob McKenna
Approved. -Rob On 30/09/15 14:30, Magnus Ihse Bursie wrote: On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix and the problem is still there.

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-09-30 Thread Magnus Ihse Bursie
On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix and the problem is still there. There are more discrepancies between Solaris and the other platform

[8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-09-30 Thread Erik Joelsson
Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix and the problem is still there. There are more discrepancies between Solaris and the other platform makefiles. The excludeSrc.gmk file is not