Re: [9] Review Request: 8047336 Read flavormap.properties as resource

The makefile changes look fine to me. (The use of OPENJDK as part of the variable names seems excessive but that's not something your patch adds or changes) Mike On Jul 9 2014, at 23:55 , Petr Pchelko wrote: > Hello, Build Team. > > This is a reminder. Could you please review the build part

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Build Team. This is a reminder. Could you please review the build part of the following fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ Thank you. With best regards. Petr. On 02 июля 2014 г., at 15:13, Anthony Petrov wrote: > Thanks. Note that your email editor messed up t

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Thanks. Note that your email editor messed up the HTML part of the email (see below a text-only quote), so here's the correct link to the webrev: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ The fix looks fine to me. -- best regards, Anthony On 7/2/2014 3:10 PM, Petr Pchelko wrote

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 02/07/2014 12:10, Petr Pchelko wrote: Hello, Anthony, Alan. Thank you for the review, the new version is located here: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ I've changed the code to throw an InternalError if we

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Anthony, Alan. Thank you for the review, the new version is located here: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ I've changed the code to throw an InternalError if we cannot read properties. Once I get feedback from the build team - I'll push this fix. With best regards.

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 01/07/2014 09:35, Petr Pchelko wrote: Hello, The changes in the public API have been approved, so let me continue the review process. For your convenience: The bug: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hi Petr, The fix looks fine to me. Only one question: src/share/classes/java/awt/datatransfer/SystemFlavorMap.java 234 } catch (IOException e) { 235 System.err.println("Warning reading flavor mapping: " + e.getMessage()); Is there a reason to hide the stack trace of the

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, The changes in the public API have been approved, so let me continue the review process. For your convenience: The bug: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ Until now we've been discussing an abstract question

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 20/06/2014 12:41, Petr Pchelko wrote: Hello, Anthony, Artem. Do we officially declare that we drop support for this possibility? This possibility will be dropped regardless of the current Petr's fix, since there will be no single "jre" folder in jigsaw world. Probably, some other mechanism

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

I see. OK then. But this looks like something that needs to be release-noted. -- best regards, Anthony On 6/20/2014 3:41 PM, Petr Pchelko wrote: Hello, Anthony, Artem. Do we officially declare that we drop support for this possibility? This possibility will be dropped regardless of the curr

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Anthony, Artem. >> Do we officially declare that we drop support for this possibility? > This possibility will be dropped regardless of the current Petr's fix, since > there will be no single "jre" folder in jigsaw world. Probably, some other > mechanism to customize files like flavormap.

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 6/20/2014 3:29 PM, Artem Ananiev wrote: On 6/20/2014 3:19 PM, Anthony Petrov wrote: I ran the following query: https://www.google.com/#q=custom+flavormap.properties and the search yielded the following forum thread: https://community.oracle.com/thread/1293314?start=0&tstart=0 where develo

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 6/20/2014 3:19 PM, Anthony Petrov wrote: Hi Petr, I ran the following query: https://www.google.com/#q=custom+flavormap.properties and the search yielded the following forum thread: https://community.oracle.com/thread/1293314?start=0&tstart=0 where developers seem to suggest they do edit

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hi Petr, I ran the following query: https://www.google.com/#q=custom+flavormap.properties and the search yielded the following forum thread: https://community.oracle.com/thread/1293314?start=0&tstart=0 where developers seem to suggest they do edit the $JDKHOME/jre/lib/flavormap.properties fi

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Alan. Thank you for the review. > Do we know if anyone has been editing the file in ${java.home}/lib? I couldn't find any examples on the internet although I've done a very extensive search, so I we could add a property later if someone would request it. With best regards. Petr. On 19

[9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ This is another step in datatransfer modularization work. This part of the work needs a CCC, so I've moved it out to a s

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

On 19/06/2014 12:17, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ This is another step in datatransfer modularization work. This part of the work